LinuxLists.cc - [PATCH] thermal/drivers/mediatek/lvts_thermal: Fix a memory leak in an error handling path

2024-01-28 08:39:37

Subject: [PATCH] thermal/drivers/mediatek/lvts_thermal: Fix a memory leak in an error handling path

If devm_krealloc() fails, then 'efuse' is leaking.
So free it to avoid a leak.

Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/thermal/mediatek/lvts_thermal.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index 98d9c80bd4c6..fd4bd650c77a 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -719,8 +719,10 @@ static int lvts_calibration_read(struct device *dev, struct lvts_domain *lvts_td

lvts_td->calib = devm_krealloc(dev, lvts_td->calib,
lvts_td->calib_len + len, GFP_KERNEL);
- if (!lvts_td->calib)
+ if (!lvts_td->calib) {
+ kfree(efuse);
return -ENOMEM;
+ }

memcpy(lvts_td->calib + lvts_td->calib_len, efuse, len);

--
2.43.0

2024-01-29 15:53:53

by Matthias Brugger

[permalink] [raw]

Subject: Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Fix a memory leak in an error handling path

On 28/01/2024 09:38, Christophe JAILLET wrote:
> If devm_krealloc() fails, then 'efuse' is leaking.
> So free it to avoid a leak.
>
> Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: Matthias Brugger <[email protected]>

> ---
> drivers/thermal/mediatek/lvts_thermal.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 98d9c80bd4c6..fd4bd650c77a 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -719,8 +719,10 @@ static int lvts_calibration_read(struct device *dev, struct lvts_domain *lvts_td
>
> lvts_td->calib = devm_krealloc(dev, lvts_td->calib,
> lvts_td->calib_len + len, GFP_KERNEL);
> - if (!lvts_td->calib)
> + if (!lvts_td->calib) {
> + kfree(efuse);
> return -ENOMEM;
> + }
>
> memcpy(lvts_td->calib + lvts_td->calib_len, efuse, len);
>

2024-01-30 08:37:00

by AngeloGioacchino Del Regno

[permalink] [raw]

Subject: Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Fix a memory leak in an error handling path

Il 28/01/24 09:38, Christophe JAILLET ha scritto:
> If devm_krealloc() fails, then 'efuse' is leaking.
> So free it to avoid a leak.
>
> Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2024-01-30 09:56:12

by Daniel Lezcano

[permalink] [raw]