Hi,
This is the 3rd round of tracepoints patch submisison. The instrumentation
sites the more likely to come to a quick agreement has been selected in this
first step. The tracepoint infrastructure, heavily inspired from the kernel
markers, seems pretty solid and went through a thorough review by Masami.
This patchset applies over patch-v2.6.26-rc9-next-20080709.
Mathieu
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
Hi Mathieu,
I couldn't find your 15th patch in my mailbox, neither lkml archive.
Could you resend it?
Thank you,
Mathieu Desnoyers wrote:
> Hi,
>
> This is the 3rd round of tracepoints patch submisison. The instrumentation
> sites the more likely to come to a quick agreement has been selected in this
> first step. The tracepoint infrastructure, heavily inspired from the kernel
> markers, seems pretty solid and went through a thorough review by Masami.
>
> This patchset applies over patch-v2.6.26-rc9-next-20080709.
>
> Mathieu
>
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: [email protected]
* Masami Hiramatsu ([email protected]) wrote:
> Hi Mathieu,
>
> I couldn't find your 15th patch in my mailbox, neither lkml archive.
> Could you resend it?
>
> Thank you,
>
Sure, I think quilt had some problem with it because of a ill formatted
email. Here it is.
Instrument addr_add and del of network interfaces. Lets a tracer know the
interface address changes.
Those tracepoints are used by LTTng.
About the performance impact of tracepoints (which is comparable to markers),
even without immediate values optimizations, tests done by Hideo Aoki on ia64
show no regression. His test case was using hackbench on a kernel where
scheduler instrumentation (about 5 events in code scheduler code) was added.
See the "Tracepoints" patch header for performance result detail.
Signed-off-by: Mathieu Desnoyers <[email protected]>
CC: Pekka Savola <[email protected]>
CC: [email protected]
CC: David S. Miller <[email protected]>
CC: Alexey Kuznetsov <[email protected]>
CC: Masami Hiramatsu <[email protected]>
CC: 'Peter Zijlstra' <[email protected]>
CC: "Frank Ch. Eigler" <[email protected]>
CC: 'Ingo Molnar' <[email protected]>
CC: 'Hideo AOKI' <[email protected]>
CC: Takashi Nishiie <[email protected]>
CC: 'Steven Rostedt' <[email protected]>
CC: Eduard - Gabriel Munteanu <[email protected]>
---
net/ipv6/addrconf.c | 4 ++++
net/ipv6/ipv6-trace.h | 14 ++++++++++++++
2 files changed, 18 insertions(+)
Index: linux-2.6-lttng/net/ipv6/addrconf.c
===================================================================
--- linux-2.6-lttng.orig/net/ipv6/addrconf.c 2008-07-09 10:55:46.000000000 -0400
+++ linux-2.6-lttng/net/ipv6/addrconf.c 2008-07-09 10:58:43.000000000 -0400
@@ -85,6 +85,7 @@
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
+#include "ipv6-trace.h"
/* Set to 3 to get tracing... */
#define ACONF_DEBUG 2
@@ -650,6 +651,8 @@ ipv6_add_addr(struct inet6_dev *idev, co
/* For caller */
in6_ifa_hold(ifa);
+ trace_ipv6_addr_add(ifa);
+
/* Add to big hash table */
hash = ipv6_addr_hash(addr);
@@ -2163,6 +2166,7 @@ static int inet6_addr_del(struct net *ne
in6_ifa_hold(ifp);
read_unlock_bh(&idev->lock);
+ trace_ipv6_addr_del(ifp);
ipv6_del_addr(ifp);
/* If the last address is deleted administratively,
Index: linux-2.6-lttng/net/ipv6/ipv6-trace.h
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ linux-2.6-lttng/net/ipv6/ipv6-trace.h 2008-07-09 10:58:43.000000000 -0400
@@ -0,0 +1,14 @@
+#ifndef _IPV6_TRACE_H
+#define _IPV6_TRACE_H
+
+#include <net/if_inet6.h>
+#include <linux/tracepoint.h>
+
+DEFINE_TRACE(ipv6_addr_add,
+ TPPROTO(struct inet6_ifaddr *ifa),
+ TPARGS(ifa));
+DEFINE_TRACE(ipv6_addr_del,
+ TPPROTO(struct inet6_ifaddr *ifa),
+ TPARGS(ifa));
+
+#endif
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68