2019-04-23 14:37:19

by Yue Haibing

Subject: [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()

From: YueHaibing <[email protected]>

rtas_parse_epow_errlog() should pass 'modifier' to
handle_system_shutdown, because event modifier only use
bottom 4 bits.

Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
Signed-off-by: YueHaibing <[email protected]>
---
arch/powerpc/platforms/pseries/ras.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
index c97d153..744604d 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -285,7 +285,7 @@ static void rtas_parse_epow_errlog(struct rtas_error_log *log)
break;

case EPOW_SYSTEM_SHUTDOWN:
- handle_system_shutdown(epow_log->event_modifier);
+ handle_system_shutdown(event_modifier);
break;

case EPOW_SYSTEM_HALT:
--
2.7.0

2019-04-24 01:40:47

by Russell Currey

Subject: Re: [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()

On Tue, 2019-04-23 at 22:35 +0800, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> rtas_parse_epow_errlog() should pass 'modifier' to
> handle_system_shutdown, because event modifier only use
> bottom 4 bits.
>
> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW
> interrupts")
> Signed-off-by: YueHaibing <[email protected]>

Hello,

This fails to compile.

arch/powerpc/platforms/pseries/ras.c: In function
'rtas_parse_epow_errlog':
arch/powerpc/platforms/pseries/ras.c:288:26: error: 'event_modifier'
undeclared (first use in this function); did you mean 'modifier'?
handle_system_shutdown(event_modifier);
^~~~~~~~~~~~~~
modifier

So yes, I assume you meant "modifier" instead of "event_modifier" as
mentioned in your commit message. Did you compile this before sending?

(found by snowpatch)

- Russell

2019-04-24 01:49:41

by Yue Haibing

Subject: Re: [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()

On 2019/4/24 9:29, Russell Currey wrote:
> On Tue, 2019-04-23 at 22:35 +0800, Yue Haibing wrote:
>> From: YueHaibing <[email protected]>
>>
>> rtas_parse_epow_errlog() should pass 'modifier' to
>> handle_system_shutdown, because event modifier only use
>> bottom 4 bits.
>>
>> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW
>> interrupts")
>> Signed-off-by: YueHaibing <[email protected]>
>
> Hello,
>
> This fails to compile.
>
> arch/powerpc/platforms/pseries/ras.c: In function
> 'rtas_parse_epow_errlog':
> arch/powerpc/platforms/pseries/ras.c:288:26: error: 'event_modifier'
> undeclared (first use in this function); did you mean 'modifier'?
> handle_system_shutdown(event_modifier);
> ^~~~~~~~~~~~~~
> modifier

Yes, this should be 'modifier'

>
> So yes, I assume you meant "modifier" instead of "event_modifier" as
> mentioned in your commit message. Did you compile this before sending?

I am very sorry for this, this is not my compiled version,
I forgot to check again before sending.

>
> (found by snowpatch)
>
> - Russell
>
>
> .
>

2019-04-24 02:24:01

by Yue Haibing

Subject: [PATCH v2] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()

From: YueHaibing <[email protected]>

rtas_parse_epow_errlog() should pass 'modifier' to
handle_system_shutdown, because event modifier only use
bottom 4 bits.

Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
Signed-off-by: YueHaibing <[email protected]>
---
v2: fix compile issue by 'event_modifier'-->'modifier'
---
arch/powerpc/platforms/pseries/ras.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
index c97d153..744604d 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -285,7 +285,7 @@ static void rtas_parse_epow_errlog(struct rtas_error_log *log)
break;

case EPOW_SYSTEM_SHUTDOWN:
- handle_system_shutdown(epow_log->event_modifier);
+ handle_system_shutdown(modifier);
break;

case EPOW_SYSTEM_HALT:
--
2.7.0

2019-04-25 23:09:46

by Tyrel Datwyler

Subject: Re: [PATCH v2] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()

On 04/23/2019 07:17 PM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> rtas_parse_epow_errlog() should pass 'modifier' to
> handle_system_shutdown, because event modifier only use
> bottom 4 bits.
>
> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
> Signed-off-by: YueHaibing <[email protected]>
> ---

Reviewed-by: Tyrel Datwyler <[email protected]>

> v2: fix compile issue by 'event_modifier'-->'modifier'
> ---
> arch/powerpc/platforms/pseries/ras.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
> index c97d153..744604d 100644
> --- a/arch/powerpc/platforms/pseries/ras.c
> +++ b/arch/powerpc/platforms/pseries/ras.c
> @@ -285,7 +285,7 @@ static void rtas_parse_epow_errlog(struct rtas_error_log *log)
> break;
>
> case EPOW_SYSTEM_SHUTDOWN:
> - handle_system_shutdown(epow_log->event_modifier);
> + handle_system_shutdown(modifier);
> break;
>
> case EPOW_SYSTEM_HALT:
>

2019-05-30 15:03:53

by Yue Haibing

Subject: Re: [PATCH v2] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()

Hi all,

Friendly ping:

Who can take this?

On 2019/4/24 10:17, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> rtas_parse_epow_errlog() should pass 'modifier' to
> handle_system_shutdown, because event modifier only use
> bottom 4 bits.
>
> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> v2: fix compile issue by 'event_modifier'-->'modifier'
> ---
> arch/powerpc/platforms/pseries/ras.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
> index c97d153..744604d 100644
> --- a/arch/powerpc/platforms/pseries/ras.c
> +++ b/arch/powerpc/platforms/pseries/ras.c
> @@ -285,7 +285,7 @@ static void rtas_parse_epow_errlog(struct rtas_error_log *log)
> break;
>
> case EPOW_SYSTEM_SHUTDOWN:
> - handle_system_shutdown(epow_log->event_modifier);
> + handle_system_shutdown(modifier);
> break;
>
> case EPOW_SYSTEM_HALT:
>