2008-08-05 09:26:30

by Gui, Jianfeng/归 剑峰

[permalink] [raw]
Subject: [PATCH 1/3] Add (struct sock*) sk parameter for send_ack()

Add (struct sock*) sk parameter for send_ack.

Signed-off-by: Gui Jianfeng <[email protected]>
---
include/net/request_sock.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/net/request_sock.h b/include/net/request_sock.h
index 8d6e991..cac811e 100644
--- a/include/net/request_sock.h
+++ b/include/net/request_sock.h
@@ -33,7 +33,7 @@ struct request_sock_ops {
struct kmem_cache *slab;
int (*rtx_syn_ack)(struct sock *sk,
struct request_sock *req);
- void (*send_ack)(struct sk_buff *skb,
+ void (*send_ack)(struct sock *sk, struct sk_buff *skb,
struct request_sock *req);
void (*send_reset)(struct sock *sk,
struct sk_buff *skb);
--
1.5.3






2008-08-07 03:23:43

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 1/3] Add (struct sock*) sk parameter for send_ack()

From: Gui Jianfeng <[email protected]>
Date: Tue, 05 Aug 2008 17:22:38 +0800

> Add (struct sock*) sk parameter for send_ack.
>
> Signed-off-by: Gui Jianfeng <[email protected]>

This patch by itself breaks the build.

Don't submit patches this way. Every patch applied should
still leave the tree building.

Also, since your OOPS and detailed description only exists
in the "0/3" email, it won't make it into the commit log
history where it belongs.

Considering all of this, I'd say you should fix this as
one big patch with a really nice commit log message.

Thanks.

2008-08-07 04:47:50

by Gui, Jianfeng/归 剑峰

[permalink] [raw]
Subject: Re: [PATCH 1/3] Add (struct sock*) sk parameter for send_ack()

David Miller wrote:
> Considering all of this, I'd say you should fix this as
> one big patch with a really nice commit log message.
>

OK, I'll repost it later.

--
Regards
Gui Jianfeng