2008-08-01 04:23:22

by Mark M. Hoffman

[permalink] [raw]
Subject: [GIT PATCH] hwmon updates against v2.6.26

Hi Linus:

Please pull from:
git://lm-sensors.org/kernel/mhoffman/hwmon-2.6.git release

You'll get what few patches I've managed to look at in the last few months,
including a patch to MAINTAINERS which makes it official. I'm sorry I was
not able to keep up - I should have admitted defeat much sooner.

To all lm-sensors/hwmon developers: please resend/CC patches to Andrew.

Thanks & regards,

Documentation/hwmon/dme1737 | 4
Documentation/hwmon/lm85 | 11
MAINTAINERS | 6
drivers/hwmon/Kconfig | 25 +
drivers/hwmon/adt7473.c | 16 -
drivers/hwmon/dme1737.c | 297 ++++++++++++-------
drivers/hwmon/lm75.c | 282 +++++++++++++-----
drivers/hwmon/lm85.c | 672 ++++++++++++++++++--------------------------
8 files changed, 692 insertions(+), 621 deletions(-)

David Brownell (2):
hwmon: (lm75) cleanup/reorg
hwmon: (lm75) add new-style driver binding

Jean Delvare (6):
hwmon: (adt7473) Remove unused defines
hwmon: (lm85) Coding-style cleanups
hwmon: (lm85) Drop dead code
hwmon: (lm85) Don't write back cached values
hwmon: (lm85) Misc cleanups
hwmon: (lm85) Simplify device initialization function

Juerg Haefliger (3):
hwmon: (dme1737) demacrofy for readability
hwmon: (dme1737) probe all addresses
hwmon: (dme1737) fix voltage scaling

Mark M. Hoffman (2):
hwmon: (adt7473) clarify an awkward bit of code
hwmon: needs new maintainer

--
Mark M. Hoffman
[email protected]


2008-08-01 04:32:59

by Andrew Morton

[permalink] [raw]
Subject: Re: [GIT PATCH] hwmon updates against v2.6.26

On Fri, 1 Aug 2008 00:10:27 -0400 "Mark M. Hoffman" <[email protected]> wrote:

> Hi Linus:
>
> Please pull from:
> git://lm-sensors.org/kernel/mhoffman/hwmon-2.6.git release

ack.

> You'll get what few patches I've managed to look at in the last few months,
> including a patch to MAINTAINERS which makes it official. I'm sorry I was
> not able to keep up - I should have admitted defeat much sooner.

Thanks for all the work. There are many subsystems for which the
maintainer is, err, me.

> To all lm-sensors/hwmon developers: please resend/CC patches to Andrew.

Yup. I'll subscribe to those lists and shall do the occasional
troll-for-missed-stuff there.

You'll also find that I'll still cc yourself on everything (including
patches) so please do keep an eye out for goofups.

> MAINTAINERS | 6

HARDWARE MONITORING
-P: Mark M. Hoffman
-M: [email protected]
L: [email protected]
W: http://www.lm-sensors.org/
-T: git lm-sensors.org:/kernel/mhoffman/hwmon-2.6.git testing
-T: git lm-sensors.org:/kernel/mhoffman/hwmon-2.6.git release
-S: Maintained
+S: Orphaned

2008-08-06 08:39:49

by Jean Delvare

[permalink] [raw]
Subject: Re: [GIT PATCH] hwmon updates against v2.6.26

Hi Mark, Andrew,

On Fri, 1 Aug 2008 00:10:27 -0400, Mark M. Hoffman wrote:
> Hi Linus:
>
> Please pull from:
> git://lm-sensors.org/kernel/mhoffman/hwmon-2.6.git release
>
> You'll get what few patches I've managed to look at in the last few months,
> including a patch to MAINTAINERS which makes it official. I'm sorry I was
> not able to keep up - I should have admitted defeat much sooner.

I'm sad to see you go (and can only hope that you won't leave the
project entirely). But I would also like to thank you for the good work
you've done. Even if it was short, everything you did is done and
that's something you can be proud of. Especially given the conditions
in which you started in this new role - please forgive me for that.

> To all lm-sensors/hwmon developers: please resend/CC patches to Andrew.

I have a number of hwmon patches in my local kernel tree which I wrote
and that have been reviewed by a trusted developer, or that have been
posted to the lm-sensors list and that I have reviewed. I consider
these ready to go upstream. I plan to gather these into a public tree
and push them to Linus today or tomorrow. In the future, I will
probably have such a tree available to be included in linux-next.

Don't get me wrong, I am _not_ volunteering to become the new hwmon
subsystem maintainer. Remember, I've been there before and you know how
it ended. But in the absence of a subsystem maintainer, I don't want
hwmon patches to be lost (and especially not mine) and I don't think
that pushing everything to Andrew is a good solution either. So I'm
just proposing to do my part of the work. But if Andrew really prefers
to pick all the patches, I am not insisting either.

In the future, I would like to suggest to have 2 hwmon subsystem
maintainers instead of 1. Apparently none of us has the time to do all
the work, but maybe some of us would have the time to do half of it.
This is the path I took for the i2c subsystem, and while the change is
still fairly recent, it seems to be working well enough.

--
Jean Delvare

2008-08-06 08:57:25

by Hans de Goede

[permalink] [raw]
Subject: Re: [lm-sensors] [GIT PATCH] hwmon updates against v2.6.26

Jean Delvare wrote:
> Hi Mark, Andrew,
>
> On Fri, 1 Aug 2008 00:10:27 -0400, Mark M. Hoffman wrote:
>> Hi Linus:
>>
>> Please pull from:
>> git://lm-sensors.org/kernel/mhoffman/hwmon-2.6.git release
>>
>> You'll get what few patches I've managed to look at in the last few months,
>> including a patch to MAINTAINERS which makes it official. I'm sorry I was
>> not able to keep up - I should have admitted defeat much sooner.
>
> I'm sad to see you go (and can only hope that you won't leave the
> project entirely). But I would also like to thank you for the good work
> you've done. Even if it was short, everything you did is done and
> that's something you can be proud of. Especially given the conditions
> in which you started in this new role - please forgive me for that.
>

All I can see really is +1, sad to see you go and thanks for all the work done!

>> To all lm-sensors/hwmon developers: please resend/CC patches to Andrew.
>
> I have a number of hwmon patches in my local kernel tree which I wrote
> and that have been reviewed by a trusted developer, or that have been
> posted to the lm-sensors list and that I have reviewed. I consider
> these ready to go upstream. I plan to gather these into a public tree
> and push them to Linus today or tomorrow. In the future, I will
> probably have such a tree available to be included in linux-next.
>

I too don't want to see any patches get dropped, so I'll try to step up a
little with regards to reviewing hwmon patches, I would be grateful if you
could incorporate any patches Acked by me in said tree. Esp since my git-fu
isn't all that good.

> Don't get me wrong, I am _not_ volunteering to become the new hwmon
> subsystem maintainer.

Don't get me wrong either, I will try to step up my reviewing but I am _not_
volunteering to become the new hwmon subsystem maintainer either. I'm just
starting a new job and with that combined with that I'm doing a lot of v4l work
lately, I simply don't have the time for this.

> In the future, I would like to suggest to have 2 hwmon subsystem
> maintainers instead of 1. Apparently none of us has the time to do all
> the work, but maybe some of us would have the time to do half of it.
> This is the path I took for the i2c subsystem, and while the change is
> still fairly recent, it seems to be working well enough.
>

+1


Regards,

Hans

2008-08-06 09:41:42

by Jean Delvare

[permalink] [raw]
Subject: Re: [GIT PATCH] hwmon updates against v2.6.26

On Wed, 06 Aug 2008 10:59:16 +0200, Hans de Goede wrote:
> Jean Delvare wrote:
> > I have a number of hwmon patches in my local kernel tree which I wrote
> > and that have been reviewed by a trusted developer, or that have been
> > posted to the lm-sensors list and that I have reviewed. I consider
> > these ready to go upstream. I plan to gather these into a public tree
> > and push them to Linus today or tomorrow. In the future, I will
> > probably have such a tree available to be included in linux-next.
>
> I too don't want to see any patches get dropped, so I'll try to step up a
> little with regards to reviewing hwmon patches, I would be grateful if you
> could incorporate any patches Acked by me in said tree. Esp since my git-fu
> isn't all that good.

Will do. Note that I'm really using quilt, not git, to push patches to
linux-next. I only use git to push patches to Linus once in a while.

--
Jean Delvare

2008-08-06 12:04:30

by Jean Delvare

[permalink] [raw]
Subject: Re: [GIT PATCH] hwmon updates against v2.6.26

On Wed, 6 Aug 2008 10:39:03 +0200, Jean Delvare wrote:
> I have a number of hwmon patches in my local kernel tree which I wrote
> and that have been reviewed by a trusted developer, or that have been
> posted to the lm-sensors list and that I have reviewed. I consider
> these ready to go upstream. I plan to gather these into a public tree
> and push them to Linus today or tomorrow. In the future, I will
> probably have such a tree available to be included in linux-next.

The patches in question are here if anyone wants to take a look:
http://khali.linux-fr.org/devel/linux-2.6/jdelvare-hwmon/

I'll make a git branch out of them by the end of the day, for Linus to
pull from.

--
Jean Delvare

2008-08-06 15:54:43

by Andrew Morton

[permalink] [raw]
Subject: Re: [GIT PATCH] hwmon updates against v2.6.26

On Wed, 6 Aug 2008 10:39:03 +0200 Jean Delvare <[email protected]> wrote:

> Hi Mark, Andrew,
>
> On Fri, 1 Aug 2008 00:10:27 -0400, Mark M. Hoffman wrote:
> > Hi Linus:
> >
> > Please pull from:
> > git://lm-sensors.org/kernel/mhoffman/hwmon-2.6.git release
> >
> > You'll get what few patches I've managed to look at in the last few months,
> > including a patch to MAINTAINERS which makes it official. I'm sorry I was
> > not able to keep up - I should have admitted defeat much sooner.
>
> I'm sad to see you go (and can only hope that you won't leave the
> project entirely). But I would also like to thank you for the good work
> you've done. Even if it was short, everything you did is done and
> that's something you can be proud of.

yup.

> I have a number of hwmon patches in my local kernel tree which I wrote
> and that have been reviewed by a trusted developer, or that have been
> posted to the lm-sensors list and that I have reviewed. I consider
> these ready to go upstream. I plan to gather these into a public tree
> and push them to Linus today or tomorrow. In the future, I will
> probably have such a tree available to be included in linux-next.
>
> Don't get me wrong, I am _not_ volunteering to become the new hwmon
> subsystem maintainer. Remember, I've been there before and you know how
> it ended. But in the absence of a subsystem maintainer, I don't want
> hwmon patches to be lost (and especially not mine) and I don't think
> that pushing everything to Andrew is a good solution either. So I'm
> just proposing to do my part of the work. But if Andrew really prefers
> to pick all the patches, I am not insisting either.

That would be great, thanks.

But it does mean that I'd prefer that any hwmon patches which I pick up
are merged via that tree if that's OK. Which all does end up making
you look awfully like an hwmon maintainer..

> In the future, I would like to suggest to have 2 hwmon subsystem
> maintainers instead of 1. Apparently none of us has the time to do all
> the work, but maybe some of us would have the time to do half of it.
> This is the path I took for the i2c subsystem, and while the change is
> still fairly recent, it seems to be working well enough.

Sure. Having additional people reviewing, testing and generally caring
for changes has practically zero downside.

2008-08-06 18:03:24

by Jean Delvare

[permalink] [raw]
Subject: Re: [GIT PATCH] hwmon updates against v2.6.26

Hi Andrew,

On Wed, 6 Aug 2008 08:53:24 -0700, Andrew Morton wrote:
> On Wed, 6 Aug 2008 10:39:03 +0200 Jean Delvare <[email protected]> wrote:
> > I have a number of hwmon patches in my local kernel tree which I wrote
> > and that have been reviewed by a trusted developer, or that have been
> > posted to the lm-sensors list and that I have reviewed. I consider
> > these ready to go upstream. I plan to gather these into a public tree
> > and push them to Linus today or tomorrow. In the future, I will
> > probably have such a tree available to be included in linux-next.
> >
> > Don't get me wrong, I am _not_ volunteering to become the new hwmon
> > subsystem maintainer. Remember, I've been there before and you know how
> > it ended. But in the absence of a subsystem maintainer, I don't want
> > hwmon patches to be lost (and especially not mine) and I don't think
> > that pushing everything to Andrew is a good solution either. So I'm
> > just proposing to do my part of the work. But if Andrew really prefers
> > to pick all the patches, I am not insisting either.
>
> That would be great, thanks.
>
> But it does mean that I'd prefer that any hwmon patches which I pick up
> are merged via that tree if that's OK. Which all does end up making
> you look awfully like an hwmon maintainer..

No, that's not OK, sorry. This goes beyond what I can offer at this
point in time.

I offered to push selected patches to Linus, with no other guarantee
than the fact that said patches have been carefully reviewed and are
believed to be correct. I do not have the time to do more than that.

If this isn't OK with you, then I will have to withdraw my proposal.
It's up to you.

--
Jean Delvare

2008-08-06 20:44:40

by Andrew Morton

[permalink] [raw]
Subject: Re: [GIT PATCH] hwmon updates against v2.6.26

On Wed, 6 Aug 2008 20:03:01 +0200
Jean Delvare <[email protected]> wrote:

> Hi Andrew,
>
> On Wed, 6 Aug 2008 08:53:24 -0700, Andrew Morton wrote:
> > On Wed, 6 Aug 2008 10:39:03 +0200 Jean Delvare <[email protected]> wrote:
> > > I have a number of hwmon patches in my local kernel tree which I wrote
> > > and that have been reviewed by a trusted developer, or that have been
> > > posted to the lm-sensors list and that I have reviewed. I consider
> > > these ready to go upstream. I plan to gather these into a public tree
> > > and push them to Linus today or tomorrow. In the future, I will
> > > probably have such a tree available to be included in linux-next.
> > >
> > > Don't get me wrong, I am _not_ volunteering to become the new hwmon
> > > subsystem maintainer. Remember, I've been there before and you know how
> > > it ended. But in the absence of a subsystem maintainer, I don't want
> > > hwmon patches to be lost (and especially not mine) and I don't think
> > > that pushing everything to Andrew is a good solution either. So I'm
> > > just proposing to do my part of the work. But if Andrew really prefers
> > > to pick all the patches, I am not insisting either.
> >
> > That would be great, thanks.
> >
> > But it does mean that I'd prefer that any hwmon patches which I pick up
> > are merged via that tree if that's OK. Which all does end up making
> > you look awfully like an hwmon maintainer..
>
> No, that's not OK, sorry. This goes beyond what I can offer at this
> point in time.
>
> I offered to push selected patches to Linus, with no other guarantee
> than the fact that said patches have been carefully reviewed and are
> believed to be correct. I do not have the time to do more than that.
>
> If this isn't OK with you, then I will have to withdraw my proposal.
> It's up to you.

<rereads>

Ah, I see, this tree is only things-which-Jean-wrote. No probs here.

2008-08-06 21:09:50

by Jean Delvare

[permalink] [raw]
Subject: Re: [GIT PATCH] hwmon updates against v2.6.26

On Wed, 6 Aug 2008 13:43:14 -0700, Andrew Morton wrote:
> On Wed, 6 Aug 2008 20:03:01 +0200
> Jean Delvare <[email protected]> wrote:
>
> > Hi Andrew,
> >
> > On Wed, 6 Aug 2008 08:53:24 -0700, Andrew Morton wrote:
> > > On Wed, 6 Aug 2008 10:39:03 +0200 Jean Delvare <[email protected]> wrote:
> > > > I have a number of hwmon patches in my local kernel tree which I wrote
> > > > and that have been reviewed by a trusted developer, or that have been
> > > > posted to the lm-sensors list and that I have reviewed. I consider
> > > > these ready to go upstream. I plan to gather these into a public tree
> > > > and push them to Linus today or tomorrow. In the future, I will
> > > > probably have such a tree available to be included in linux-next.
> > > >
> > > > Don't get me wrong, I am _not_ volunteering to become the new hwmon
> > > > subsystem maintainer. Remember, I've been there before and you know how
> > > > it ended. But in the absence of a subsystem maintainer, I don't want
> > > > hwmon patches to be lost (and especially not mine) and I don't think
> > > > that pushing everything to Andrew is a good solution either. So I'm
> > > > just proposing to do my part of the work. But if Andrew really prefers
> > > > to pick all the patches, I am not insisting either.
> > >
> > > That would be great, thanks.
> > >
> > > But it does mean that I'd prefer that any hwmon patches which I pick up
> > > are merged via that tree if that's OK. Which all does end up making
> > > you look awfully like an hwmon maintainer..
> >
> > No, that's not OK, sorry. This goes beyond what I can offer at this
> > point in time.
> >
> > I offered to push selected patches to Linus, with no other guarantee
> > than the fact that said patches have been carefully reviewed and are
> > believed to be correct. I do not have the time to do more than that.
> >
> > If this isn't OK with you, then I will have to withdraw my proposal.
> > It's up to you.
>
> <rereads>
>
> Ah, I see, this tree is only things-which-Jean-wrote. No probs here.

Things that I wrote or reviewed, yes. Put in short, things I am already
involved in, so there is no extra cost for me to push them to Linus.

--
Jean Delvare