2009-04-18 00:58:48

by dougthompson

[permalink] [raw]
Subject: [PATCH 1/1] edac: ppc mpc85xx fix mc err detect

From: Dave Jiang <[email protected]>

Error found by Jeff Haran <[email protected]>

The error detect register is 0s when no errors are detected.
The check code is incorrect, so reverse check sense.

Cc: Jeff Haran <[email protected]>
Signed-off-by: Dave Jiang <[email protected]>
Signed-off-by: Doug Thompson <[email protected]>

---
commit 1d8cad7d0ecbe9fad3c70b959804e6c6632e236c
tree ed8e099c0c0b775b1c11b94dfc794491a915e144
parent b0cbc861a3c05e634520b049b5cc27ad6febb51f
author Dave Jiang <[email protected]> Mon, 13 Apr 2009 10:16:53 -0700
committer Dave Jiang <[email protected]> Mon, 13 Apr 2009 10:16:53 -0700

drivers/edac/mpc85xx_edac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index 4637a4a..7c8c2d7 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -674,7 +674,7 @@ static void mpc85xx_mc_check(struct mem_ctl_info *mci)
int row_index;

err_detect = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT);
- if (err_detect)
+ if (!err_detect)
return;

mpc85xx_mc_printk(mci, KERN_ERR, "Err Detect Register: %#8.8x\n",