2021-10-19 10:32:02

by Jiapeng Chong

Subject: [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static

From: chongjiapeng <[email protected]>

This symbol is not used outside of mpt3sas_ctl.c, so marks it static.

Fixes the following sparse warning:

drivers/scsi/mpt3sas/mpt3sas_ctl.c:3988:18: warning: symbol
'mpt3sas_dev_attrs' was not declared. Should it be static?

Reported-by: Abaci Robot <[email protected]>
Fixes: 1bb3ca27d2ca ("scsi: mpt3sas: Switch to attribute groups")
Signed-off-by: chongjiapeng <[email protected]>
---
drivers/scsi/mpt3sas/mpt3sas_ctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
index 0aabc9761be1..05b6c6a073c3 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
@@ -3985,7 +3985,7 @@ sas_ncq_prio_enable_store(struct device *dev,
}
static DEVICE_ATTR_RW(sas_ncq_prio_enable);

-struct attribute *mpt3sas_dev_attrs[] = {
+static struct attribute *mpt3sas_dev_attrs[] = {
&dev_attr_sas_address.attr,
&dev_attr_sas_device_handle.attr,
&dev_attr_sas_ncq_prio_supported.attr,
--
2.19.1.6.gb485710b

2021-10-19 16:39:00

by Bart Van Assche

Subject: Re: [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static

On 10/19/21 3:27 AM, Jiapeng Chong wrote:
> From: chongjiapeng <[email protected]>
>
> This symbol is not used outside of mpt3sas_ctl.c, so marks it static.
>
> Fixes the following sparse warning:
>
> drivers/scsi/mpt3sas/mpt3sas_ctl.c:3988:18: warning: symbol
> 'mpt3sas_dev_attrs' was not declared. Should it be static?
>
> Reported-by: Abaci Robot <[email protected]>
> Fixes: 1bb3ca27d2ca ("scsi: mpt3sas: Switch to attribute groups")
> Signed-off-by: chongjiapeng <[email protected]>
> ---
> drivers/scsi/mpt3sas/mpt3sas_ctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> index 0aabc9761be1..05b6c6a073c3 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> @@ -3985,7 +3985,7 @@ sas_ncq_prio_enable_store(struct device *dev,
> }
> static DEVICE_ATTR_RW(sas_ncq_prio_enable);
>
> -struct attribute *mpt3sas_dev_attrs[] = {
> +static struct attribute *mpt3sas_dev_attrs[] = {
> &dev_attr_sas_address.attr,
> &dev_attr_sas_device_handle.attr,
> &dev_attr_sas_ncq_prio_supported.attr,
>

Reviewed-by: Bart Van Assche <[email protected]>

2021-10-20 02:00:48

by Himanshu Madhani

Subject: Re: [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static

> On Oct 19, 2021, at 5:27 AM, Jiapeng Chong <[email protected]> wrote:
>
> From: chongjiapeng <[email protected]>
>
> This symbol is not used outside of mpt3sas_ctl.c, so marks it static.
>
> Fixes the following sparse warning:
>
> drivers/scsi/mpt3sas/mpt3sas_ctl.c:3988:18: warning: symbol
> 'mpt3sas_dev_attrs' was not declared. Should it be static?
>
> Reported-by: Abaci Robot <[email protected]>
> Fixes: 1bb3ca27d2ca ("scsi: mpt3sas: Switch to attribute groups")
> Signed-off-by: chongjiapeng <[email protected]>
> ---
> drivers/scsi/mpt3sas/mpt3sas_ctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> index 0aabc9761be1..05b6c6a073c3 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> @@ -3985,7 +3985,7 @@ sas_ncq_prio_enable_store(struct device *dev,
> }
> static DEVICE_ATTR_RW(sas_ncq_prio_enable);
>
> -struct attribute *mpt3sas_dev_attrs[] = {
> +static struct attribute *mpt3sas_dev_attrs[] = {
> &dev_attr_sas_address.attr,
> &dev_attr_sas_device_handle.attr,
> &dev_attr_sas_ncq_prio_supported.attr,
> --
> 2.19.1.6.gb485710b
>

Reviewed-by: Himanshu Madhani <[email protected]>

--
Himanshu Madhani Oracle Linux Engineering

2021-10-21 03:08:11

by Martin K. Petersen

Subject: Re: [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static

Jiapeng,

> This symbol is not used outside of mpt3sas_ctl.c, so marks it static.

Applied to 5.16/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2021-10-27 16:59:06

by Martin K. Petersen

Subject: Re: [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static

On Tue, 19 Oct 2021 18:27:19 +0800, Jiapeng Chong wrote:

> From: chongjiapeng <[email protected]>
>
> This symbol is not used outside of mpt3sas_ctl.c, so marks it static.
>
> Fixes the following sparse warning:
>
> drivers/scsi/mpt3sas/mpt3sas_ctl.c:3988:18: warning: symbol
> 'mpt3sas_dev_attrs' was not declared. Should it be static?
>
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: mpt3sas: make mpt3sas_dev_attrs static
https://git.kernel.org/mkp/scsi/c/0ae8f4785107

--
Martin K. Petersen Oracle Linux Engineering