2009-12-26 00:46:15

by Stefan Richter

Subject: [PATCH v4l/dvb] firedtv: add forgotten __exit annotation

fdtv_fw_exit() is part of the firedtv driver's .exit.text section.

Signed-off-by: Stefan Richter <[email protected]>
---
drivers/media/dvb/firewire/firedtv-fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
===================================================================
--- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c
+++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
@@ -332,7 +332,7 @@ int __init fdtv_fw_init(void)
return driver_register(&fdtv_driver.driver);
}

-void fdtv_fw_exit(void)
+void __exit fdtv_fw_exit(void)
{
driver_unregister(&fdtv_driver.driver);
fw_core_remove_address_handler(&fcp_handler);

--
Stefan Richter
-=====-==--= ==-- ==-=-
http://arcgraph.de/sr/

2010-01-10 15:12:44

by Stefan Richter

Subject: Re: [PATCH v4l/dvb] firedtv: add forgotten __exit annotation

Stefan Richter wrote on 2009-12-26:
> fdtv_fw_exit() is part of the firedtv driver's .exit.text section.
...
> --- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c
> +++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
> @@ -332,7 +332,7 @@ int __init fdtv_fw_init(void)
> return driver_register(&fdtv_driver.driver);
> }
>
> -void fdtv_fw_exit(void)
> +void __exit fdtv_fw_exit(void)
> {
> driver_unregister(&fdtv_driver.driver);
> fw_core_remove_address_handler(&fcp_handler);
>

This patch is bogus. fdtv_fw_exit() is also called from firedtv's init.
--
Stefan Richter
-=====-==-=- ---= -=-=-
http://arcgraph.de/sr/