2010-02-11 00:43:25

by Andrew Morton

[permalink] [raw]
Subject: mmotm 2010-02-10-16-17 uploaded

The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to

http://userweb.kernel.org/~akpm/mmotm/

and will soon be available at

git://zen-kernel.org/kernel/mmotm.git

It contains the following patches against 2.6.33-rc7:

origin.patch
tpm_infineon-fix-suspend-resume-handler-for-pnp_driver-2.patch
mmc_test-block-addressed-cards.patch
edac-mpc85xx-fix-bad-page-calculation.patch
edac-mpc85xx-fix-build-regression-by-removing-unused-debug-code.patch
mmc-fix-hang-if-card-was-removed-during-suspend-and-unsafe-resume-was-enabled.patch
maintainers-changed-ltp-maintainership-responsibilities.patch
compat_ioctl-add-compat-handler-for-tiocgsid-ioctl.patch
fs-execc-restrict-initial-stack-space-expansion-to-rlimit.patch
linux-next.patch
linux-next-git-rejects.patch
next-remove-localversion.patch
i-need-old-gcc.patch
hardware-latency-detector-remove-default-m.patch
revert-input-wistron_btns-switch-to-using-sparse-keymap-library.patch
drivers-media-video-cx23885-needs-kfifo-conversion.patch
fs-buffer_head-remove-kmem_cache-constructor-to-reduce-memory-usage-under-slub.patch
mm-add-swap-slot-free-callback-to-block_device_operations.patch
mm-add-swap-slot-free-callback-to-block_device_operations-fix.patch
bitops-rename-for_each_bit-to-for_each_set_bit.patch
bitops-rename-for_each_bit-to-for_each_set_bit-fix-fix-2.patch
infiniband-use-for_each_set_bit.patch
drivers-acpi-processor_idlec-add-two-laptops-to-the-c-state-dmi-table.patch
thinkpad-acpi-wrong-thermal-attribute_group-removed-in-thermal_exit.patch
driver-core-fix-race-condition-in-get_device_parent.patch
drivers-gpu-vga-vgaarbc-fix-userspace-pointer-dereference.patch
leds-gpio-fix-default-state-handling-on-of-platforms.patch
drivers-scsi-sesc-eliminate-double-free.patch
geode-mfgpt-restore-previous-behavior-for-selecting-irq.patch
x86-agp-fix-agp_amd64_init-module-initialization-regression.patch
dell_laptop-when-the-hardware-switch-is-disabled-dont-actually-allow-changing-the-softblock-status.patch
acpi-fix-confusion-in-acpi_evaluate_string-in-comment.patch
acpi-remove-superfluous-null-pointer-check-from-acpi_processor_get_throttling_info.patch
acpica-fix-acpi_ex_release_mutex-comment.patch
asus-acpi-remove-duplicate-comparison-of-asus_model-strings.patch
pci-update-pci_set_vga_state-to-call-arch-functions.patch
x86_64-uv-update-uv-arch-to-target-legacy-vga-i-o-correctly.patch
x86-move-hp-wmis-probe-function-to-devinittext.patch
agp-amd64-fix-pci-reference-leaks.patch
arm-convert-proc-cpu-aligment-to-seq_file.patch
arch-arm-plat-pxa-dmac-correct-null-test.patch
gemini-wrong-registers-used-to-set-reg_level-in-gpio_set_irq_type.patch
arch-arm-include-asm-elfh-forward-declare-the-task-struct.patch
platform-drivers-move-probe-to-devinittext-in-arch-arm.patch
cpufreq-ondemand-dont-synchronize-sample-rate-unless-mulitple-cpus-present.patch
drivers-pcmcia-yenta_socketc-ene-cb712-cardbus-bridge-needs-special-treatment-with-echo-audio-indigo-soundcards.patch
powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned.patch
msi-laptop-depends-on-rfkill.patch
vgaarb-fix-vga-arbiter-to-accept-pci-domains-other-than-0.patch
vgaarb-add-user-selectability-of-the-number-of-gpus-in-a-system.patch
drivers-gpu-drm-nouveau-nouveau_grctxc-correct-null-test.patch
gpu-drm-i915-fix-potential-null-dereference.patch
drm-dont-use-own-implementation-of-atoi.patch
drivers-gpu-drm-i915-intel_biosc-fix-continuation-line-formats.patch
drivers-media-video-move-dereference-after-null-test.patch
media-move-omap24xxcams-probe-function-to-devinittext.patch
v4l-dvb-gspca-sn9c20x-correct-onstack-wait_queue_head-declaration.patch
drivers-staging-tm6000-tm6000-videoc-correct-null-test.patch
dib3000mc-reduce-large-stack-usage.patch
dib7000p-reduce-large-stack-usage.patch
drivers-media-video-kconfig-add-video_dev-dependency-as-needed-in-drivers-media-video-kconfig.patch
fs-fscache-object-listc-fix-warning-on-32-bit.patch
hpet-use-for_each_set_bit.patch
i2c-move-i2c_omaps-probe-function-to-devinittext.patch
i2c-fix-xiic-build-error.patch
intel-iommu-use-for_each_set_bit.patch
timer-stats-fix-del_timer_sync-and-try_to_del_timer_sync.patch
posix-cpu-timers-reset-expire-cache-when-no-timer-is-running.patch
hrtimer-correct-a-few-numbers-in-comments.patch
clockevents-ensure-taht-min_delta_ns-is-increased-in-error-path.patch
clocksource-add-argument-to-resume-callback.patch
clocksource-start-cmt-at-clocksource-resume.patch
clocksource-add-suspend-callback.patch
posix-timersc-dont-export-local-functions.patch
timers-introduce-the-concept-of-timer-slack-for-legacy-timers.patch
cpu-timers-simplify-rlimit_cpu-handling.patch
cpu-timers-cleanup-arm_timer.patch
cpu-timers-return-correct-previous-timer-reload-value.patch
cpu-timers-change-sigev_none-timer-implementation.patch
cpu-timers-assure-to-not-iterate-over-all-threads-in-fastpath_timer_check.patch
cpu-timers-optimize-run_posix_cpu_timers.patch
cs5535-clockevt-free-timer-in-irq-setup-error-path.patch
ia64-wrong-attribute-of-hub-chip-written-in-uv_setup.patch
arch-ia64-fix-continuation-line-formats.patch
infiniband-use-rlimit-helpers.patch
input-bcm5974-retract-efi-broken-suspend_resume.patch
mtd-nand-fix-build-failure-caused-by-typo.patch
jffs2-avoid-using-c-keyword-new-in-userspace-visible-header.patch
mtd-chips-cfi-remove-unneeded-null-checks.patch
mtd-hot-spin-and-code-duplication-in-nand_bcm_umi_bch_read_oobecc.patch
mtd-change-positive-error-return-into-negative-in-mtd_do_writeoob.patch
ntfs-use-bitmap_weight.patch
score-fix-dereference-of-null-pointer-in-local_flush_tlb_page.patch
phonet-use-for_each_set_bit.patch
atm-use-for_each_set_bit.patch
ll-temac-driver-add-non-virtex-5-support.patch
net-move-am79c961s-probe-function-to-devinittext.patch
obsolete-config-in-kernel-source-use_internal_timer.patch
obsolete-config-in-kernel-source-hso_autopm.patch
3x59x-fix-pci-resource-management.patch
net-ipv4-correct-the-size-argument-to-kzalloc.patch
video-backlight-progear-fix-pci-device-refcounting.patch
sunrpc-use-formatting-of-module-name-in-sunrpc.patch
net-sunrpc-remove-uses-of-nipquad-use-%pi4.patch
sunrpc-cache-fix-module-refcnt-leak-in-a-failure-path.patch
fs-ocfs2-cluster-tcpc-remove-use-of-nipquad-use-%pi4.patch
ibmphp-read-the-length-of-ebda-and-map-entire-ebda-region-fix.patch
pci-hotplug-fix-ibmphp-build-error.patch
percpu_counter-make-__percpu_counter_add-an-inline-function-on-up.patch
sched-cpuacct-use-bigger-percpu-counter-batch-values-for-stats-counters.patch
kernel-schedc-suppress-unused-var-warning.patch
core-kernel-make-sparse-work-with-inline-spinlocks-and-rwlocks.patch
kernel-irq-procc-expose-the-irq_desc-node-in-proc-irq.patch
genirq-warn-about-irqf_sharedirqf_disabled-at-the-right-place.patch
scsi-add-__init-__exit-macros-to-ibmvstgtc.patch
drivers-scsi-fnic-fnic_scsic-clean-up.patch
drivers-scsi-gdthc-fix-buffer-overflow.patch
drivers-scsi-lpfc-lpfc_vportc-fix-read-buffer-overflow.patch
osst-fix-read-buffer-overflow.patch
gdth-unmap-ccb_phys-when-scsi_add_host-fails-in-gdth_eisa_probe_one.patch
drivers-scsi-libsas-use-sam_good.patch
ncr5380-bit-mr_dma_mode-set-twice-in-ncr5380_transfer_dma.patch
drivers-scsi-remove-unnecessary-null-test.patch
drivers-message-move-dereference-after-null-test.patch
scsi-pmcraid-redundant-check-in-pmcraid_check_ioctl_buffer.patch
mpt-fusion-convert-to-seq_file.patch
g_ncr5380-remove-misleading-pnp-error-message.patch
g_ncr5380-fix-broken-mmio-compilation.patch
g_ncr5380-fix-missing-pnp_device_detach-and-scsi_unregister-on-rmmod.patch
dc395x-decrease-iteration-for-tag_number-of-max_command-in-start_scsi.patch
drivers-scsi-correct-the-size-argument-to-kmalloc.patch
scsi-remove-superfluous-null-pointer-check-from-scsi_kill_request.patch
mpt2sas-fix-confusion-in-_scsih_sas_device_status_change_event.patch
drivers-scsi-remove-uses-of-nipquad-use-%pi4.patch
drivers-firmware-iscsi_ibftc-remove-nipquad_fmt-use-%pi4.patch
drivers-scsi-hpsac-fix-section-mismatch.patch
scsi-sdc-quiet-all-sparse-noise.patch
drivers-scsi-bfa-bfad_imc-eliminate-useless-code.patch
lpfc-two-branches-the-same-in-lpfc_decode_firmware_rev.patch
lpfc-positive-error-return-into-negative.patch
qla2xxx-negative-error-return-in-qla2x00_change_queue_depth.patch
drivers-scsi-qla2xxx-qla_osc-fix-continuation-line-formats.patch
platform-drivers-move-probe-to-devinittext-in-drivers-scsi.patch
scsi-bfa-correct-onstack-wait_queue_head-declaration.patch
paride-fix-off-by-one-test.patch
vfs-improve-writeback_inodes_wb.patch
drivers-staging-fix-continuation-line-formats.patch
staging-rt2860-correct-onstack-wait_queue_head-declaration.patch
musb-test-always-evaluates-to-false.patch
vfs-fix-vfs_rename_dir-for-fs_rename_does_d_move-filesystems.patch
vfs-improve-comment-describing-fget_light.patch
ecryptfs-another-lockdep-issue.patch
vfs-o_-bit-numbers-uniqueness-check.patch
vfs-introduce-fmode_neg_offset-for-allowing-negative-f_pos.patch
xtensa-convert-to-asm-generic-hardirqh.patch
xtensa-includecheck-fix-vectorss.patch
modpost-support-objects-with-more-than-64k-sections.patch
mm.patch
define-madv_hugepage.patch
mm-clean-up-mm_counter.patch
mm-avoid-false-sharing-of-mm_counter.patch
mm-avoid-false-sharing-of-mm_counter-checkpatch-fixes.patch
mm-count-swap-usage.patch
mm-count-swap-usage-checkpatch-fixes.patch
mm-introduce-dump_page-and-print-symbolic-flag-names.patch
page-allocator-reduce-fragmentation-in-buddy-allocator-by-adding-buddies-that-are-merging-to-the-tail-of-the-free-lists.patch
mlock_vma_pages_range-never-return-negative-value.patch
mlock_vma_pages_range-only-return-success-or-failure.patch
mm-use-rlimit-helpers.patch
vmscan-check-high-watermark-after-shrink-zone.patch
vmscan-check-high-watermark-after-shrink-zone-fix.patch
vmscan-get_scan_ratio-cleanup.patch
mm-lockdep-annotate-reclaim-context-to-zone-reclaim-too.patch
mm-page_allocc-remove-duplicate-call-to-trace_mm_page_free_direct.patch
mm-page_allocc-adjust-a-call-site-to-trace_mm_page_free_direct.patch
mm-remove-function-free_hot_page.patch
mm-remove-function-free_hot_page-fix.patch
mm-restore-zone-all_unreclaimable-to-independence-word.patch
mm-restore-zone-all_unreclaimable-to-independence-word-fix.patch
mm-restore-zone-all_unreclaimable-to-independence-word-fix-2.patch
mm-fix-mbind-vma-merge-problem.patch
mm-fix-mbind-vma-merge-problem-fix.patch
memory-hotplug-create-sys-firmware-memmap-entry-for-new-memory.patch
memory-hotplug-create-sys-firmware-memmap-entry-for-new-memory-fix.patch
mm-mempolicyc-fix-indentation-of-the-comments-of-do_migrate_pages.patch
mm-migratec-kill-anon-local-variable-from-migrate_page_copy.patch
bootmem-avoid-dma32-zone-by-default.patch
vfs-take-f_lock-on-modifying-f_mode-after-open-time.patch
readahead-introduce-fmode_random-for-posix_fadv_random.patch
readahead-introduce-fmode_random-for-posix_fadv_random-fix.patch
include-linux-fsh-convert-fmode_-constants-to-hex.patch
mm-memcontrolc-fix-integer-as-null-pointer-sparse-warning.patch
mm-change-anon_vma-linking-to-fix-multi-process-server-scalability-issue.patch
mm-change-anon_vma-linking-to-fix-multi-process-server-scalability-issue-fix.patch
mm-change-anon_vma-linking-to-fix-multi-process-server-scalability-issue-further-cleanups.patch
rmap-remove-obsolete-check-from-__page_check_anon_rmap.patch
rmap-move-exclusively-owned-pages-to-own-anon_vma-in-do_wp_page.patch
mm-remove-vm_lock_rmap-code.patch
mm-swapfilec-fix-swapon-size-off-by-one.patch
mm-pm-force-gfp_noio-during-suspend-hibernation-and-resume.patch
mm-pm-force-gfp_noio-during-suspend-hibernation-and-resume-fix-3.patch
remove-unused-macro-vm_min_readahead.patch
frv-remove-pci_dma_sync_single-and-pci_dma_sync_sg.patch
frv-duplicate-output_buffer-of-e03.patch
frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch
alpha-ptr_err-overwrites-einval-in-syscall-osf_mount.patch
cpuidle-menu-remove-8-bytes-of-padding-on-64-bit-builds.patch
cris-convert-to-use-arch_gettimeoffset.patch
cryptocop-fix-assertion-in-create_output_descriptors.patch
cris-v32-typo-in-crisv32_arbiter_unwatch.patch
drivers-block-floppyc-convert-some-include-asm-to-include-linux.patch
drivers-block-floppyc-define-space-and-column-neatening.patch
drivers-block-floppyc-use-pr_level.patch
drivers-block-floppyc-remove-unnecessary-braces.patch
drivers-block-floppyc-remove-used-once-check_ready-macro.patch
drivers-block-floppyc-hoist-assigns-from-ifs-neatening.patch
drivers-block-floppyc-remove-last_out-macro.patch
drivers-block-floppyc-comment-neatening-and-remove-naked.patch
drivers-block-floppyc-remove-clearstruct-macro-use-memset.patch
drivers-block-floppyc-indent-a-comment.patch
drivers-block-floppyc-remove-in-out-macros-indent-switch-case.patch
drivers-block-floppyc-remove-a-few-spaces-from-function-casts.patch
drivers-block-floppyc-remove-macro-lock_fdc.patch
drivers-block-floppyc-add-debug_dcl-macro.patch
drivers-block-floppyc-remove-clearf-setf-and-testf-macros.patch
drivers-block-floppyc-remove-most-uses-of-call-and-ecall-macros.patch
drivers-block-floppyc-remove-copyin-copyout-and-ecall-macros.patch
drivers-block-floppyc-remove-macros-call-wait-and-iwait.patch
drivers-block-floppyc-convert-int-1-0-to-bool-true-false.patch
drivers-block-floppyc-move-leading-and-to-preceding-line.patch
drivers-block-floppyc-remove-define-device_name-floppy.patch
drivers-block-floppyc-convert-int-initialising-to-bool-initialized.patch
drivers-block-floppyc-add-function-is_ready_state.patch
drivers-block-floppyc-remove-unnecessary-return-and-braces.patch
drivers-block-floppyc-remove-repeat-macro.patch
drivers-block-floppyc-unclutter-redo_fd_request-logic.patch
drivers-block-floppyc-remove-unnecessary-argument-from-reschedule_timeout.patch
drivers-block-floppyc-remove-define-floppy_sanity_check.patch
drivers-block-floppyc-dprint-neatening.patch
drivers-block-floppyc-use-__func__-where-appropriate.patch
drivers-block-floppyc-use-%pf-in-logging-messages.patch
drivers-block-floppyc-remove-some-unnecessary-casting.patch
drivers-block-floppyc-convert-raw_cmd_copyin-from-while1-to-label-goto.patch
drivers-block-floppyc-add-__func__-to-debugt.patch
drivers-block-floppyc-remove-obfuscating-code2size-macro.patch
drivers-block-floppyc-remove-misleading-used-once-fd_ioctl_allowed-macro.patch
drivers-block-floppyc-remove-unnecessary-casting-in-fd_ioctl.patch
uml-linec-avoid-null-pointer-dereference.patch
uml-linec-avoid-null-pointer-dereference-simplify.patch
mfgpt-move-clocksource-menu.patch
prctl-add-pr_set_proctitle_area-option-for-prctl.patch
kernel-cpuc-delete-deprecated-definition-in-cpu_up.patch
init-mainc-improve-usability-in-case-of-init-binary-failure.patch
init-initramfsc-fix-symbol-shadows-an-earlier-one-noise.patch
cpumask-let-num__cpus-function-always-return-unsigned-values.patch
fs-use-rlimit-helpers.patch
nodemaskh-remove-macro-any_online_node.patch
smp-fix-documentation-in-include-linux-smph.patch
init-mainc-make-setup_max_cpus-static-for-smp.patch
drivers-misc-iwmc3200top-mainc-eliminate-useless-code.patch
eisa-fix-coding-style-for-eisa-bus-code.patch
lkdtm-add-debugfs-access-and-loosen-kprobe-ties.patch
kernel-exitc-fix-shadows-sparse-warning.patch
posix-cpu-timers-cleanup-rlimits-usage.patch
kernel-core-use-helpers-for-rlimits.patch
kernel-core-use-helpers-for-rlimits-fix.patch
panic-fix-panic_timeout-accuracy-when-running-on-a-hypervisor.patch
add-generic-sys_old_select.patch
add-generic-sys_old_select-fix.patch
add-generic-sys_old_mmap.patch
add-generic-sys_ipc-wrapper.patch
add-generic-sys_ipc-wrapper-fix.patch
improve-sys_personality-for-compat-architectures.patch
improve-sys_newuname-for-compat-architectures.patch
add-generic-sys_olduname.patch
core-workqueue-return-on-workqueue-recursion.patch
kernel-pidc-update-comment-on-find_task_by_pid_ns.patch
scripts-get_maintainerpl-add-file-emails-find-embedded-email-addresses.patch
scripts-get_maintainerpl-add-file-emails-find-embedded-email-addresses-v2.patch
scripts-get_maintainerpl-add-sections-print-entire-matched-subsystem.patch
scripts-get_maintainerpl-change-sections-to-print-in-the-same-style-as-maintainers.patch
scripts-get_maintainerpl-add-ability-to-read-from-stdin.patch
maintainers-remove-amd-geode-f-arch-x86-kernel-geode_32c.patch
maintainers-remove-hayes-esp-serial-driver.patch
maintainers-update-performance-events-f-patterns.patch
maintainers-starmode-radio-ip-strip-moved-to-staging.patch
maintainers-wavelan-moved-to-staging.patch
maintainers-document-and-add-q-patchwork-queue-entries.patch
lib-stringc-simplify-stricmp.patch
lib-stringc-simplify-strnstr.patch
lib-more-scalable-list_sort.patch
lib-more-scalable-list_sort-fix.patch
lib-revise-list_sort-header-comment.patch
lib-build-list_sort-only-if-needed.patch
bitmap-use-for_each_set_bit.patch
fs-compat_ioctlc-suppress-two-warnings.patch
mmc-remove-const-from-tmio-mmc-platform-data-v2.patch
mmc-balance-tmio-mmc-cell-enable-disable-calls.patch
ricoh_mmc-port-from-driver-to-pci-quirk.patch
ricoh_mmc-port-from-driver-to-pci-quirk-update.patch
davinci-mmc-add-support-for-8bit-mmc-cards.patch
mmc-atmel-host-kconfig-cleanup-for-everyone-else.patch
mmc-bfin_sdh-fix-unused-sg-warning-on-bf51x-bf52x-systems.patch
mmc-bfin_sdh-drop-redundant-mmc-depend-string.patch
mmc-bfin_sdh-set-timeout-based-on-actual-card-data.patch
sdio-add-quirk-to-clamp-byte-mode-transfer.patch
sdhci-add-adma-descriptor-set-call.patch
sdhci-improve-sdhci-sdhci_set_adma_desc-code.patch
sdio-recognize-io-card-without-powercycle.patch
scripts-checkpatchpl-add-warn-on-sizeof.patch
checkpatch-trivial-fix-for-trailing-statements-check.patch
checkpatchpl-allow-80-char-lines-for-logging-functions-not-just-printk.patch
checkpatch-fix-false-positive-on-__initconst.patch
checkpatchpl-add-union-and-struct-to-the-exceptions-list.patch
checkpatchpl-extend-list-of-expected-to-be-const-structures.patch
checkpatchpl-warn-if-an-adding-line-introduce-spaces-before-tabs.patch
checkpatch-warn-on-unnecessary-spaces-before-quoted-newlines.patch
drivers-hwmon-vt8231c-fix-continuation-line-formats.patch
hwmon-driver-for-ti-tmp102-temperature-sensor.patch
hwmon-driver-for-ti-tmp102-temperature-sensor-checkpatch-fixes.patch
hwmon-driver-for-ti-tmp102-temperature-sensor-fix.patch
lis3-add-missing-constants-for-8bit-device.patch
lis3-separate-configuration-function-for-8-bit-device.patch
lis3-introduce-platform-data-for-second-ff-wu-unit.patch
lis3-power-control-for-the-chip.patch
lis3-add-skeletons-for-interrupt-handlers.patch
lis3-interrupt-handlers-for-8bit-wakeup-and-click-events.patch
proc-do-translation-unlink-atomically-at-remove_proc_entry.patch
proc-warn-on-non-existing-proc-entries.patch
coredump-unify-dump_seek-implementations-for-each-binfmt_c.patch
coredump-move-dump_write-and-dump_seek-into-a-header-file.patch
elf-coredump-replace-elf_core_extra_-macros-by-functions.patch
elf-coredump-replace-elf_core_extra_-macros-by-functions-fix.patch
elf-coredump-make-offset-calculation-process-and-writing-process-explicit.patch
elf-coredump-add-extended-numbering-support.patch
mm-pass-mm-flags-as-a-coredump-parameter-for-consistency.patch
mm-pass-mm-flags-as-a-coredump-parameter-for-consistency-fix.patch
coredump-set-group_exit_code-for-other-clone_vm-tasks-too.patch
console-limit-the-range-of-vgacon_soft_scrollback_size.patch
console-vgaconc-mark-file-local-symbol-static.patch
xen-add-kconfig-menu.patch
rtc-mxc-fix-memory-leak.patch
rtc-mxc-fix-memory-leak-fix.patch
rtc-ep93xxc-cleanup-probe-remove-routines.patch
rtc-pcf2123-move-pcf2123_remove-to-devexittext.patch
rtc-at91sam9-correct-size-given-to-memset.patch
rtc-twl-storage-class-should-be-before-const-qualifier.patch
gpio-add-driver-for-max7300-i2c-gpio-extender.patch
pca953x-minor-include-cleanup.patch
gpio-introduce-gpio_request_one-and-friends.patch
gpio-introduce-gpio_request_one-and-friends-update.patch
timbgpio-add-support-for-interrupt-triggering-on-both-flanks.patch
gpio-pca953xc-add-interrupt-handling-capability.patch
gpio-pca953xc-add-interrupt-handling-capability-fix.patch
gpio-pca953xc-add-interrupt-handling-capability-v4.patch
gpiolib-introduce-chip-addition-removal-notifier.patch
of-gpio-add-support-for-two-stage-registration-for-the-of_gpio_chips.patch
of-gpio-implement-gpiolib-notifier-hooks.patch
of-gpio-implement-gpiolib-notifier-hooks-fix.patch
powerpc-mcu_mpc8349emitx-remove-of-gpio-handling-stuff.patch
asiliantfb-fix-test-of-unsigned-in-asiliant_calc_dclk2.patch
fbdev-bf54x-lq043fb-bfin-t350mcqb-fb-drop-custom-mmap-handler.patch
broadsheetfb-add-multiple-panel-type-support.patch
viafb-deprecate-private-ioctls.patch
viafb-remove-dead-code.patch
viafb-split-global-index-up.patch
viafb-split-global-index-up-fix.patch
viafb-remove-the-remaining-via_res_-uses.patch
viafb-some-dvi-cleanup.patch
viafb-yet-another-dead-code-removal.patch
viafb-reorder-initialization-for-dual-framebuffer-mode.patch
viafb-video-address-setting-revisited.patch
viafb-make-viafb_set_par-more-dual-framebuffer-compatible.patch
broadsheetfb-add-mmio-hooks.patch
broadsheetfb-support-storing-waveform.patch
broadsheetfb-support-storing-waveform-fix.patch
intelfb-new-maintainer.patch
fbdev-remove-obsolete-config_fb_soft_cursor.patch
nuc900-lcd-controller-driver.patch
nuc900-lcd-controller-driver-updates.patch
drivers-video-via-fix-continuation-line-formats.patch
platform-drivers-move-probe-to-devinittext-in-drivers-video.patch
auxdisplay-move-cfag12864bfbs-probe-function-to-devinittext.patch
obsolete-config-in-kernel-source-lwmon5.patch
devmem-dont-allow-seek-to-last-page.patch
drivers-char-memc-cleanups.patch
drivers-char-memc-cleanups-fix.patch
drivers-char-memc-cleanups-fix-fix.patch
hfsplus-identify-journal-info-block-in-volume-header.patch
hfsplus-fix-journal-detection.patch
fs-ufs-recognize-solaris-specific-file-system-state.patch
doc-console-doc-should-read-bind-unbind-instead-of-bind-bind.patch
documentation-timers-split-txt-and-source-files.patch
documentation-laptop-split-txt-and-source-files.patch
documentation-fs-split-txt-and-source-files.patch
documentation-vm-split-txt-and-source-files.patch
cgroup-introduce-cancel_attach.patch
cgroup-introduce-coalesce-css_get-and-css_put.patch
cgroups-revamp-subsys-array.patch
cgroups-subsystem-module-loading-interface.patch
cgroups-subsystem-module-loading-interface-fix.patch
cgroups-subsystem-module-unloading.patch
cgroups-subsystem-module-unloading-fix.patch
cgroups-net_cls-as-module.patch
cgroups-fix-contents-in-cgroups-documentation.patch
cgroups-blkio-subsystem-as-module.patch
cgroups-clean-up-cgroup_pidlist_find-a-bit.patch
memcg-add-interface-to-move-charge-at-task-migration.patch
memcg-move-charges-of-anonymous-page.patch
memcg-move-charges-of-anonymous-page-cleanup.patch
memcg-improve-performance-in-moving-charge.patch
memcg-avoid-oom-during-moving-charge.patch
memcg-move-charges-of-anonymous-swap.patch
memcg-move-charges-of-anonymous-swap-fix.patch
memcg-move-charges-of-anonymous-swap-fix-2.patch
memcg-improve-performance-in-moving-swap-charge.patch
memcg-improve-performance-in-moving-swap-charge-fix.patch
cgroup-implement-eventfd-based-generic-api-for-notifications.patch
cgroup-implement-eventfd-based-generic-api-for-notifications-kconfig-fix.patch
cgroup-implement-eventfd-based-generic-api-for-notifications-fixes.patch
memcg-extract-mem_group_usage-from-mem_cgroup_read.patch
memcg-rework-usage-of-stats-by-soft-limit.patch
memcg-implement-memory-thresholds.patch
memcg-implement-memory-thresholds-checkpatch-fixes.patch
memcg-implement-memory-thresholds-checkpatch-fixes-fix.patch
memcg-typo-in-comment-to-mem_cgroup_print_oom_info.patch
memcg-use-generic-percpu-instead-of-private-implementation.patch
ptrace-use-ptrace_request-in-the-remaining-architectures.patch
ptrace-move-user_enable_single_step-co-prototypes-to-linux-ptraceh.patch
alpha-use-generic-ptrace_resume-code.patch
arm-use-generic-ptrace_resume-code.patch
avr32-use-generic-ptrace_resume-code.patch
blackfin-use-generic-ptrace_resume-code.patch
h8300-use-generic-ptrace_resume-code.patch
m68knommu-use-generic-ptrace_resume-code.patch
microblaze-use-generic-ptrace_resume-code.patch
mips-use-generic-ptrace_resume-code.patch
um-use-generic-ptrace_resume-code.patch
xtensa-use-generic-ptrace_resume-code.patch
cris-arch-v10-use-generic-ptrace_resume-code.patch
cris-arch-v32-use-generic-ptrace_resume-code.patch
m32r-use-generic-ptrace_resume-code.patch
tracehooks-kill-some-pt_ptraced-checks.patch
tracehooks-check-pt_ptraced-before-reporting-the-single-step.patch
ptrace_signal-check-pt_ptraced-before-reporting-a-signal.patch
export-__ptrace_detach-and-do_notify_parent_cldstop.patch
reorder-the-code-in-kernel-ptracec.patch
implement-utrace-ptrace.patch
utrace-core.patch
utrace-core-utrace-fix-utrace_maybe_reap-vs-find_matching_engine-race.patch
copy_signal-cleanup-use-zalloc-and-remove-initializations.patch
copy_signal-cleanup-kill-taskstats_tgid_init-and-acct_init_pacct.patch
copy_signal-cleanup-clean-thread_group_cputime_init.patch
copy_signal-cleanup-clean-tty_audit_fork.patch
ipc-use-rlimit-helpers.patch
ipmi-add-parameter-to-limit-cpu-usage-in-kipmid.patch
rcu-add-rcustring-adt-for-rcu-protected-strings.patch
add-a-kernel_address-that-works-for-data-too.patch
sysctl-add-proc_rcu_string-to-manage-sysctls-using-rcu-strings.patch
sysctl-use-rcu-strings-for-core_pattern-sysctl.patch
sysctl-add-call_usermodehelper_cleanup.patch
sysctl-convert-modprobe_path-to-proc_rcu_string.patch
sysctl-convert-poweroff_command-to-proc_rcu_string.patch
sysctl-convert-hotplug-helper-string-to-proc_rcu_string.patch
sysctl-use-rcu-protected-sysctl-for-ocfs-group-add-helper.patch
sysctl-clean-up-vm-related-variable-declarations.patch
sysctl-clean-up-vm-related-variable-declarations-fix.patch
sysctl-remove-references-to-ctl_unnumbered-which-has-been-removed.patch
kmod-add-init-function-to-usermodehelper.patch
kmod-add-init-function-to-usermodehelper-fix.patch
kmod-replace-call_usermodehelper_pipe-with-use-of-umh-init-function-and-resolve-limit.patch
delay-accounting-re-implement-c-for-getdelaysc-to-report-information-on-a-target-command.patch
delay-accounting-re-implement-c-for-getdelaysc-to-report-information-on-a-target-command-checkpatch-fixes.patch
drivers-edac-introduce-missing-kfree.patch
edac-add-__init-to-i7core_xeon_pci_fixup.patch
edac-mpc85xx-mask-ecc-syndrome-correctly.patch
edac-mpc85xx-improve-sdram-error-reporting.patch
edac-mpc85xx-use-resource_size-instead-of-raw-math.patch
edac-e752x-fsb-ecc.patch
edac-e752x-add-dram-scrubbing-support.patch
documentation-dma-apitxt-remove-deprecated-function-descriptions.patch
dma-apitxt-add-dma_sync_single-sg-api-description.patch
dma-apitxt-remove-dma_sync_single_range-description.patch
alpha-remove-dma_sync_single_range.patch
um-remove-dma_sync_single_range.patch
w1-fix-test-in-ds2482_wait_1wire_idle.patch
w1-move-omap_hdqs-probe-function-to-devinittext.patch
drivers-char-mmtimerc-eliminate-useless-code.patch
sgi-gru-use-for_each_set_bit.patch
zlib-make-new-optimized-inflate-endian-independent.patch
vfs-add-super-operation-writeback_inodes.patch
vfs-take-2add-set_page_dirty_notag.patch
reiser4-export-remove_from_page_cache.patch
reiser4-export-remove_from_page_cache-fix.patch
reiser4-export-find_get_pages.patch
reiser4.patch
reiser4-writeback_inodes-implementation.patch
reiser4-writeback_inodes-implementation-fix.patch
reiser4-fixup-checkin-checkout-jnodes-for-entd.patch
make-sure-nobodys-leaking-resources.patch
journal_add_journal_head-debug.patch
releasing-resources-with-children.patch
make-frame_pointer-default=y.patch
mutex-subsystem-synchro-test-module.patch
mutex-subsystem-synchro-test-module-add-missing-header-file.patch
slab-leaks3-default-y.patch
put_bh-debug.patch
add-debugging-aid-for-memory-initialisation-problems.patch
workaround-for-a-pci-restoring-bug.patch
prio_tree-debugging-patch.patch
single_open-seq_release-leak-diagnostics.patch
add-a-refcount-check-in-dput.patch
getblk-handle-2tb-devices.patch
getblk-handle-2tb-devices-fix.patch
notify_change-callers-must-hold-i_mutex.patch


2010-02-11 02:45:34

by Randy Dunlap

[permalink] [raw]
Subject: Re: mmotm 2010-02-10-16-17 uploaded (timberdale)

On 02/10/10 16:17, [email protected] wrote:
> The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
>
> and will soon be available at
>
> git://zen-kernel.org/kernel/mmotm.git
>
> It contains the following patches against 2.6.33-rc7:


When CONFIG_GPIOLIB is not enabled:

CC drivers/mfd/timberdale.o
In file included from mmotm-2010-0210-1617/drivers/mfd/timberdale.c:37:
mmotm-2010-0210-1617/include/linux/spi/max7301.h:14: error: field 'chip' has incomplete type
make[3]: *** [drivers/mfd/timberdale.o] Error 1


Build error observed on i386 and on x86_64.

--
~Randy

2010-02-11 05:17:47

by Valdis Klētnieks

[permalink] [raw]
Subject: mmotm 2010-02-10 - lockdep whinge in ACPI code

On Wed, 10 Feb 2010 16:17:41 PST, [email protected] said:
> The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/

Seen at boot:

[ 0.207242] ACPI: (supports S0 S5)
[ 0.207257] ACPI: Using IOAPIC for interrupt routing
[ 0.335315]
[ 0.335316] =============================================
[ 0.335483] [ INFO: possible recursive locking detected ]
[ 0.335572] 2.6.33-rc7-mmotm0210 #1
[ 0.335658] ---------------------------------------------
[ 0.335746] swapper/1 is trying to acquire lock:
[ 0.335834] (&dev->mutex){+.+...}, at: [<ffffffff812eb521>] __driver_attach+0x47/0x80
[ 0.335999]
[ 0.335999] but task is already holding lock:
[ 0.335999] (&dev->mutex){+.+...}, at: [<ffffffff812eb513>] __driver_attach+0x39/0x80
[ 0.335999]
[ 0.335999] other info that might help us debug this:
[ 0.335999] 1 lock held by swapper/1:
[ 0.335999] #0: (&dev->mutex){+.+...}, at: [<ffffffff812eb513>] __driver_attach+0x39/0x80
[ 0.335999]
[ 0.335999] stack backtrace:
[ 0.335999] Pid: 1, comm: swapper Not tainted 2.6.33-rc7-mmotm0210 #1
[ 0.335999] Call Trace:
[ 0.335999] [<ffffffff81063b47>] __lock_acquire+0xc77/0xcee
[ 0.335999] [<ffffffff81061fad>] ? mark_lock+0x2d/0x22c
[ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
[ 0.335999] [<ffffffff81063c89>] lock_acquire+0xcb/0xe8
[ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
[ 0.335999] [<ffffffff810621fe>] ? mark_held_locks+0x52/0x70
[ 0.335999] [<ffffffff81568c9d>] __mutex_lock_common+0x5c/0x5aa
[ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
[ 0.335999] [<ffffffff815583f8>] ? klist_next+0x24/0xd7
[ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
[ 0.335999] [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
[ 0.335999] [<ffffffff81569291>] mutex_lock_nested+0x34/0x39
[ 0.335999] [<ffffffff812eb521>] __driver_attach+0x47/0x80
[ 0.335999] [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
[ 0.335999] [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
[ 0.335999] [<ffffffff812eaa43>] bus_for_each_dev+0x54/0x89
[ 0.335999] [<ffffffff812eb28a>] driver_attach+0x19/0x1b
[ 0.335999] [<ffffffff812eaed5>] bus_add_driver+0xb4/0x203
[ 0.335999] [<ffffffff812eb833>] driver_register+0xb8/0x129
[ 0.335999] [<ffffffff81231604>] acpi_bus_register_driver+0x3e/0x40
[ 0.335999] [<ffffffff81b45094>] acpi_ec_init+0x37/0x55
[ 0.335999] [<ffffffff81b44ef1>] acpi_init+0x115/0x12a
[ 0.335999] [<ffffffff81b44ddc>] ? acpi_init+0x0/0x12a
[ 0.335999] [<ffffffff810001ef>] do_one_initcall+0x59/0x14e
[ 0.335999] [<ffffffff81b26655>] kernel_init+0x14d/0x1a3
[ 0.335999] [<ffffffff81003354>] kernel_thread_helper+0x4/0x10
[ 0.335999] [<ffffffff8156b0c0>] ? restore_args+0x0/0x30
[ 0.335999] [<ffffffff81b26508>] ? kernel_init+0x0/0x1a3
[ 0.335999] [<ffffffff81003350>] ? kernel_thread_helper+0x0/0x10
[ 0.340036] ACPI: EC: GPE = 0x11, I/O: command/status = 0x934, data = 0x930


Attachments:
(No filename) (227.00 B)

2010-02-11 05:28:07

by Andrew Morton

[permalink] [raw]
Subject: Re: mmotm 2010-02-10 - lockdep whinge in ACPI code

On Thu, 11 Feb 2010 00:11:44 -0500 [email protected] wrote:

> On Wed, 10 Feb 2010 16:17:41 PST, [email protected] said:
> > The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> Seen at boot:
>
> [ 0.207242] ACPI: (supports S0 S5)
> [ 0.207257] ACPI: Using IOAPIC for interrupt routing
> [ 0.335315]
> [ 0.335316] =============================================
> [ 0.335483] [ INFO: possible recursive locking detected ]
> [ 0.335572] 2.6.33-rc7-mmotm0210 #1
> [ 0.335658] ---------------------------------------------
> [ 0.335746] swapper/1 is trying to acquire lock:
> [ 0.335834] (&dev->mutex){+.+...}, at: [<ffffffff812eb521>] __driver_attach+0x47/0x80
> [ 0.335999]
> [ 0.335999] but task is already holding lock:
> [ 0.335999] (&dev->mutex){+.+...}, at: [<ffffffff812eb513>] __driver_attach+0x39/0x80
> [ 0.335999]
> [ 0.335999] other info that might help us debug this:
> [ 0.335999] 1 lock held by swapper/1:
> [ 0.335999] #0: (&dev->mutex){+.+...}, at: [<ffffffff812eb513>] __driver_attach+0x39/0x80
> [ 0.335999]
> [ 0.335999] stack backtrace:
> [ 0.335999] Pid: 1, comm: swapper Not tainted 2.6.33-rc7-mmotm0210 #1
> [ 0.335999] Call Trace:
> [ 0.335999] [<ffffffff81063b47>] __lock_acquire+0xc77/0xcee
> [ 0.335999] [<ffffffff81061fad>] ? mark_lock+0x2d/0x22c
> [ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
> [ 0.335999] [<ffffffff81063c89>] lock_acquire+0xcb/0xe8
> [ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
> [ 0.335999] [<ffffffff810621fe>] ? mark_held_locks+0x52/0x70
> [ 0.335999] [<ffffffff81568c9d>] __mutex_lock_common+0x5c/0x5aa
> [ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
> [ 0.335999] [<ffffffff815583f8>] ? klist_next+0x24/0xd7
> [ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
> [ 0.335999] [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
> [ 0.335999] [<ffffffff81569291>] mutex_lock_nested+0x34/0x39
> [ 0.335999] [<ffffffff812eb521>] __driver_attach+0x47/0x80
> [ 0.335999] [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
> [ 0.335999] [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
> [ 0.335999] [<ffffffff812eaa43>] bus_for_each_dev+0x54/0x89
> [ 0.335999] [<ffffffff812eb28a>] driver_attach+0x19/0x1b
> [ 0.335999] [<ffffffff812eaed5>] bus_add_driver+0xb4/0x203
> [ 0.335999] [<ffffffff812eb833>] driver_register+0xb8/0x129
> [ 0.335999] [<ffffffff81231604>] acpi_bus_register_driver+0x3e/0x40
> [ 0.335999] [<ffffffff81b45094>] acpi_ec_init+0x37/0x55
> [ 0.335999] [<ffffffff81b44ef1>] acpi_init+0x115/0x12a
> [ 0.335999] [<ffffffff81b44ddc>] ? acpi_init+0x0/0x12a
> [ 0.335999] [<ffffffff810001ef>] do_one_initcall+0x59/0x14e
> [ 0.335999] [<ffffffff81b26655>] kernel_init+0x14d/0x1a3
> [ 0.335999] [<ffffffff81003354>] kernel_thread_helper+0x4/0x10
> [ 0.335999] [<ffffffff8156b0c0>] ? restore_args+0x0/0x30
> [ 0.335999] [<ffffffff81b26508>] ? kernel_init+0x0/0x1a3
> [ 0.335999] [<ffffffff81003350>] ? kernel_thread_helper+0x0/0x10
> [ 0.340036] ACPI: EC: GPE = 0x11, I/O: command/status = 0x934, data = 0x930
>

driver_attach() got converted from sem to mutex in linux-next. So this
is probably an old bug which just got exposed.

Or maybe not. Thomas, has that patch been in some other tree (rt?) for
a while? If so, was this bug observed in that tree? If not, it might
be new.

2010-02-11 15:01:50

by Greg KH

[permalink] [raw]
Subject: Re: mmotm 2010-02-10 - lockdep whinge in ACPI code

On Wed, Feb 10, 2010 at 09:26:55PM -0800, Andrew Morton wrote:
> On Thu, 11 Feb 2010 00:11:44 -0500 [email protected] wrote:
>
> > On Wed, 10 Feb 2010 16:17:41 PST, [email protected] said:
> > > The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
> > >
> > > http://userweb.kernel.org/~akpm/mmotm/
> >
> > Seen at boot:
> >
> > [ 0.207242] ACPI: (supports S0 S5)
> > [ 0.207257] ACPI: Using IOAPIC for interrupt routing
> > [ 0.335315]
> > [ 0.335316] =============================================
> > [ 0.335483] [ INFO: possible recursive locking detected ]
> > [ 0.335572] 2.6.33-rc7-mmotm0210 #1
> > [ 0.335658] ---------------------------------------------
> > [ 0.335746] swapper/1 is trying to acquire lock:
> > [ 0.335834] (&dev->mutex){+.+...}, at: [<ffffffff812eb521>] __driver_attach+0x47/0x80
> > [ 0.335999]
> > [ 0.335999] but task is already holding lock:
> > [ 0.335999] (&dev->mutex){+.+...}, at: [<ffffffff812eb513>] __driver_attach+0x39/0x80
> > [ 0.335999]
> > [ 0.335999] other info that might help us debug this:
> > [ 0.335999] 1 lock held by swapper/1:
> > [ 0.335999] #0: (&dev->mutex){+.+...}, at: [<ffffffff812eb513>] __driver_attach+0x39/0x80
> > [ 0.335999]
> > [ 0.335999] stack backtrace:
> > [ 0.335999] Pid: 1, comm: swapper Not tainted 2.6.33-rc7-mmotm0210 #1
> > [ 0.335999] Call Trace:
> > [ 0.335999] [<ffffffff81063b47>] __lock_acquire+0xc77/0xcee
> > [ 0.335999] [<ffffffff81061fad>] ? mark_lock+0x2d/0x22c
> > [ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
> > [ 0.335999] [<ffffffff81063c89>] lock_acquire+0xcb/0xe8
> > [ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
> > [ 0.335999] [<ffffffff810621fe>] ? mark_held_locks+0x52/0x70
> > [ 0.335999] [<ffffffff81568c9d>] __mutex_lock_common+0x5c/0x5aa
> > [ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
> > [ 0.335999] [<ffffffff815583f8>] ? klist_next+0x24/0xd7
> > [ 0.335999] [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
> > [ 0.335999] [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
> > [ 0.335999] [<ffffffff81569291>] mutex_lock_nested+0x34/0x39
> > [ 0.335999] [<ffffffff812eb521>] __driver_attach+0x47/0x80
> > [ 0.335999] [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
> > [ 0.335999] [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
> > [ 0.335999] [<ffffffff812eaa43>] bus_for_each_dev+0x54/0x89
> > [ 0.335999] [<ffffffff812eb28a>] driver_attach+0x19/0x1b
> > [ 0.335999] [<ffffffff812eaed5>] bus_add_driver+0xb4/0x203
> > [ 0.335999] [<ffffffff812eb833>] driver_register+0xb8/0x129
> > [ 0.335999] [<ffffffff81231604>] acpi_bus_register_driver+0x3e/0x40
> > [ 0.335999] [<ffffffff81b45094>] acpi_ec_init+0x37/0x55
> > [ 0.335999] [<ffffffff81b44ef1>] acpi_init+0x115/0x12a
> > [ 0.335999] [<ffffffff81b44ddc>] ? acpi_init+0x0/0x12a
> > [ 0.335999] [<ffffffff810001ef>] do_one_initcall+0x59/0x14e
> > [ 0.335999] [<ffffffff81b26655>] kernel_init+0x14d/0x1a3
> > [ 0.335999] [<ffffffff81003354>] kernel_thread_helper+0x4/0x10
> > [ 0.335999] [<ffffffff8156b0c0>] ? restore_args+0x0/0x30
> > [ 0.335999] [<ffffffff81b26508>] ? kernel_init+0x0/0x1a3
> > [ 0.335999] [<ffffffff81003350>] ? kernel_thread_helper+0x0/0x10
> > [ 0.340036] ACPI: EC: GPE = 0x11, I/O: command/status = 0x934, data = 0x930
> >
>
> driver_attach() got converted from sem to mutex in linux-next. So this
> is probably an old bug which just got exposed.

Odds are it is not a bug, I need to revert that patch as it does not
work well (i.e. at all) with lockdep.

thanks,

greg k-h

2010-02-11 22:02:13

by Andrew Morton

[permalink] [raw]
Subject: Re: mmotm 2010-02-10-16-17 uploaded (timberdale)

On Wed, 10 Feb 2010 18:43:33 -0800
Randy Dunlap <[email protected]> wrote:

> On 02/10/10 16:17, [email protected] wrote:
> > The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
> >
> > and will soon be available at
> >
> > git://zen-kernel.org/kernel/mmotm.git
> >
> > It contains the following patches against 2.6.33-rc7:
>
>
> When CONFIG_GPIOLIB is not enabled:
>
> CC drivers/mfd/timberdale.o
> In file included from mmotm-2010-0210-1617/drivers/mfd/timberdale.c:37:
> mmotm-2010-0210-1617/include/linux/spi/max7301.h:14: error: field 'chip' has incomplete type
> make[3]: *** [drivers/mfd/timberdale.o] Error 1
>
>
> Build error observed on i386 and on x86_64.
>

Bug is in mainline too, I think.

Something like this?

--- a/drivers/gpio/Kconfig~drivers-gpio-max7301c-depends-on-gpiolib
+++ a/drivers/gpio/Kconfig
@@ -92,7 +92,7 @@ comment "I2C GPIO expanders:"

config GPIO_MAX7300
tristate "Maxim MAX7300 GPIO expander"
- depends on I2C
+ depends on I2C && GPIOLIB
select GPIO_MAX730X
help
GPIO driver for Maxim MAX7301 I2C-based GPIO expander.
_

2010-02-11 22:21:29

by Randy Dunlap

[permalink] [raw]
Subject: Re: mmotm 2010-02-10-16-17 uploaded (timberdale)

On 02/11/10 14:01, Andrew Morton wrote:
> On Wed, 10 Feb 2010 18:43:33 -0800
> Randy Dunlap <[email protected]> wrote:
>
>> On 02/10/10 16:17, [email protected] wrote:
>>> The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
>>>
>>> http://userweb.kernel.org/~akpm/mmotm/
>>>
>>> and will soon be available at
>>>
>>> git://zen-kernel.org/kernel/mmotm.git
>>>
>>> It contains the following patches against 2.6.33-rc7:
>>
>>
>> When CONFIG_GPIOLIB is not enabled:
>>
>> CC drivers/mfd/timberdale.o
>> In file included from mmotm-2010-0210-1617/drivers/mfd/timberdale.c:37:
>> mmotm-2010-0210-1617/include/linux/spi/max7301.h:14: error: field 'chip' has incomplete type
>> make[3]: *** [drivers/mfd/timberdale.o] Error 1
>>
>>
>> Build error observed on i386 and on x86_64.
>>
>
> Bug is in mainline too, I think.
>
> Something like this?

Nope, that does not affect the building of the timberdale (see $subject) driver.
It still has the same error with this patch applied.


> --- a/drivers/gpio/Kconfig~drivers-gpio-max7301c-depends-on-gpiolib
> +++ a/drivers/gpio/Kconfig
> @@ -92,7 +92,7 @@ comment "I2C GPIO expanders:"
>
> config GPIO_MAX7300
> tristate "Maxim MAX7300 GPIO expander"
> - depends on I2C
> + depends on I2C && GPIOLIB
> select GPIO_MAX730X
> help
> GPIO driver for Maxim MAX7301 I2C-based GPIO expander.
> _
>


--
~Randy

2010-02-11 22:38:37

by Andrew Morton

[permalink] [raw]
Subject: Re: mmotm 2010-02-10-16-17 uploaded (timberdale)

On Thu, 11 Feb 2010 14:18:52 -0800
Randy Dunlap <[email protected]> wrote:

> On 02/11/10 14:01, Andrew Morton wrote:
> > On Wed, 10 Feb 2010 18:43:33 -0800
> > Randy Dunlap <[email protected]> wrote:
> >
> >> On 02/10/10 16:17, [email protected] wrote:
> >>> The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
> >>>
> >>> http://userweb.kernel.org/~akpm/mmotm/
> >>>
> >>> and will soon be available at
> >>>
> >>> git://zen-kernel.org/kernel/mmotm.git
> >>>
> >>> It contains the following patches against 2.6.33-rc7:
> >>
> >>
> >> When CONFIG_GPIOLIB is not enabled:
> >>
> >> CC drivers/mfd/timberdale.o
> >> In file included from mmotm-2010-0210-1617/drivers/mfd/timberdale.c:37:
> >> mmotm-2010-0210-1617/include/linux/spi/max7301.h:14: error: field 'chip' has incomplete type
> >> make[3]: *** [drivers/mfd/timberdale.o] Error 1
> >>
> >>
> >> Build error observed on i386 and on x86_64.
> >>
> >
> > Bug is in mainline too, I think.
> >
> > Something like this?
>
> Nope, that does not affect the building of the timberdale (see $subject) driver.
> It still has the same error with this patch applied.

Yeah, I patched the wrong record.

>
> > --- a/drivers/gpio/Kconfig~drivers-gpio-max7301c-depends-on-gpiolib
> > +++ a/drivers/gpio/Kconfig
> > @@ -92,7 +92,7 @@ comment "I2C GPIO expanders:"
> >
> > config GPIO_MAX7300
> > tristate "Maxim MAX7300 GPIO expander"
> > - depends on I2C
> > + depends on I2C && GPIOLIB
> > select GPIO_MAX730X
> > help
> > GPIO driver for Maxim MAX7301 I2C-based GPIO expander.

This?

--- a/drivers/gpio/Kconfig~drivers-gpio-max7301c-depends-on-gpiolib
+++ a/drivers/gpio/Kconfig
@@ -256,7 +256,7 @@ comment "SPI GPIO expanders:"

config GPIO_MAX7301
tristate "Maxim MAX7301 GPIO expander"
- depends on SPI_MASTER
+ depends on SPI_MASTER && GPIO_LIB
select GPIO_MAX730X
help
GPIO driver for Maxim MAX7301 SPI-based GPIO expander.
_

2010-02-11 23:31:29

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH -mmotm] timberdale: fix mfd build

> This?

Nope, still has the same error.
Use this one instead. It builds now.

---
From: Randy Dunlap <[email protected]>

Fix mfd/timberdale build error -- add depends GPIOLIB.

include/linux/spi/max7301.h:14: error: field 'chip' has incomplete type
build-r7353.out:make[3]: *** [drivers/mfd/timberdale.o] Error 1

Signed-off-by: Randy Dunlap <[email protected]>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- mmotm-2010-0210-1617.orig/drivers/mfd/Kconfig
+++ mmotm-2010-0210-1617/drivers/mfd/Kconfig
@@ -382,7 +382,7 @@ config AB4500_CORE
config MFD_TIMBERDALE
tristate "Support for the Timberdale FPGA"
select MFD_CORE
- depends on PCI
+ depends on PCI && GPIOLIB
---help---
This is the core driver for the timberdale FPGA. This device is a
multifunction device which exposes numerous platform devices.

2010-02-12 02:11:34

by Dave Young

[permalink] [raw]
Subject: Re: mmotm 2010-02-10 - lockdep whinge in ACPI code

On Thu, Feb 11, 2010 at 1:26 PM, Andrew Morton
<[email protected]> wrote:
> On Thu, 11 Feb 2010 00:11:44 -0500 [email protected] wrote:
>
>> On Wed, 10 Feb 2010 16:17:41 PST, [email protected] said:
>> > The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
>> >
>> >    http://userweb.kernel.org/~akpm/mmotm/
>>
>> Seen at boot:
>>
>> [    0.207242] ACPI: (supports S0 S5)
>> [    0.207257] ACPI: Using IOAPIC for interrupt routing
>> [    0.335315]
>> [    0.335316] =============================================
>> [    0.335483] [ INFO: possible recursive locking detected ]
>> [    0.335572] 2.6.33-rc7-mmotm0210 #1
>> [    0.335658] ---------------------------------------------
>> [    0.335746] swapper/1 is trying to acquire lock:
>> [    0.335834]  (&dev->mutex){+.+...}, at: [<ffffffff812eb521>] __driver_attach+0x47/0x80
>> [    0.335999]
>> [    0.335999] but task is already holding lock:
>> [    0.335999]  (&dev->mutex){+.+...}, at: [<ffffffff812eb513>] __driver_attach+0x39/0x80
>> [    0.335999]
>> [    0.335999] other info that might help us debug this:
>> [    0.335999] 1 lock held by swapper/1:
>> [    0.335999]  #0:  (&dev->mutex){+.+...}, at: [<ffffffff812eb513>] __driver_attach+0x39/0x80
>> [    0.335999]
>> [    0.335999] stack backtrace:
>> [    0.335999] Pid: 1, comm: swapper Not tainted 2.6.33-rc7-mmotm0210 #1
>> [    0.335999] Call Trace:
>> [    0.335999]  [<ffffffff81063b47>] __lock_acquire+0xc77/0xcee
>> [    0.335999]  [<ffffffff81061fad>] ? mark_lock+0x2d/0x22c
>> [    0.335999]  [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
>> [    0.335999]  [<ffffffff81063c89>] lock_acquire+0xcb/0xe8
>> [    0.335999]  [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
>> [    0.335999]  [<ffffffff810621fe>] ? mark_held_locks+0x52/0x70
>> [    0.335999]  [<ffffffff81568c9d>] __mutex_lock_common+0x5c/0x5aa
>> [    0.335999]  [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
>> [    0.335999]  [<ffffffff815583f8>] ? klist_next+0x24/0xd7
>> [    0.335999]  [<ffffffff812eb521>] ? __driver_attach+0x47/0x80
>> [    0.335999]  [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
>> [    0.335999]  [<ffffffff81569291>] mutex_lock_nested+0x34/0x39
>> [    0.335999]  [<ffffffff812eb521>] __driver_attach+0x47/0x80
>> [    0.335999]  [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
>> [    0.335999]  [<ffffffff812eb4da>] ? __driver_attach+0x0/0x80
>> [    0.335999]  [<ffffffff812eaa43>] bus_for_each_dev+0x54/0x89
>> [    0.335999]  [<ffffffff812eb28a>] driver_attach+0x19/0x1b
>> [    0.335999]  [<ffffffff812eaed5>] bus_add_driver+0xb4/0x203
>> [    0.335999]  [<ffffffff812eb833>] driver_register+0xb8/0x129
>> [    0.335999]  [<ffffffff81231604>] acpi_bus_register_driver+0x3e/0x40
>> [    0.335999]  [<ffffffff81b45094>] acpi_ec_init+0x37/0x55
>> [    0.335999]  [<ffffffff81b44ef1>] acpi_init+0x115/0x12a
>> [    0.335999]  [<ffffffff81b44ddc>] ? acpi_init+0x0/0x12a
>> [    0.335999]  [<ffffffff810001ef>] do_one_initcall+0x59/0x14e
>> [    0.335999]  [<ffffffff81b26655>] kernel_init+0x14d/0x1a3
>> [    0.335999]  [<ffffffff81003354>] kernel_thread_helper+0x4/0x10
>> [    0.335999]  [<ffffffff8156b0c0>] ? restore_args+0x0/0x30
>> [    0.335999]  [<ffffffff81b26508>] ? kernel_init+0x0/0x1a3
>> [    0.335999]  [<ffffffff81003350>] ? kernel_thread_helper+0x0/0x10
>> [    0.340036] ACPI: EC: GPE = 0x11, I/O: command/status = 0x934, data = 0x930
>>
>
> driver_attach() got converted from sem to mutex in linux-next.  So this
> is probably an old bug which just got exposed.

Here is the possible fix for this:
http://lkml.org/lkml/2010/2/8/161

>
> Or maybe not.  Thomas, has that patch been in some other tree (rt?) for
> a while?  If so, was this bug observed in that tree?  If not, it might
> be new.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



--
Regards
dave

2010-02-12 02:44:30

by Valdis Klētnieks

[permalink] [raw]
Subject: mmotm 2010-02-10 - BUG at fs/dcache.c:677!

On Wed, 10 Feb 2010 16:17:41 PST, [email protected] said:
> The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/

Hit this at shutdown. ext4 filesystems. Brought it up to single-user
mode, then 'shutdown -h now'.

[ 58.311786] ------------[ cut here ]------------
[ 58.312261] kernel BUG at fs/dcache.c:677!
[ 58.312261] invalid opcode: 0000 [#1] PREEMPT SMP
[ 58.312261] last sysfs file: /sys/devices/virtual/block/dm-10/dm/name
[ 58.312261] CPU 1
[ 58.312261] Pid: 3007, comm: umount Not tainted 2.6.33-rc7-mmotm0210 #1 0X564R/Latitude E6500
[ 58.312261] RIP: 0010:[<ffffffff810e7ce8>] [<ffffffff810e7ce8>] shrink_dcache_for_umount_subtree+0x19b/0x27e
[ 58.312261] RSP: 0018:ffff88011bafde08 EFLAGS: 00010292
[ 58.312261] RAX: 000000000000006b RBX: ffff88011be58160 RCX: ffffffff81a2b070
[ 58.312261] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff81aa3fe8
[ 58.312261] RBP: ffff88011bafde38 R08: 0000000000000002 R09: 0000000000000000
[ 58.312261] R10: 0000000000000005 R11: 0000000000000000 R12: ffff88011be58160
[ 58.312261] R13: 0000000000000088 R14: ffff88011be824c0 R15: ffff88011bafdf18
[ 58.312261] FS: 00007f1348f7e740(0000) GS:ffff880100300000(0000) knlGS:0000000000000000
[ 58.312261] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 58.312261] CR2: 00007f1348642c40 CR3: 000000011ce86000 CR4: 00000000000406e0
[ 58.312261] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 58.312261] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 58.312261] Process umount (pid: 3007, threadinfo ffff88011bafc000, task ffff88011d88c640)
[ 58.312261] Stack:
[ 58.312261] ffff88010f7e9418 ffff88010f7e9248 ffff88010f7e9000 ffffffff816270b0
[ 58.312261] <0> ffff88010f7e9000 ffffffff81b08d28 ffff88011bafde58 ffffffff810e7e02
[ 58.312261] <0> ffffffff81a37ed0 ffff88010f7e9000 ffff88011bafde78 ffffffff810d8785
[ 58.312261] Call Trace:
[ 58.312261] [<ffffffff810e7e02>] shrink_dcache_for_umount+0x37/0x47
[ 58.312261] [<ffffffff810d8785>] generic_shutdown_super+0x1a/0xc9
[ 58.312261] [<ffffffff810d8856>] kill_block_super+0x22/0x3a
[ 58.312261] [<ffffffff810d8ff5>] deactivate_super+0x68/0x7f
[ 58.312261] [<ffffffff810eda94>] mntput_no_expire+0x10d/0x150
[ 58.312261] [<ffffffff810ee04c>] sys_umount+0x2be/0x2ed
[ 58.312261] [<ffffffff81062361>] ? trace_hardirqs_on_caller+0x16/0x13c
[ 58.312261] [<ffffffff8100252b>] system_call_fastpath+0x16/0x1b
[ 58.312261] Code: 0a 48 8b 4b 68 31 d2 48 85 f6 74 04 48 8b 56 40 48 05 18 04 00 00 48 89 de 48 89 04 24 48 c7 c7 48 b0 80 81 31 c0 e8 3e fa 47 00 <0f> 0b eb fe 4c 8b 63 58 4c 39 e3 75 05 45 31 e4 eb 05 f0 41 ff
[ 58.312261] RIP [<ffffffff810e7ce8>] shrink_dcache_for_umount_subtree+0x19b/0x27e
[ 58.312261] RSP <ffff88011bafde08>
[ 58.416414] ---[ end trace b3b044c2cf0d74d7 ]---
[ 63.548092] BUG: Dentry ffff88011f9ed430{i=4035,n=l} still in use (4) [unmount of ext4 dm-4]
[ 63.550998] ------------[ cut here ]------------
[ 63.551945] kernel BUG at fs/dcache.c:677!
[ 63.551945] invalid opcode: 0000 [#2] PREEMPT SMP
[ 63.551945] last sysfs file: /sys/devices/virtual/block/dm-10/dm/name
[ 63.551945] CPU 0
[ 63.551945] Pid: 3030, comm: umount Tainted: G D 2.6.33-rc7-mmotm0210 #1 0X564R/Latitude E6500
[ 63.551945] RIP: 0010:[<ffffffff810e7ce8>] [<ffffffff810e7ce8>] shrink_dcache_for_umount_subtree+0x19b/0x27e
[ 63.551945] RSP: 0018:ffff88011db73e08 EFLAGS: 00010292
[ 63.551945] RAX: 0000000000000066 RBX: ffff88011f9ed430 RCX: ffff88011db73cc8
[ 63.551945] RDX: ffffffff81bc9634 RSI: 0000000000000000 RDI: 0000000000000246
[ 63.551945] RBP: ffff88011db73e38 R08: 0000000000000002 R09: 0000000000000001
[ 63.551945] R10: 0000000000000000 R11: ffff88011fd8dd20 R12: ffff88011f9ed430
[ 63.551945] R13: 0000000000000008 R14: ffff88011874c230 R15: ffff88011db73f18
[ 63.551945] FS: 00007fad57558740(0000) GS:ffff880100200000(0000) knlGS:0000000000000000
[ 63.551945] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[ 63.551945] CR2: 00007fad56c1cc40 CR3: 000000011ba21000 CR4: 00000000000406f0
[ 63.551945] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 63.551945] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 63.551945] Process umount (pid: 3030, threadinfo ffff88011db72000, task ffff88011b90e240)
[ 63.551945] Stack:
[ 63.551945] ffff88011d0ee418 ffff88011d0ee248 ffff88011d0ee000 ffffffff816270b0
[ 63.551945] <0> ffff88011d0ee000 ffffffff81b08d28 ffff88011db73e58 ffffffff810e7e02
[ 63.551945] <0> ffffffff81a37ed0 ffff88011d0ee000 ffff88011db73e78 ffffffff810d8785
[ 63.551945] Call Trace:
[ 63.551945] [<ffffffff810e7e02>] shrink_dcache_for_umount+0x37/0x47
[ 63.551945] [<ffffffff810d8785>] generic_shutdown_super+0x1a/0xc9
[ 63.551945] [<ffffffff810d8856>] kill_block_super+0x22/0x3a
[ 63.551945] [<ffffffff810d8ff5>] deactivate_super+0x68/0x7f
[ 63.551945] [<ffffffff810eda94>] mntput_no_expire+0x10d/0x150
[ 63.551945] [<ffffffff810ee04c>] sys_umount+0x2be/0x2ed
[ 63.551945] [<ffffffff81062361>] ? trace_hardirqs_on_caller+0x16/0x13c
[ 63.551945] [<ffffffff8100252b>] system_call_fastpath+0x16/0x1b
[ 63.551945] Code: 0a 48 8b 4b 68 31 d2 48 85 f6 74 04 48 8b 56 40 48 05 18 04 00 00 48 89 de 48 89 04 24 48 c7 c7 48 b0 80 81 31 c0 e8 3e fa 47 00 <0f> 0b eb fe 4c 8b 63 58 4c 39 e3 75 05 45 31 e4 eb 05 f0 41 ff
[ 63.551945] RIP [<ffffffff810e7ce8>] shrink_dcache_for_umount_subtree+0x19b/0x27e
[ 63.551945] RSP <ffff88011db73e08>
[ 63.652212] ---[ end trace b3b044c2cf0d74d8 ]---
[ 68.758158] BUG: Dentry ffff88011fa2b290{i=4002,n=sbin} still in use (2) [unmount of ext4 dm-6]
[ 68.761221] ------------[ cut here ]------------
[ 68.762191] kernel BUG at fs/dcache.c:677!
[ 68.762191] invalid opcode: 0000 [#3] PREEMPT SMP
[ 68.762191] last sysfs file: /sys/devices/virtual/block/dm-10/dm/name
[ 68.762191] CPU 0
[ 68.774527] Pid: 3053, comm: umount Tainted: G D 2.6.33-rc7-mmotm0210 #1 0X564R/Latitude E6500
[ 68.774527] RIP: 0010:[<ffffffff810e7ce8>] [<ffffffff810e7ce8>] shrink_dcache_for_umount_subtree+0x19b/0x27e
[ 68.774527] RSP: 0018:ffff88010f78de08 EFLAGS: 00010292
[ 68.774527] RAX: 0000000000000069 RBX: ffff88011fa2b290 RCX: ffffffff81aaa848
[ 68.774527] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff81aa3fe8
[ 68.774527] RBP: ffff88010f78de38 R08: 0000000000000002 R09: 0000000000000000
[ 68.774527] R10: 000000011c699802 R11: 000000000000008d R12: ffff88011fa2b290
[ 68.774527] R13: 0000000000000070 R14: ffff88011be0e5f0 R15: ffff88010f78df18
[ 68.774527] FS: 00007ffcbc262740(0000) GS:ffff880100200000(0000) knlGS:0000000000000000
[ 68.774527] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 68.774527] CR2: 00007ffcbb926c40 CR3: 000000011d2ae000 CR4: 00000000000406f0
[ 68.774527] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 68.774527] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 68.774527] Process umount (pid: 3053, threadinfo ffff88010f78c000, task ffff88011d590ec0)
[ 68.774527] Stack:
[ 68.774527] ffff88011f666c18 ffff88011f666a48 ffff88011f666800 ffffffff816270b0
[ 68.774527] <0> ffff88011f666800 ffffffff81b08d28 ffff88010f78de58 ffffffff810e7e02
[ 68.774527] <0> ffffffff81a37ed0 ffff88011f666800 ffff88010f78de78 ffffffff810d8785
[ 68.774527] Call Trace:
[ 68.774527] [<ffffffff810e7e02>] shrink_dcache_for_umount+0x37/0x47
[ 68.774527] [<ffffffff810d8785>] generic_shutdown_super+0x1a/0xc9
[ 68.774527] [<ffffffff810d8856>] kill_block_super+0x22/0x3a
[ 68.774527] [<ffffffff810d8ff5>] deactivate_super+0x68/0x7f
[ 68.774527] [<ffffffff810eda94>] mntput_no_expire+0x10d/0x150
[ 68.774527] [<ffffffff810ee04c>] sys_umount+0x2be/0x2ed
[ 68.774527] [<ffffffff81062361>] ? trace_hardirqs_on_caller+0x16/0x13c
[ 68.774527] [<ffffffff8100252b>] system_call_fastpath+0x16/0x1b
[ 68.774527] Code: 0a 48 8b 4b 68 31 d2 48 85 f6 74 04 48 8b 56 40 48 05 18 04 00 00 48 89 de 48 89 04 24 48 c7 c7 48 b0 80 81 31 c0 e8 3e fa 47 00 <0f> 0b eb fe 4c 8b 63 58 4c 39 e3 75 05 45 31 e4 eb 05 f0 41 ff
[ 68.774527] RIP [<ffffffff810e7ce8>] shrink_dcache_for_umount_subtree+0x19b/0x27e
[ 68.774527] RSP <ffff88010f78de08>
[ 68.868765] ---[ end trace b3b044c2cf0d74d9 ]---
[ 74.422353] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[ 74.425558] sd 0:0:0:0: [sda] Stopping disk


Attachments:
(No filename) (227.00 B)

2010-02-12 03:14:53

by Andrew Morton

[permalink] [raw]
Subject: Re: mmotm 2010-02-10 - BUG at fs/dcache.c:677!

On Thu, 11 Feb 2010 21:44:17 -0500 [email protected] wrote:

> On Wed, 10 Feb 2010 16:17:41 PST, [email protected] said:
> > The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> Hit this at shutdown. ext4 filesystems. Brought it up to single-user
> mode, then 'shutdown -h now'.
>
> [ 58.311786] ------------[ cut here ]------------
> [ 58.312261] kernel BUG at fs/dcache.c:677!
> [ 58.312261] invalid opcode: 0000 [#1] PREEMPT SMP
> [ 58.312261] last sysfs file: /sys/devices/virtual/block/dm-10/dm/name
> [ 58.312261] CPU 1
> [ 58.312261] Pid: 3007, comm: umount Not tainted 2.6.33-rc7-mmotm0210 #1 0X564R/Latitude E6500
> [ 58.312261] RIP: 0010:[<ffffffff810e7ce8>] [<ffffffff810e7ce8>] shrink_dcache_for_umount_subtree+0x19b/0x27e
> [ 58.312261] RSP: 0018:ffff88011bafde08 EFLAGS: 00010292
> [ 58.312261] RAX: 000000000000006b RBX: ffff88011be58160 RCX: ffffffff81a2b070
> [ 58.312261] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff81aa3fe8
> [ 58.312261] RBP: ffff88011bafde38 R08: 0000000000000002 R09: 0000000000000000
> [ 58.312261] R10: 0000000000000005 R11: 0000000000000000 R12: ffff88011be58160
> [ 58.312261] R13: 0000000000000088 R14: ffff88011be824c0 R15: ffff88011bafdf18
> [ 58.312261] FS: 00007f1348f7e740(0000) GS:ffff880100300000(0000) knlGS:0000000000000000
> [ 58.312261] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 58.312261] CR2: 00007f1348642c40 CR3: 000000011ce86000 CR4: 00000000000406e0
> [ 58.312261] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [ 58.312261] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [ 58.312261] Process umount (pid: 3007, threadinfo ffff88011bafc000, task ffff88011d88c640)
> [ 58.312261] Stack:
> [ 58.312261] ffff88010f7e9418 ffff88010f7e9248 ffff88010f7e9000 ffffffff816270b0
> [ 58.312261] <0> ffff88010f7e9000 ffffffff81b08d28 ffff88011bafde58 ffffffff810e7e02
> [ 58.312261] <0> ffffffff81a37ed0 ffff88010f7e9000 ffff88011bafde78 ffffffff810d8785
> [ 58.312261] Call Trace:
> [ 58.312261] [<ffffffff810e7e02>] shrink_dcache_for_umount+0x37/0x47
> [ 58.312261] [<ffffffff810d8785>] generic_shutdown_super+0x1a/0xc9
> [ 58.312261] [<ffffffff810d8856>] kill_block_super+0x22/0x3a
> [ 58.312261] [<ffffffff810d8ff5>] deactivate_super+0x68/0x7f
> [ 58.312261] [<ffffffff810eda94>] mntput_no_expire+0x10d/0x150
> [ 58.312261] [<ffffffff810ee04c>] sys_umount+0x2be/0x2ed
> [ 58.312261] [<ffffffff81062361>] ? trace_hardirqs_on_caller+0x16/0x13c
> [ 58.312261] [<ffffffff8100252b>] system_call_fastpath+0x16/0x1b
> [ 58.312261] Code: 0a 48 8b 4b 68 31 d2 48 85 f6 74 04 48 8b 56 40 48 05 18 04 00 00 48 89 de 48 89 04 24 48 c7 c7 48 b0 80 81 31 c0 e8 3e fa 47 00 <0f> 0b eb fe 4c 8b 63 58 4c 39 e3 75 05 45 31 e4 eb 05 f0 41 ff
> [ 58.312261] RIP [<ffffffff810e7ce8>] shrink_dcache_for_umount_subtree+0x19b/0x27e

Yeah, Sachin reported that against linux-next too (I think - need to
check the exact line numbers):
http://permalink.gmane.org/gmane.linux.file-systems/38148

It seems to have been met with shrugs thus far.

2010-02-12 04:52:36

by Junichi Nomura

[permalink] [raw]
Subject: Re: mmotm 2010-02-10 - BUG at fs/dcache.c:677!

(02/12/10 12:14), Andrew Morton wrote:
> On Thu, 11 Feb 2010 21:44:17 -0500 [email protected] wrote:
>
>> On Wed, 10 Feb 2010 16:17:41 PST, [email protected] said:
>>> The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
>>>
>>> http://userweb.kernel.org/~akpm/mmotm/
>>
>> Hit this at shutdown. ext4 filesystems. Brought it up to single-user
>> mode, then 'shutdown -h now'.
>>
>> [ 58.311786] ------------[ cut here ]------------
>> [ 58.312261] kernel BUG at fs/dcache.c:677!
...

> Yeah, Sachin reported that against linux-next too (I think - need to
> check the exact line numbers):
> http://permalink.gmane.org/gmane.linux.file-systems/38148
>
> It seems to have been met with shrugs thus far.

According to the Sachin's report:
> While running hackbench against today's next-20100208 (9056d31..)
> on a s390 box, came across following BUG.
...
> Did not observe this with next-20100205. Also there doesn't seem to be
> any patches applied to this code after the last release. So not
> sure what could have caused this. Corresponding code is :

So the bug seems introduced between next-20100205 and next-20100208.

Isn't this change missing the equivalent of "dput(old)"?

In patch-v2.6.33-rc7-next-20100208:
> diff --git a/fs/namei.c b/fs/namei.c
> index 94a5e60..a056dad 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -689,33 +689,17 @@ static __always_inline void follow_dotdot(struct nameidata *nd)
...
> - spin_lock(&dcache_lock);
> if (nd->path.dentry != nd->path.mnt->mnt_root) {
> - nd->path.dentry = dget(nd->path.dentry->d_parent);
> - spin_unlock(&dcache_lock);
> - dput(old);
> + /* rare case of legitimate dget_parent()... */
> + nd->path.dentry = dget_parent(nd->path.dentry);
> break;
> }

--
Jun'ichi Nomura, NEC Corporation

2010-02-12 05:01:14

by Al Viro

[permalink] [raw]
Subject: Re: mmotm 2010-02-10 - BUG at fs/dcache.c:677!

On Fri, Feb 12, 2010 at 01:51:12PM +0900, Jun'ichi Nomura wrote:
> (02/12/10 12:14), Andrew Morton wrote:
> > On Thu, 11 Feb 2010 21:44:17 -0500 [email protected] wrote:
> >
> >> On Wed, 10 Feb 2010 16:17:41 PST, [email protected] said:
> >>> The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
> >>>
> >>> http://userweb.kernel.org/~akpm/mmotm/
> >>
> >> Hit this at shutdown. ext4 filesystems. Brought it up to single-user
> >> mode, then 'shutdown -h now'.
> >>
> >> [ 58.311786] ------------[ cut here ]------------
> >> [ 58.312261] kernel BUG at fs/dcache.c:677!
> ...
>
> > Yeah, Sachin reported that against linux-next too (I think - need to
> > check the exact line numbers):
> > http://permalink.gmane.org/gmane.linux.file-systems/38148
> >
> > It seems to have been met with shrugs thus far.
>
> According to the Sachin's report:
> > While running hackbench against today's next-20100208 (9056d31..)
> > on a s390 box, came across following BUG.
> ...
> > Did not observe this with next-20100205. Also there doesn't seem to be
> > any patches applied to this code after the last release. So not
> > sure what could have caused this. Corresponding code is :
>
> So the bug seems introduced between next-20100205 and next-20100208.
>
> Isn't this change missing the equivalent of "dput(old)"?

Argh... Nice catch, and yes, it is.

2010-02-12 05:07:10

by Al Viro

[permalink] [raw]
Subject: Re: mmotm 2010-02-10 - BUG at fs/dcache.c:677!

On Fri, Feb 12, 2010 at 05:01:04AM +0000, Al Viro wrote:

> > So the bug seems introduced between next-20100205 and next-20100208.
> >
> > Isn't this change missing the equivalent of "dput(old)"?
>
> Argh... Nice catch, and yes, it is.

Fixed, pushed to hera, should propagate to git.kernel.org shortly.

2010-02-12 05:30:53

by Stephen Rothwell

[permalink] [raw]
Subject: Re: mmotm 2010-02-10 - BUG at fs/dcache.c:677!

Hi all,

On Fri, 12 Feb 2010 13:51:12 +0900 "Jun'ichi Nomura" <[email protected]> wrote:
>
> So the bug seems introduced between next-20100205 and next-20100208.
>
> Isn't this change missing the equivalent of "dput(old)"?
>
> In patch-v2.6.33-rc7-next-20100208:
> > diff --git a/fs/namei.c b/fs/namei.c
> > index 94a5e60..a056dad 100644
> > --- a/fs/namei.c
> > +++ b/fs/namei.c
> > @@ -689,33 +689,17 @@ static __always_inline void follow_dotdot(struct nameidata *nd)
> ...
> > - spin_lock(&dcache_lock);
> > if (nd->path.dentry != nd->path.mnt->mnt_root) {
> > - nd->path.dentry = dget(nd->path.dentry->d_parent);
> > - spin_unlock(&dcache_lock);
> > - dput(old);
> > + /* rare case of legitimate dget_parent()... */
> > + nd->path.dentry = dget_parent(nd->path.dentry);
> > break;
> > }

That is part of commit 12578f932a8ad5f01bbf957d9c941760ef0dc575 ("Clean
follow_dotdot() up a bit") from the vfs tree.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


Attachments:
(No filename) (1.17 kB)
(No filename) (198.00 B)
Download all attachments