2021-09-21 11:14:27

by Xiongwei Song

Subject: [PATCH 0/2] Use generic code for virtual address of randomization of x86

From: Xiongwei Song <[email protected]>

Hello,

The two patches are to use generic code for randomization of virtual
address of x86. Since the basic code logic of x86 is same as generic
code, so no need to implement these functions on x86, please see the
details in comments of patch 2.

Please review it.

Cc: Thomas Gleixner <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: Andy Lutomirski <[email protected]>
Cc: Gabriel Krisman Bertazi <[email protected]>
Cc: "Chang S. Bae" <[email protected]>
Cc: Al Viro <[email protected]>
Cc: Arvind Sankar <[email protected]>
Cc: Alexey Dobriyan <[email protected]>
Cc: Oleg Nesterov <[email protected]>
Cc: Balbir Singh <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Lai Jiangshan <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Kim Phillips <[email protected]>
Cc: Yazen Ghannam <[email protected]>
Cc: Davidlohr Bueso <[email protected]>
Cc: Stefan Metzmacher <[email protected]>
Cc: Marco Elver <[email protected]>
Cc: "Eric W. Biederman" <[email protected]>
Cc: Christophe Leroy <[email protected]>
Cc: [email protected]

Xiongwei Song (2):
x86: Rename TIF_ADDR32 to TIF_32BIT
x86/mm: Randomize va with generic arch_pick_mmap_layout()

arch/x86/Kconfig | 2 +-
arch/x86/include/asm/compat.h | 7 +-
arch/x86/include/asm/elf.h | 2 +-
arch/x86/include/asm/page_64_types.h | 6 +-
arch/x86/include/asm/processor.h | 4 +-
arch/x86/include/asm/thread_info.h | 4 +-
arch/x86/kernel/process.c | 5 --
arch/x86/kernel/process_64.c | 4 +-
arch/x86/mm/mmap.c | 112 ---------------------------
include/linux/compat.h | 4 +
mm/util.c | 18 ++++-
11 files changed, 37 insertions(+), 131 deletions(-)

--
2.30.2

2021-09-21 13:28:34

by Kees Cook

Subject: Re: [PATCH 0/2] Use generic code for virtual address of randomization of x86

On September 21, 2021 4:02:50 AM PDT, [email protected] wrote:
>From: Xiongwei Song <[email protected]>
>
>Hello,
>
>The two patches are to use generic code for randomization of virtual
>address of x86. Since the basic code logic of x86 is same as generic
>code, so no need to implement these functions on x86, please see the
>details in comments of patch 2.

Hi!

The other patches do not seem to have arrived; I only see 0/2.

-Kees

>
>Please review it.
>
>Cc: Thomas Gleixner <[email protected]>
>Cc: Ingo Molnar <[email protected]>
>Cc: Borislav Petkov <[email protected]>
>Cc: "H. Peter Anvin" <[email protected]>
>Cc: Andy Lutomirski <[email protected]>
>Cc: Gabriel Krisman Bertazi <[email protected]>
>Cc: "Chang S. Bae" <[email protected]>
>Cc: Al Viro <[email protected]>
>Cc: Arvind Sankar <[email protected]>
>Cc: Alexey Dobriyan <[email protected]>
>Cc: Oleg Nesterov <[email protected]>
>Cc: Balbir Singh <[email protected]>
>Cc: Jens Axboe <[email protected]>
>Cc: Lai Jiangshan <[email protected]>
>Cc: Dave Hansen <[email protected]>
>Cc: Peter Zijlstra <[email protected]>
>Cc: Andrew Morton <[email protected]>
>Cc: Arnd Bergmann <[email protected]>
>Cc: "David S. Miller" <[email protected]>
>Cc: Kees Cook <[email protected]>
>Cc: Kim Phillips <[email protected]>
>Cc: Yazen Ghannam <[email protected]>
>Cc: Davidlohr Bueso <[email protected]>
>Cc: Stefan Metzmacher <[email protected]>
>Cc: Marco Elver <[email protected]>
>Cc: "Eric W. Biederman" <[email protected]>
>Cc: Christophe Leroy <[email protected]>
>Cc: [email protected]
>
>Xiongwei Song (2):
> x86: Rename TIF_ADDR32 to TIF_32BIT
> x86/mm: Randomize va with generic arch_pick_mmap_layout()
>
> arch/x86/Kconfig | 2 +-
> arch/x86/include/asm/compat.h | 7 +-
> arch/x86/include/asm/elf.h | 2 +-
> arch/x86/include/asm/page_64_types.h | 6 +-
> arch/x86/include/asm/processor.h | 4 +-
> arch/x86/include/asm/thread_info.h | 4 +-
> arch/x86/kernel/process.c | 5 --
> arch/x86/kernel/process_64.c | 4 +-
> arch/x86/mm/mmap.c | 112 ---------------------------
> include/linux/compat.h | 4 +
> mm/util.c | 18 ++++-
> 11 files changed, 37 insertions(+), 131 deletions(-)
>

2021-09-21 14:12:46

by Xiongwei Song

Subject: Re: [PATCH 0/2] Use generic code for virtual address of randomization of x86

> On Sep 21, 2021, at 9:24 PM, Kees Cook <[email protected]> wrote:
>
>
>
> On September 21, 2021 4:02:50 AM PDT, [email protected] wrote:
>> From: Xiongwei Song <[email protected]>
>>
>> Hello,
>>
>> The two patches are to use generic code for randomization of virtual
>> address of x86. Since the basic code logic of x86 is same as generic
>> code, so no need to implement these functions on x86, please see the
>> details in comments of patch 2.
>
> Hi!
>
> The other patches do not seem to have arrived; I only see 0/2.

Sorry for that. Let me resend the patches.

Regards,
Xiongwei

2021-09-21 14:29:11

by Peter Zijlstra

Subject: Re: [PATCH 0/2] Use generic code for virtual address of randomization of x86

On Tue, Sep 21, 2021 at 06:24:07AM -0700, Kees Cook wrote:
>
>
> On September 21, 2021 4:02:50 AM PDT, [email protected] wrote:
> >From: Xiongwei Song <[email protected]>
> >
> >Hello,
> >
> >The two patches are to use generic code for randomization of virtual
> >address of x86. Since the basic code logic of x86 is same as generic
> >code, so no need to implement these functions on x86, please see the
> >details in comments of patch 2.
>
> Hi!
>
> The other patches do not seem to have arrived; I only see 0/2.

They were only sent to the list for some weird raisin. Operator error
perhaps.