2024-03-18 16:17:37

by Nathan Morrisson

[permalink] [raw]
Subject: [PATCH 0/2] Add POWERTIP PH128800T006-ZHC01 panel

Add the device tree bindings, timings, and compatible string for the
POWERTIP PH128800T006-ZHC01 panel.

Nathan Morrisson (2):
dt-bindings: display: simple: Add POWERTIP PH128800T-006-ZHC01 panel
drm/panel: simple: Add POWERTIP PH128800T006-ZHC01 panel entry

.../bindings/display/panel/panel-simple.yaml | 2 ++
drivers/gpu/drm/panel/panel-simple.c | 29 +++++++++++++++++++
2 files changed, 31 insertions(+)

--
2.25.1



2024-03-18 16:17:49

by Nathan Morrisson

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: display: simple: Add POWERTIP PH128800T-006-ZHC01 panel

Add POWERTIP PH128800T-006-ZHC01 10.1" LCD-TFT LVDS panel compatible
string.

Signed-off-by: Nathan Morrisson <[email protected]>
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index a95445f40870..312e760d7225 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -272,6 +272,8 @@ properties:
- osddisplays,osd070t1718-19ts
# One Stop Displays OSD101T2045-53TS 10.1" 1920x1200 panel
- osddisplays,osd101t2045-53ts
+ # POWERTIP PH128800T006-ZHC01 10.1" WXGA TFT LCD panel
+ - powertip,ph128800t006-zhc01
# POWERTIP PH800480T013-IDF2 7.0" WVGA TFT LCD panel
- powertip,ph800480t013-idf02
# QiaoDian XianShi Corporation 4"3 TFT LCD panel
--
2.25.1


2024-03-18 16:19:43

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: display: simple: Add POWERTIP PH128800T-006-ZHC01 panel

On 18/03/2024 17:17, Nathan Morrisson wrote:
> Add POWERTIP PH128800T-006-ZHC01 10.1" LCD-TFT LVDS panel compatible
> string.
>
> Signed-off-by: Nathan Morrisson <[email protected]>
> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2024-03-18 16:41:56

by Nathan Morrisson

[permalink] [raw]
Subject: [PATCH 2/2] drm/panel: simple: Add POWERTIP PH128800T006-ZHC01 panel entry

Add support for the POWERTIP PH128800T006-ZHC01 10.1" (1280x800)
LCD-TFT panel.

Signed-off-by: Nathan Morrisson <[email protected]>
---
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 20e3df1c59d4..02d238123753 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -3465,6 +3465,32 @@ static const struct panel_desc pda_91_00156_a0 = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
};

+static const struct drm_display_mode powertip_ph128800t006_zhc01_mode = {
+ .clock = 66500,
+ .hdisplay = 1280,
+ .hsync_start = 1280 + 12,
+ .hsync_end = 1280 + 12 + 20,
+ .htotal = 1280 + 12 + 20 + 56,
+ .vdisplay = 800,
+ .vsync_start = 800 + 1,
+ .vsync_end = 800 + 1 + 3,
+ .vtotal = 800 + 1 + 3 + 20,
+ .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc powertip_ph128800t006_zhc01 = {
+ .modes = &powertip_ph128800t006_zhc01_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 216,
+ .height = 135,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
+ .connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
static const struct drm_display_mode powertip_ph800480t013_idf02_mode = {
.clock = 24750,
.hdisplay = 800,
@@ -4639,6 +4665,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "pda,91-00156-a0",
.data = &pda_91_00156_a0,
+ }, {
+ .compatible = "powertip,ph128800t006-zhc01",
+ .data = &powertip_ph128800t006_zhc01,
}, {
.compatible = "powertip,ph800480t013-idf02",
.data = &powertip_ph800480t013_idf02,
--
2.25.1


2024-03-18 21:21:56

by Jessica Zhang

[permalink] [raw]
Subject: Re: [PATCH 2/2] drm/panel: simple: Add POWERTIP PH128800T006-ZHC01 panel entry



On 3/18/2024 9:17 AM, Nathan Morrisson wrote:
> Add support for the POWERTIP PH128800T006-ZHC01 10.1" (1280x800)
> LCD-TFT panel.
>
> Signed-off-by: Nathan Morrisson <[email protected]>

Hi Nathan,

Acked-by: Jessica Zhang <[email protected]>

Thanks,

Jessica Zhang

> ---
> drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 20e3df1c59d4..02d238123753 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3465,6 +3465,32 @@ static const struct panel_desc pda_91_00156_a0 = {
> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> };
>
> +static const struct drm_display_mode powertip_ph128800t006_zhc01_mode = {
> + .clock = 66500,
> + .hdisplay = 1280,
> + .hsync_start = 1280 + 12,
> + .hsync_end = 1280 + 12 + 20,
> + .htotal = 1280 + 12 + 20 + 56,
> + .vdisplay = 800,
> + .vsync_start = 800 + 1,
> + .vsync_end = 800 + 1 + 3,
> + .vtotal = 800 + 1 + 3 + 20,
> + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> +};
> +
> +static const struct panel_desc powertip_ph128800t006_zhc01 = {
> + .modes = &powertip_ph128800t006_zhc01_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 216,
> + .height = 135,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> + .connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
> static const struct drm_display_mode powertip_ph800480t013_idf02_mode = {
> .clock = 24750,
> .hdisplay = 800,
> @@ -4639,6 +4665,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "pda,91-00156-a0",
> .data = &pda_91_00156_a0,
> + }, {
> + .compatible = "powertip,ph128800t006-zhc01",
> + .data = &powertip_ph128800t006_zhc01,
> }, {
> .compatible = "powertip,ph800480t013-idf02",
> .data = &powertip_ph800480t013_idf02,
> --
> 2.25.1
>

2024-03-19 15:52:13

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 0/2] Add POWERTIP PH128800T006-ZHC01 panel

Hi,

On Mon, 18 Mar 2024 09:17:06 -0700, Nathan Morrisson wrote:
> Add the device tree bindings, timings, and compatible string for the
> POWERTIP PH128800T006-ZHC01 panel.
>
> Nathan Morrisson (2):
> dt-bindings: display: simple: Add POWERTIP PH128800T-006-ZHC01 panel
> drm/panel: simple: Add POWERTIP PH128800T006-ZHC01 panel entry
>
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/2] dt-bindings: display: simple: Add POWERTIP PH128800T-006-ZHC01 panel
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/3b2304cfeddd141523cb50cc1a3ba7624b865011
[2/2] drm/panel: simple: Add POWERTIP PH128800T006-ZHC01 panel entry
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/fd6aa8f2dcb7236e511c1a58d82c2a178170e6ff

--
Neil