2022-08-15 23:14:29

by Xin Gao

Subject: [PATCH] m68k: Complete variable type

Complete the variable type of line 109.

Signed-off-by: Xin Gao <[email protected]>
---
arch/m68k/coldfire/m520x.c | 2 +-
arch/m68k/q40/q40ints.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/m68k/coldfire/m520x.c b/arch/m68k/coldfire/m520x.c
index d2f96b40aee1..dca89214bbc6 100644
--- a/arch/m68k/coldfire/m520x.c
+++ b/arch/m68k/coldfire/m520x.c
@@ -106,7 +106,7 @@ static struct clk * const disable_clks[] __initconst = {

static void __init m520x_clk_init(void)
{
- unsigned i;
+ unsigned int i;

/* make sure these clocks are enabled */
for (i = 0; i < ARRAY_SIZE(enable_clks); ++i)
diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
index 100c05544c6a..fdac8a0cb75f 100644
--- a/arch/m68k/q40/q40ints.c
+++ b/arch/m68k/q40/q40ints.c
@@ -169,7 +169,7 @@ void q40_sched_init (void)
*
*/

-struct IRQ_TABLE{ unsigned int mask; int irq ;};
+struct IRQ_TABLE{ unsigned int mask; int irq };
#if 0
static struct IRQ_TABLE iirqs[]={
{Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
--
2.30.2

2022-08-16 06:30:12

by Greg Ungerer

Subject: Re: [PATCH] m68k: Complete variable type

On 16/8/22 05:48, Xin Gao wrote:
> Complete the variable type of line 109.
>
> Signed-off-by: Xin Gao <[email protected]>
> ---
> arch/m68k/coldfire/m520x.c | 2 +-
> arch/m68k/q40/q40ints.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/m68k/coldfire/m520x.c b/arch/m68k/coldfire/m520x.c
> index d2f96b40aee1..dca89214bbc6 100644
> --- a/arch/m68k/coldfire/m520x.c
> +++ b/arch/m68k/coldfire/m520x.c
> @@ -106,7 +106,7 @@ static struct clk * const disable_clks[] __initconst = {
>
> static void __init m520x_clk_init(void)
> {
> - unsigned i;
> + unsigned int i;
>
> /* make sure these clocks are enabled */
> for (i = 0; i < ARRAY_SIZE(enable_clks); ++i)
> diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
> index 100c05544c6a..fdac8a0cb75f 100644
> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -169,7 +169,7 @@ void q40_sched_init (void)
> *
> */
>
> -struct IRQ_TABLE{ unsigned int mask; int irq ;};
> +struct IRQ_TABLE{ unsigned int mask; int irq };
> #if 0
> static struct IRQ_TABLE iirqs[]={
> {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},

This last change doesn't match the commit message.
It should be a separate patch.

Regards
Greg

2022-08-16 08:43:21

by Al Viro

Subject: Re: [PATCH] m68k: Complete variable type

On Tue, Aug 16, 2022 at 09:37:19AM +1000, Greg Ungerer wrote:
> On 16/8/22 05:48, Xin Gao wrote:
> > @@ -169,7 +169,7 @@ void q40_sched_init (void)
> > *
> > */
> > -struct IRQ_TABLE{ unsigned int mask; int irq ;};
> > +struct IRQ_TABLE{ unsigned int mask; int irq };
> > #if 0
> > static struct IRQ_TABLE iirqs[]={
> > {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
>
> This last change doesn't match the commit message.
> It should be a separate patch.

The last change is not a valid C. Never had been.
In C semicolon is *NOT* a separator - it's a part of declaration.

--
improve the kernel quality - git rm scripts/checkpatch.pl