2016-10-10 13:01:45

by Richard Leitner

[permalink] [raw]
Subject: Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls


On 09/09/2016 12:17 PM, Mark Brown wrote:
> On Fri, Sep 09, 2016 at 09:46:45AM +0200, Richard Leitner wrote:
>> Hi,
>> any comments, updates or ideas for improvement on that patch?
>>
>> On Wed, 31 Aug 2016 09:26:31 +0200
>> Richard Leitner <[email protected]> wrote:
>
> Please don't top post, reply in line with needed context. This allows
> readers to readily follow the flow of conversation and understand what
> you are talking about and also helps ensure that everything in the
> discussion is being addressed.

Ok, thanks for that hint. I'm pretty new to this, therefore I hope I'll
get everything right from now on.


>
> Please don't send content free pings and please allow a reasonable time
> for review. People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review. If there have been
> review comments then people may be waiting for those to be addressed.
> Sending content free pings just adds to the mail volume (if they are
> seen at all) and if something has gone wrong you'll have to resend the
> patches anyway.
>

So it's been a month now, is this a reasonable time to ping?

Although it's a pretty small change I don't want it to get lost...

regards,
Richard


2016-10-10 14:55:24

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

On Mon, Oct 10, 2016 at 02:52:38PM +0200, Richard Leitner wrote:
> On 09/09/2016 12:17 PM, Mark Brown wrote:

> > Please don't send content free pings and please allow a reasonable time
> > for review. People get busy, go on holiday, attend conferences and so
> > on so unless there is some reason for urgency (like critical bug fixes)
> > please allow at least a couple of weeks for review. If there have been
> > review comments then people may be waiting for those to be addressed.
> > Sending content free pings just adds to the mail volume (if they are
> > seen at all) and if something has gone wrong you'll have to resend the
> > patches anyway.

> So it's been a month now, is this a reasonable time to ping?

To repeat please don't send content free pings at all for the reasons
explained above.


Attachments:
(No filename) (807.00 B)
signature.asc (455.00 B)
Download all attachments