2017-08-13 11:23:39

by Arvind Yadav

Subject: [PATCH] ACPI / PMIC: constify platform_device_id

platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
index 85636d7..813b829 100644
--- a/drivers/acpi/pmic/intel_pmic_chtwc.c
+++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
@@ -260,7 +260,7 @@ static int intel_cht_wc_pmic_opregion_probe(struct platform_device *pdev)
&intel_cht_wc_pmic_opregion_data);
}

-static struct platform_device_id cht_wc_opregion_id_table[] = {
+static const struct platform_device_id cht_wc_opregion_id_table[] = {
{ .name = "cht_wcove_region" },
{},
};
--
2.7.4

2017-08-13 11:47:38

by Hans de Goede

Subject: Re: [PATCH] ACPI / PMIC: constify platform_device_id

Hi,

On 13-08-17 13:23, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Good catch:

Acked-by: Hans de Goede <[email protected]>

Regards,

Hans



> ---
> drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
> index 85636d7..813b829 100644
> --- a/drivers/acpi/pmic/intel_pmic_chtwc.c
> +++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
> @@ -260,7 +260,7 @@ static int intel_cht_wc_pmic_opregion_probe(struct platform_device *pdev)
> &intel_cht_wc_pmic_opregion_data);
> }
>
> -static struct platform_device_id cht_wc_opregion_id_table[] = {
> +static const struct platform_device_id cht_wc_opregion_id_table[] = {
> { .name = "cht_wcove_region" },
> {},
> };
>