2019-10-27 17:51:09

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH] net: wireless: realtek: rtlwifi: rtl8192c:Drop condition with no effect

On 10/27/19 1:23 AM, Saurav Girepunje wrote:
> As the "else if" and "else" branch body are identical the condition
> has no effect. So drop the "else if" condition.
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---

The patch is OK; however, the subject should be: rtlwifi: rtl8192c-common: Drop ...

We do not use the directory tree in the subject. By convention, it is the driver
directory and the driver name. It is common for the driver name to match that of
the top-level directory, but not in this case.

Thanks,

Larry