2022-05-05 17:42:03

by Oliver Neukum

[permalink] [raw]
Subject: Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.



On 05.05.22 12:14, [email protected] wrote:
> From: Monish Kumar R <[email protected]>
>
> Signed-off-by: Monish Kumar R <[email protected]>
> ---
> drivers/usb/core/quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 97b44a68668a..257ac37464e8 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>
> /* INTEL VALUE SSD */
> { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>
> + /*DELL USB GEN2 */
> + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM },
> + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME },
>
>

Hi,

could you please

1) keep the list in nummerical order from lowest device ID to largest
2) combine both quirks with a binary OR
3) provide a short reason for this patch like "found in own testing" or
"reported on list"

    Regards
        Oliver