2017-11-06 15:53:18

by Egil Hjelmeland

Subject: [PATCH net-next] net: dsa: lan9303: Drop port range check

Now that ds->num_ports is 3, there is no need to check range of "port"
parameter.

Signed-off-by: Egil Hjelmeland <[email protected]>
---
drivers/net/dsa/lan9303-core.c | 27 ++++-----------------------
1 file changed, 4 insertions(+), 23 deletions(-)

diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
index 70ecd18a5e7d..320651a57c6f 100644
--- a/drivers/net/dsa/lan9303-core.c
+++ b/drivers/net/dsa/lan9303-core.c
@@ -1057,17 +1057,7 @@ static int lan9303_port_enable(struct dsa_switch *ds, int port,
{
struct lan9303 *chip = ds->priv;

- /* enable internal packet processing */
- switch (port) {
- case 1:
- case 2:
- return lan9303_enable_processing_port(chip, port);
- default:
- dev_dbg(chip->dev,
- "Error: request to power up invalid port %d\n", port);
- }
-
- return -ENODEV;
+ return lan9303_enable_processing_port(chip, port);
}

static void lan9303_port_disable(struct dsa_switch *ds, int port,
@@ -1075,18 +1065,9 @@ static void lan9303_port_disable(struct dsa_switch *ds, int port,
{
struct lan9303 *chip = ds->priv;

- /* disable internal packet processing */
- switch (port) {
- case 1:
- case 2:
- lan9303_disable_processing_port(chip, port);
- lan9303_phy_write(ds, chip->phy_addr_sel_strap + port,
- MII_BMCR, BMCR_PDOWN);
- break;
- default:
- dev_dbg(chip->dev,
- "Error: request to power down invalid port %d\n", port);
- }
+ lan9303_disable_processing_port(chip, port);
+ lan9303_phy_write(ds, chip->phy_addr_sel_strap + port,
+ MII_BMCR, BMCR_PDOWN);
}

static int lan9303_port_bridge_join(struct dsa_switch *ds, int port,
--
2.11.0


From 1583328319104875843@xxx Mon Nov 06 14:45:52 +0000 2017
X-GM-THRID: 1583328319104875843
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread

2017-11-06 14:45:52

by Egil Hjelmeland

Subject: Re: [PATCH net-next] net: dsa: lan9303: Drop port range check

On 06. nov. 2017 15:19, Egil Hjelmeland wrote:
> Now that ds->num_ports is 3, there is no need to check range of "port"
> parameter.
>
> + lan9303_disable_processing_port(chip, port);
> + lan9303_phy_write(ds, chip->phy_addr_sel_strap + port,
> + MII_BMCR, BMCR_PDOWN);
> }

I see now that line breaking could be adjusted here. But I am going to
touch that line in a upcomming patch about phy_addr_sel_strap. I
promise fix it then, making it to a one-liner.

>
> static int lan9303_port_bridge_join(struct dsa_switch *ds, int port,
>

Egil

From 1584806846272338147@xxx Wed Nov 22 22:26:25 +0000 2017
X-GM-THRID: 1584806846272338147
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread