2021-12-17 07:41:13

by Ye Xiang

Subject: [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL

Specify that both TGL and ADL don't support DMA cache snooping.

Signed-off-by: Ye Xiang <[email protected]>
---
drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
index 45e0c7b1c9ec..8ccb246b0114 100644
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct ishtp_device *dev, int length,
*/
static bool _dma_no_cache_snooping(struct ishtp_device *dev)
{
- return dev->pdev->device == EHL_Ax_DEVICE_ID;
+ return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
+ dev->pdev->device == TGL_LP_DEVICE_ID ||
+ dev->pdev->device == TGL_H_DEVICE_ID ||
+ dev->pdev->device == ADL_S_DEVICE_ID ||
+ dev->pdev->device == ADL_P_DEVICE_ID);
}

static const struct ishtp_hw_ops ish_hw_ops = {
--
2.17.1

2021-12-17 12:33:10

by Srinivas Pandruvada

Subject: Re: [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL

On Fri, 2021-12-17 at 15:45 +0800, Ye Xiang wrote:
> Specify that both TGL and ADL don't support DMA cache snooping.
>
> Signed-off-by: Ye Xiang <[email protected]>
Acked-by: Srinivas Pandruvada <[email protected]>

> ---
>  drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-
> ish-hid/ipc/ipc.c
> index 45e0c7b1c9ec..8ccb246b0114 100644
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct
> ishtp_device *dev, int length,
>   */
>  static bool _dma_no_cache_snooping(struct ishtp_device *dev)
>  {
> -       return dev->pdev->device == EHL_Ax_DEVICE_ID;
> +       return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
> +               dev->pdev->device == TGL_LP_DEVICE_ID ||
> +               dev->pdev->device == TGL_H_DEVICE_ID ||
> +               dev->pdev->device == ADL_S_DEVICE_ID ||
> +               dev->pdev->device == ADL_P_DEVICE_ID);
>  }
>  
>  static const struct ishtp_hw_ops ish_hw_ops = {

2022-01-06 13:19:04

by Jiri Kosina

Subject: Re: [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL

On Fri, 17 Dec 2021, Ye Xiang wrote:

> Specify that both TGL and ADL don't support DMA cache snooping.
>
> Signed-off-by: Ye Xiang <[email protected]>
> ---
> drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
> index 45e0c7b1c9ec..8ccb246b0114 100644
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct ishtp_device *dev, int length,
> */
> static bool _dma_no_cache_snooping(struct ishtp_device *dev)
> {
> - return dev->pdev->device == EHL_Ax_DEVICE_ID;
> + return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
> + dev->pdev->device == TGL_LP_DEVICE_ID ||
> + dev->pdev->device == TGL_H_DEVICE_ID ||
> + dev->pdev->device == ADL_S_DEVICE_ID ||
> + dev->pdev->device == ADL_P_DEVICE_ID);
> }

Applied, thank you.

--
Jiri Kosina
SUSE Labs