I was playing with checkpatch.pl ;) .. I made a list of style offenders
inside the arch/x86/ sub-directory. I thought it might be helpful to
prioritize any style clean ups that people might want to do for x86 ..
OTOH some of these might show imperfections in checkpatch.pl .. Either
way I thought it was interesting to review ..
These are sorted by errors, then warnings.. I only included the first
hundred files which includes about the top %30 of the list .. The
kprobes_64.c error rate is a little miss-leading because several errors
are found on a single line ..
./arch/x86/math-emu/fpu_trig.c
total: 649 errors, 11 warnings, 1845 lines checked
./arch/x86/kernel/kprobes_64.c
total: 528 errors, 9 warnings, 749 lines checked
./arch/x86/math-emu/reg_ld_str.c
total: 392 errors, 17 warnings, 1375 lines checked
./arch/x86/kernel/kprobes_32.c
total: 271 errors, 8 warnings, 756 lines checked
./arch/x86/math-emu/errors.c
total: 214 errors, 28 warnings, 739 lines checked
./arch/x86/kernel/i387_32.c
total: 203 errors, 10 warnings, 544 lines checked
./arch/x86/mach-voyager/voyager_cat.c
total: 200 errors, 81 warnings, 1180 lines checked
./arch/x86/kernel/pci-gart_64.c
total: 187 errors, 15 warnings, 748 lines checked
./arch/x86/math-emu/fpu_entry.c
total: 168 errors, 12 warnings, 761 lines checked
./arch/x86/mach-voyager/voyager_smp.c
total: 162 errors, 59 warnings, 1953 lines checked
./arch/x86/kernel/cpu/centaur.c
total: 152 errors, 11 warnings, 471 lines checked
./arch/x86/kernel/process_64.c
total: 119 errors, 21 warnings, 905 lines checked
./arch/x86/kernel/aperture_64.c
total: 114 errors, 18 warnings, 299 lines checked
./arch/x86/crypto/aes_32.c
total: 113 errors, 0 warnings, 515 lines checked
./arch/x86/kernel/traps_64.c
total: 112 errors, 26 warnings, 1145 lines checked
./arch/x86/math-emu/reg_compare.c
total: 107 errors, 0 warnings, 381 lines checked
./arch/x86/math-emu/reg_add_sub.c
total: 104 errors, 2 warnings, 374 lines checked
./arch/x86/kernel/io_apic_32.c
total: 97 errors, 70 warnings, 2890 lines checked
./arch/x86/ia32/ia32_signal.c
total: 96 errors, 11 warnings, 617 lines checked
./arch/x86/math-emu/get_address.c
total: 93 errors, 0 warnings, 438 lines checked
./arch/x86/kernel/traps_32.c
total: 91 errors, 22 warnings, 1223 lines checked
./arch/x86/ia32/sys_ia32.c
total: 87 errors, 79 warnings, 889 lines checked
./arch/x86/oprofile/op_model_p4.c
total: 86 errors, 10 warnings, 722 lines checked
./arch/x86/ia32/ptrace32.c
total: 81 errors, 8 warnings, 404 lines checked
./arch/x86/kernel/e820_64.c
total: 78 errors, 32 warnings, 751 lines checked
./arch/x86/kernel/setup_64.c
total: 74 errors, 10 warnings, 1192 lines checked
./arch/x86/kernel/mpparse_32.c
total: 73 errors, 36 warnings, 1132 lines checked
./arch/x86/mm/k8topology_64.c
total: 72 errors, 6 warnings, 182 lines checked
./arch/x86/kernel/mpparse_64.c
total: 69 errors, 27 warnings, 865 lines checked
./arch/x86/math-emu/reg_divide.c
total: 69 errors, 2 warnings, 207 lines checked
./arch/x86/mm/init_64.c
total: 68 errors, 18 warnings, 783 lines checked
./arch/x86/lib/mmx_32.c
total: 68 errors, 3 warnings, 403 lines checked
./arch/x86/kernel/vm86_32.c
total: 66 errors, 16 warnings, 841 lines checked
./arch/x86/lib/usercopy_32.c
total: 63 errors, 2 warnings, 882 lines checked
./arch/x86/pci/irq.c
total: 62 errors, 83 warnings, 1212 lines checked
./arch/x86/boot/compressed/misc_32.c
total: 62 errors, 8 warnings, 382 lines checked
./arch/x86/kernel/signal_64.c
total: 61 errors, 16 warnings, 493 lines checked
./arch/x86/boot/compressed/misc_64.c
total: 61 errors, 8 warnings, 371 lines checked
./arch/x86/oprofile/nmi_int.c
total: 60 errors, 10 warnings, 477 lines checked
./arch/x86/kernel/ptrace_64.c
total: 58 errors, 10 warnings, 621 lines checked
./arch/x86/math-emu/poly_l2.c
total: 58 errors, 0 warnings, 272 lines checked
./arch/x86/kernel/cpu/common.c
total: 57 errors, 15 warnings, 733 lines checked
./arch/x86/kernel/apm_32.c
total: 56 errors, 31 warnings, 2403 lines checked
./arch/x86/math-emu/load_store.c
total: 55 errors, 1 warnings, 272 lines checked
./arch/x86/mm/numa_64.c
total: 54 errors, 13 warnings, 648 lines checked
./arch/x86/kernel/cpu/mtrr/main.c
total: 53 errors, 23 warnings, 760 lines checked
./arch/x86/math-emu/poly_sin.c
total: 53 errors, 1 warnings, 397 lines checked
./arch/x86/lib/csum-wrappers_64.c
total: 51 errors, 6 warnings, 135 lines checked
./arch/x86/ia32/ia32_aout.c
total: 50 errors, 18 warnings, 528 lines checked
./arch/x86/kernel/io_apic_64.c
total: 49 errors, 51 warnings, 2290 lines checked
./arch/x86/kernel/cpu/cyrix.c
total: 49 errors, 11 warnings, 463 lines checked
./arch/x86/kernel/i8259_64.c
total: 48 errors, 4 warnings, 502 lines checked
./arch/x86/mm/fault_64.c
total: 47 errors, 9 warnings, 623 lines checked
./arch/x86/kernel/setup64.c
total: 45 errors, 16 warnings, 295 lines checked
./arch/x86/lib/string_32.c
total: 45 errors, 0 warnings, 237 lines checked
./arch/x86/kernel/cpu/amd.c
total: 42 errors, 26 warnings, 342 lines checked
./arch/x86/kernel/mca_32.c
total: 42 errors, 3 warnings, 469 lines checked
./arch/x86/ia32/ia32_binfmt.c
total: 41 errors, 5 warnings, 285 lines checked
./arch/x86/math-emu/poly_atan.c
total: 41 errors, 0 warnings, 229 lines checked
./arch/x86/math-emu/poly_tan.c
total: 40 errors, 0 warnings, 222 lines checked
./arch/x86/kernel/ptrace_32.c
total: 39 errors, 11 warnings, 717 lines checked
./arch/x86/ia32/fpu32.c
total: 39 errors, 1 warnings, 183 lines checked
./arch/x86/kernel/cpu/intel.c
total: 37 errors, 14 warnings, 346 lines checked
./arch/x86/mm/fault_32.c
total: 37 errors, 11 warnings, 659 lines checked
./arch/x86/mm/pageattr_64.c
total: 37 errors, 3 warnings, 255 lines checked
./arch/x86/mm/pageattr_32.c
total: 37 errors, 3 warnings, 278 lines checked
./arch/x86/math-emu/reg_mul.c
total: 37 errors, 0 warnings, 132 lines checked
./arch/x86/kernel/cpu/intel_cacheinfo.c
total: 36 errors, 49 warnings, 832 lines checked
./arch/x86/oprofile/op_model_ppro.c
total: 34 errors, 3 warnings, 192 lines checked
./arch/x86/oprofile/op_model_athlon.c
total: 33 errors, 4 warnings, 190 lines checked
./arch/x86/kernel/cpu/mcheck/mce_64.c
total: 33 errors, 2 warnings, 902 lines checked
./arch/x86/mach-voyager/voyager_basic.c
total: 31 errors, 15 warnings, 331 lines checked
./arch/x86/math-emu/poly_2xm1.c
total: 30 errors, 0 warnings, 156 lines checked
./arch/x86/boot/cpucheck.c
total: 30 errors, 0 warnings, 262 lines checked
./arch/x86/kernel/smpboot_32.c
total: 29 errors, 46 warnings, 1339 lines checked
./arch/x86/kernel/e820_32.c
total: 29 errors, 36 warnings, 957 lines checked
./arch/x86/boot/compressed/relocs.c
total: 28 errors, 48 warnings, 629 lines checked
./arch/x86/kernel/cpu/cpufreq/longhaul.h
total: 28 errors, 0 warnings, 353 lines checked
./arch/x86/kernel/vmi_32.c
total: 27 errors, 31 warnings, 988 lines checked
./arch/x86/kernel/signal_32.c
total: 27 errors, 10 warnings, 663 lines checked
./arch/x86/math-emu/poly.h
total: 26 errors, 1 warnings, 121 lines checked
./arch/x86/math-emu/fpu_etc.c
total: 26 errors, 0 warnings, 143 lines checked
./arch/x86/kernel/smpboot_64.c
total: 25 errors, 31 warnings, 1099 lines checked
./arch/x86/math-emu/fpu_aux.c
total: 25 errors, 0 warnings, 204 lines checked
./arch/x86/kernel/cpu/cpufreq/powernow-k7.c
total: 23 errors, 88 warnings, 701 lines checked
./arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c
total: 23 errors, 20 warnings, 633 lines checked
./arch/x86/math-emu/fpu_emu.h
total: 23 errors, 3 warnings, 218 lines checked
./arch/x86/kernel/cpu/cpufreq/powernow-k7.h
total: 23 errors, 0 warnings, 44 lines checked
./arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
total: 22 errors, 8 warnings, 440 lines checked
./arch/x86/kernel/cpu/cpufreq/longhaul.c
total: 21 errors, 36 warnings, 1027 lines checked
./arch/x86/kernel/smp_32.c
total: 21 errors, 6 warnings, 711 lines checked
./arch/x86/kernel/pci-dma_64.c
total: 21 errors, 3 warnings, 350 lines checked
./arch/x86/kernel/cpu/mcheck/p4.c
total: 20 errors, 47 warnings, 254 lines checked
./arch/x86/pci/fixup.c
total: 20 errors, 35 warnings, 493 lines checked
./arch/x86/mm/init_32.c
total: 20 errors, 35 warnings, 848 lines checked
./arch/x86/kernel/summit_32.c
total: 20 errors, 11 warnings, 180 lines checked
./arch/x86/mm/ioremap_32.c
total: 20 errors, 7 warnings, 274 lines checked
./arch/x86/mach-generic/probe.c
total: 20 errors, 7 warnings, 125 lines checked
./arch/x86/kernel/cpu/mcheck/p6.c
total: 19 errors, 21 warnings, 119 lines checked
./arch/x86/kernel/reboot_64.c
total: 19 errors, 5 warnings, 176 lines checked
On Jan 10, 2008 9:03 PM, Daniel Walker <[email protected]> wrote:
>
>
> I was playing with checkpatch.pl ;) .. I made a list of style offenders
> inside the arch/x86/ sub-directory. I thought it might be helpful to
> prioritize any style clean ups that people might want to do for x86 ..
> OTOH some of these might show imperfections in checkpatch.pl .. Either
> way I thought it was interesting to review ..
>
> These are sorted by errors, then warnings.. I only included the first
> hundred files which includes about the top %30 of the list .. The
> kprobes_64.c error rate is a little miss-leading because several errors
> are found on a single line ..
I just pulled
git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86 mm
> ./arch/x86/math-emu/fpu_trig.c
> total: 649 errors, 11 warnings, 1845 lines checked
On that tree checkpatch reports:
total: 5 errors, 54 warnings, 1643 lines checked
> ./arch/x86/kernel/kprobes_64.c
> total: 528 errors, 9 warnings, 749 lines checked
total: 0 errors, 0 warnings, 1 lines checked
> ./arch/x86/math-emu/reg_ld_str.c
> total: 392 errors, 17 warnings, 1375 lines checked
total: 8 errors, 39 warnings, 1224 lines checked
> ./arch/x86/kernel/kprobes_32.c
> total: 271 errors, 8 warnings, 756 lines checked
total: 1 errors, 0 warnings, 0 lines checked
> ./arch/x86/math-emu/errors.c
> total: 214 errors, 28 warnings, 739 lines checked
total: 26 errors, 36 warnings, 689 lines checked
So it looks like a lot of errors are fixed in the x86 git tree.
Regards,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> On Jan 10, 2008 9:03 PM, Daniel Walker <[email protected]> wrote:
> >
> >
> > I was playing with checkpatch.pl ;) .. I made a list of style offenders
> > inside the arch/x86/ sub-directory. I thought it might be helpful to
> > prioritize any style clean ups that people might want to do for x86 ..
> > OTOH some of these might show imperfections in checkpatch.pl .. Either
> > way I thought it was interesting to review ..
> >
> > These are sorted by errors, then warnings.. I only included the first
> > hundred files which includes about the top %30 of the list .. The
> > kprobes_64.c error rate is a little miss-leading because several errors
> > are found on a single line ..
>
> I just pulled
> git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86 mm
>
> > ./arch/x86/math-emu/fpu_trig.c
> > total: 649 errors, 11 warnings, 1845 lines checked
Ok, looks like people have been busy .. I was using Linus's git, which
was handy at the time I ran the test ..
Daniel
On Jan 10, 2008 11:41 PM, Daniel Walker <[email protected]> wrote:
>
> On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> > On Jan 10, 2008 9:03 PM, Daniel Walker <[email protected]> wrote:
> > >
> > >
> > > I was playing with checkpatch.pl ;) .. I made a list of style offenders
> > > inside the arch/x86/ sub-directory. I thought it might be helpful to
> > > prioritize any style clean ups that people might want to do for x86 ..
> > > OTOH some of these might show imperfections in checkpatch.pl .. Either
> > > way I thought it was interesting to review ..
> > >
> > > These are sorted by errors, then warnings.. I only included the first
> > > hundred files which includes about the top %30 of the list .. The
> > > kprobes_64.c error rate is a little miss-leading because several errors
> > > are found on a single line ..
> >
> > I just pulled
> > git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86 mm
> >
> > > ./arch/x86/math-emu/fpu_trig.c
> > > total: 649 errors, 11 warnings, 1845 lines checked
>
> Ok, looks like people have been busy .. I was using Linus's git, which
> was handy at the time I ran the test ..
Do you have a script aroung checkpatch.pl for collecting the statistics
you posted? If so, I can run it agains the x86 git tree and report the output.
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
On Thu, 2008-01-10 at 23:47 +0100, Paolo Ciarrocchi wrote:
> On Jan 10, 2008 11:41 PM, Daniel Walker <[email protected]> wrote:
> >
> > On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> > > On Jan 10, 2008 9:03 PM, Daniel Walker <[email protected]> wrote:
> > > >
> > > >
> > > > I was playing with checkpatch.pl ;) .. I made a list of style offenders
> > > > inside the arch/x86/ sub-directory. I thought it might be helpful to
> > > > prioritize any style clean ups that people might want to do for x86 ..
> > > > OTOH some of these might show imperfections in checkpatch.pl .. Either
> > > > way I thought it was interesting to review ..
> > > >
> > > > These are sorted by errors, then warnings.. I only included the first
> > > > hundred files which includes about the top %30 of the list .. The
> > > > kprobes_64.c error rate is a little miss-leading because several errors
> > > > are found on a single line ..
> > >
> > > I just pulled
> > > git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86 mm
> > >
> > > > ./arch/x86/math-emu/fpu_trig.c
> > > > total: 649 errors, 11 warnings, 1845 lines checked
> >
> > Ok, looks like people have been busy .. I was using Linus's git, which
> > was handy at the time I ran the test ..
>
> Do you have a script aroung checkpatch.pl for collecting the statistics
> you posted? If so, I can run it agains the x86 git tree and report the output.
I was just about to do that .. It was actually several one-liner type
scripts which I strung together .. I'll send and updated list in a bit..
Daniel
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> On Jan 10, 2008 9:03 PM, Daniel Walker <[email protected]> wrote:
> >
> >
> > I was playing with checkpatch.pl ;) .. I made a list of style offenders
> > inside the arch/x86/ sub-directory. I thought it might be helpful to
> > prioritize any style clean ups that people might want to do for x86 ..
> > OTOH some of these might show imperfections in checkpatch.pl .. Either
> > way I thought it was interesting to review ..
> >
> > These are sorted by errors, then warnings.. I only included the first
> > hundred files which includes about the top %30 of the list .. The
> > kprobes_64.c error rate is a little miss-leading because several errors
> > are found on a single line ..
>
> I just pulled
> git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86 mm
>
> > ./arch/x86/math-emu/fpu_trig.c
> > total: 649 errors, 11 warnings, 1845 lines checked
>
> On that tree checkpatch reports:
> total: 5 errors, 54 warnings, 1643 lines checked
>
> > ./arch/x86/kernel/kprobes_64.c
> > total: 528 errors, 9 warnings, 749 lines checked
>
> total: 0 errors, 0 warnings, 1 lines checked
I pulled the tree your working with , and it's got mostly the same
issues .. Are you sure your running the commands properly?
The "lines checked" values that you listed looks wrong .. A few you
listed as "0 lines checked" , or "1 lines checked" .. Which can't be
right..
The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
modified since it was pull in on Oct. 11 ..
Daniel
On Jan 11, 2008 12:08 AM, Daniel Walker <[email protected]> wrote:
>
> On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> > On Jan 10, 2008 9:03 PM, Daniel Walker <[email protected]> wrote:
> > >
> > >
> > > I was playing with checkpatch.pl ;) .. I made a list of style offenders
> > > inside the arch/x86/ sub-directory. I thought it might be helpful to
> > > prioritize any style clean ups that people might want to do for x86 ..
> > > OTOH some of these might show imperfections in checkpatch.pl .. Either
> > > way I thought it was interesting to review ..
> > >
> > > These are sorted by errors, then warnings.. I only included the first
> > > hundred files which includes about the top %30 of the list .. The
> > > kprobes_64.c error rate is a little miss-leading because several errors
> > > are found on a single line ..
> >
> > I just pulled
> > git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86 mm
> >
> > > ./arch/x86/math-emu/fpu_trig.c
> > > total: 649 errors, 11 warnings, 1845 lines checked
> >
> > On that tree checkpatch reports:
> > total: 5 errors, 54 warnings, 1643 lines checked
> >
> > > ./arch/x86/kernel/kprobes_64.c
> > > total: 528 errors, 9 warnings, 749 lines checked
> >
> > total: 0 errors, 0 warnings, 1 lines checked
>
> I pulled the tree your working with , and it's got mostly the same
> issues .. Are you sure your running the commands properly?
>
> The "lines checked" values that you listed looks wrong .. A few you
> listed as "0 lines checked" , or "1 lines checked" .. Which can't be
> right..
>
> The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
> modified since it was pull in on Oct. 11 ..
Top commit in my tree is:
commit 62ba5681e2e2d70794719794eadb441875e6d3b3
Author: From: Jan Beulich <[email protected]>
Date: Wed Jan 9 13:31:14 2008 +0100
paolo@paolo-desktop:~/linux-2.6$ ./scripts/checkpatch.pl --file
./arch/x86/kernel/kprobes_64.c
total: 0 errors, 0 warnings, 1 lines checked
And...paolo@paolo-desktop:~/linux-2.6$ ls -l ./arch/x86/kernel/k*
-rw-r--r-- 1 paolo paolo 2853 2007-11-08 23:00 ./arch/x86/kernel/k8.c
-rw-r--r-- 1 paolo paolo 1207 2008-01-10 23:27 ./arch/x86/kernel/kdebugfs.c
-rw-r--r-- 1 paolo paolo 9828 2008-01-10 23:27 ./arch/x86/kernel/kgdb_32.c
-rw-r--r-- 1 paolo paolo 11936 2008-01-10 23:27 ./arch/x86/kernel/kgdb_64.c
-rw-r--r-- 1 paolo paolo 2223 2008-01-10 23:27 ./arch/x86/kernel/kgdb-jmp_32.S
-rw-r--r-- 1 paolo paolo 1783 2008-01-10 23:27 ./arch/x86/kernel/kgdb-jmp_64.S
-rw-r--r-- 1 paolo paolo 1 2008-01-10 23:27
./arch/x86/kernel/kprobes_64.c <-- What?
-rw-r--r-- 1 paolo paolo 32078 2008-01-10 23:27 ./arch/x86/kernel/kprobes.c
I've pulled the tree as follow:
git branch x86
git checkout x86
git-pull --force
git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git mm
I tried to pull again and I've got:
paolo@paolo-desktop:~/linux-2.6$ git-pull --force
git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git mm
Already up-to-date.
gitweb seems to confirm what I'm seeing:
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=shortlog;h=mm
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=blob_plain;f=arch/x86/kernel/kprobes_64.c;hb=mm
which is an empty file
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
On Jan 11, 2008 12:30 AM, Paolo Ciarrocchi <[email protected]> wrote:
>
> On Jan 11, 2008 12:08 AM, Daniel Walker <[email protected]> wrote:
> >
> > On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> > > On Jan 10, 2008 9:03 PM, Daniel Walker <[email protected]> wrote:
> > > >
> > > >
> > > > I was playing with checkpatch.pl ;) .. I made a list of style offenders
> > > > inside the arch/x86/ sub-directory. I thought it might be helpful to
> > > > prioritize any style clean ups that people might want to do for x86 ..
> > > > OTOH some of these might show imperfections in checkpatch.pl .. Either
> > > > way I thought it was interesting to review ..
> > > >
> > > > These are sorted by errors, then warnings.. I only included the first
> > > > hundred files which includes about the top %30 of the list .. The
> > > > kprobes_64.c error rate is a little miss-leading because several errors
> > > > are found on a single line ..
> > >
> > > I just pulled
> > > git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86 mm
> > >
> > > > ./arch/x86/math-emu/fpu_trig.c
> > > > total: 649 errors, 11 warnings, 1845 lines checked
> > >
> > > On that tree checkpatch reports:
> > > total: 5 errors, 54 warnings, 1643 lines checked
> > >
> > > > ./arch/x86/kernel/kprobes_64.c
> > > > total: 528 errors, 9 warnings, 749 lines checked
> > >
> > > total: 0 errors, 0 warnings, 1 lines checked
> >
> > I pulled the tree your working with , and it's got mostly the same
> > issues .. Are you sure your running the commands properly?
> >
> > The "lines checked" values that you listed looks wrong .. A few you
> > listed as "0 lines checked" , or "1 lines checked" .. Which can't be
> > right..
> >
> > The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
> > modified since it was pull in on Oct. 11 ..
>
> Top commit in my tree is:
> commit 62ba5681e2e2d70794719794eadb441875e6d3b3
> Author: From: Jan Beulich <[email protected]>
> Date: Wed Jan 9 13:31:14 2008 +0100
>
>
> paolo@paolo-desktop:~/linux-2.6$ ./scripts/checkpatch.pl --file
> ./arch/x86/kernel/kprobes_64.c
> total: 0 errors, 0 warnings, 1 lines checked
>
> And...paolo@paolo-desktop:~/linux-2.6$ ls -l ./arch/x86/kernel/k*
> -rw-r--r-- 1 paolo paolo 2853 2007-11-08 23:00 ./arch/x86/kernel/k8.c
> -rw-r--r-- 1 paolo paolo 1207 2008-01-10 23:27 ./arch/x86/kernel/kdebugfs.c
> -rw-r--r-- 1 paolo paolo 9828 2008-01-10 23:27 ./arch/x86/kernel/kgdb_32.c
> -rw-r--r-- 1 paolo paolo 11936 2008-01-10 23:27 ./arch/x86/kernel/kgdb_64.c
> -rw-r--r-- 1 paolo paolo 2223 2008-01-10 23:27 ./arch/x86/kernel/kgdb-jmp_32.S
> -rw-r--r-- 1 paolo paolo 1783 2008-01-10 23:27 ./arch/x86/kernel/kgdb-jmp_64.S
> -rw-r--r-- 1 paolo paolo 1 2008-01-10 23:27
> ./arch/x86/kernel/kprobes_64.c <-- What?
> -rw-r--r-- 1 paolo paolo 32078 2008-01-10 23:27 ./arch/x86/kernel/kprobes.c
>
> I've pulled the tree as follow:
> git branch x86
> git checkout x86
> git-pull --force
> git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git mm
>
> I tried to pull again and I've got:
> paolo@paolo-desktop:~/linux-2.6$ git-pull --force
> git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git mm
> Already up-to-date.
>
> gitweb seems to confirm what I'm seeing:
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=shortlog;h=mm
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=blob_plain;f=arch/x86/kernel/kprobes_64.c;hb=mm
> which is an empty file
That's the result of the kprobe unification:
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=17735e04f7f18bea4dcbe4daa31c34acac55b332
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
On Jan 11, 2008 12:08 AM, Daniel Walker <[email protected]> wrote:
> The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
> modified since it was pull in on Oct. 11 ..
Daniel,
are we looking at the same tree?
fpu_trig.c has been modified (and cleaned up) by Ingo 35 hours ago:
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=history;f=arch/x86/math-emu/fpu_trig.c;h=ecd06680581c51cbb7631cd0240708e92d9ef919;hb=mm
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
On Fri, 2008-01-11 at 00:40 +0100, Paolo Ciarrocchi wrote:
> On Jan 11, 2008 12:08 AM, Daniel Walker <[email protected]> wrote:
>
> > The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
> > modified since it was pull in on Oct. 11 ..
>
> Daniel,
> are we looking at the same tree?
> fpu_trig.c has been modified (and cleaned up) by Ingo 35 hours ago:
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=history;f=arch/x86/math-emu/fpu_trig.c;h=ecd06680581c51cbb7631cd0240708e92d9ef919;hb=mm
Not it's appears we aren't .. The tree I was using was a straight pull
of the repository above .. I guess there's a separate repository, and
branch for x86 ..
Daniel
On Fri, 2008-01-11 at 00:40 +0100, Paolo Ciarrocchi wrote:
> On Jan 11, 2008 12:08 AM, Daniel Walker <[email protected]> wrote:
>
> > The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
> > modified since it was pull in on Oct. 11 ..
>
> Daniel,
> are we looking at the same tree?
> fpu_trig.c has been modified (and cleaned up) by Ingo 35 hours ago:
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=history;f=arch/x86/math-emu/fpu_trig.c;h=ecd06680581c51cbb7631cd0240708e92d9ef919;hb=mm
Here's another set of, which shows significant improvement over the last
one..
./arch/x86/kernel/cpu/centaur.c
total: 152 errors, 11 warnings, 471 lines checked
./arch/x86/crypto/aes_32.c
total: 113 errors, 0 warnings, 515 lines checked
./arch/x86/kernel/traps_64.c
total: 103 errors, 24 warnings, 1211 lines checked
./arch/x86/kernel/io_apic_32.c
total: 97 errors, 69 warnings, 2889 lines checked
./arch/x86/kernel/traps_32.c
total: 86 errors, 21 warnings, 1200 lines checked
./arch/x86/oprofile/op_model_p4.c
total: 86 errors, 10 warnings, 722 lines checked
./arch/x86/kernel/process_64.c
total: 70 errors, 19 warnings, 902 lines checked
./arch/x86/kernel/mpparse_32.c
total: 69 errors, 36 warnings, 1137 lines checked
./arch/x86/kernel/mpparse_64.c
total: 69 errors, 27 warnings, 865 lines checked
./arch/x86/lib/mmx_32.c
total: 68 errors, 3 warnings, 403 lines checked
./arch/x86/mm/init_64.c
total: 67 errors, 18 warnings, 763 lines checked
./arch/x86/kernel/vm86_32.c
total: 64 errors, 16 warnings, 840 lines checked
./arch/x86/lib/usercopy_32.c
total: 63 errors, 2 warnings, 882 lines checked
./arch/x86/pci/irq.c
total: 61 errors, 83 warnings, 1224 lines checked
./arch/x86/boot/compressed/misc_32.c
total: 61 errors, 8 warnings, 383 lines checked
./arch/x86/boot/compressed/misc_64.c
total: 60 errors, 8 warnings, 378 lines checked
./arch/x86/kernel/cpu/common.c
total: 57 errors, 15 warnings, 729 lines checked
./arch/x86/kernel/signal_64.c
total: 55 errors, 14 warnings, 489 lines checked
./arch/x86/kernel/cpu/mtrr/main.c
total: 53 errors, 23 warnings, 762 lines checked
./arch/x86/lib/csum-wrappers_64.c
total: 51 errors, 6 warnings, 135 lines checked
./arch/x86/kernel/io_apic_64.c
total: 49 errors, 50 warnings, 2384 lines checked
./arch/x86/kernel/cpu/cyrix.c
total: 49 errors, 11 warnings, 461 lines checked
./arch/x86/mach-voyager/voyager_cat.c
total: 46 errors, 49 warnings, 1199 lines checked
./arch/x86/lib/string_32.c
total: 45 errors, 0 warnings, 237 lines checked
./arch/x86/kernel/setup64.c
total: 43 errors, 16 warnings, 300 lines checked
./arch/x86/kernel/cpu/amd.c
total: 42 errors, 26 warnings, 350 lines checked
./arch/x86/kernel/mca_32.c
total: 42 errors, 3 warnings, 469 lines checked
./arch/x86/kernel/i8259_64.c
total: 38 errors, 2 warnings, 510 lines checked
./arch/x86/kernel/cpu/intel.c
total: 37 errors, 16 warnings, 368 lines checked
./arch/x86/kernel/cpu/intel_cacheinfo.c
total: 36 errors, 49 warnings, 832 lines checked
./arch/x86/oprofile/op_model_ppro.c
total: 34 errors, 3 warnings, 192 lines checked
./arch/x86/oprofile/op_model_athlon.c
total: 33 errors, 4 warnings, 190 lines checked
./arch/x86/kernel/cpu/mcheck/mce_64.c
total: 32 errors, 3 warnings, 899 lines checked
./arch/x86/boot/cpucheck.c
total: 30 errors, 0 warnings, 262 lines checked
./arch/x86/kernel/smpboot_32.c
total: 29 errors, 46 warnings, 1338 lines checked
./arch/x86/boot/compressed/relocs.c
total: 28 errors, 48 warnings, 626 lines checked
./arch/x86/kernel/cpu/cpufreq/longhaul.h
total: 28 errors, 0 warnings, 353 lines checked
./arch/x86/kernel/vmi_32.c
total: 27 errors, 30 warnings, 1014 lines checked
./arch/x86/kernel/signal_32.c
total: 27 errors, 10 warnings, 669 lines checked
./arch/x86/math-emu/errors.c
total: 26 errors, 36 warnings, 689 lines checked
./arch/x86/math-emu/fpu_emu.h
total: 25 errors, 3 warnings, 217 lines checked
./arch/x86/kernel/e820_32.c
total: 24 errors, 34 warnings, 751 lines checked
./arch/x86/kernel/smpboot_64.c
total: 24 errors, 30 warnings, 1119 lines checked
./arch/x86/kernel/cpu/cpufreq/powernow-k7.c
total: 23 errors, 88 warnings, 701 lines checked
./arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c
total: 23 errors, 20 warnings, 633 lines checked
./arch/x86/kernel/cpu/cpufreq/powernow-k7.h
total: 23 errors, 0 warnings, 44 lines checked
./arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
total: 22 errors, 8 warnings, 440 lines checked
./arch/x86/kernel/cpu/cpufreq/longhaul.c
total: 21 errors, 36 warnings, 1027 lines checked
./arch/x86/kernel/smp_32.c
total: 21 errors, 6 warnings, 712 lines checked
./arch/x86/kernel/pci-dma_64.c
total: 21 errors, 3 warnings, 349 lines checked
./arch/x86/pci/fixup.c
total: 20 errors, 35 warnings, 493 lines checked
./arch/x86/kernel/summit_32.c
total: 20 errors, 11 warnings, 180 lines checked
./arch/x86/mm/ioremap_32.c
total: 20 errors, 7 warnings, 274 lines checked
./arch/x86/mach-generic/probe.c
total: 20 errors, 7 warnings, 125 lines checked
./arch/x86/kernel/sys_i386_32.c
total: 18 errors, 23 warnings, 263 lines checked
./arch/x86/kernel/cpu/mcheck/p4.c
total: 17 errors, 34 warnings, 257 lines checked
./arch/x86/kernel/irq_32.c
total: 17 errors, 5 warnings, 376 lines checked
./arch/x86/kernel/early_printk.c
total: 17 errors, 3 warnings, 254 lines checked
./arch/x86/lib/csum-partial_64.c
total: 17 errors, 1 warnings, 150 lines checked
./arch/x86/kernel/cpu/mtrr/generic.c
total: 16 errors, 19 warnings, 508 lines checked
./arch/x86/kernel/cpu/mcheck/p6.c
total: 16 errors, 13 warnings, 122 lines checked
./arch/x86/power/cpu.c
total: 16 errors, 3 warnings, 133 lines checked
./arch/x86/kernel/cpu/perfctr-watchdog.c
total: 15 errors, 7 warnings, 722 lines checked
./arch/x86/kernel/pci-calgary_64.c
total: 15 errors, 6 warnings, 1586 lines checked
./arch/x86/kernel/sys_x86_64.c
total: 15 errors, 3 warnings, 253 lines checked
./arch/x86/math-emu/fpu_system.h
total: 15 errors, 2 warnings, 90 lines checked
./arch/x86/kernel/cpu/cpufreq/powernow-k8.c
total: 14 errors, 104 warnings, 1316 lines checked
./arch/x86/kernel/microcode.c
total: 14 errors, 15 warnings, 850 lines checked
./arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
total: 14 errors, 5 warnings, 798 lines checked
./arch/x86/kernel/vsyscall_64.c
total: 14 errors, 4 warnings, 346 lines checked
./arch/x86/kernel/cpu/transmeta.c
total: 14 errors, 3 warnings, 116 lines checked
./arch/x86/kernel/cpu/cpufreq/elanfreq.c
total: 13 errors, 7 warnings, 308 lines checked
./arch/x86/kernel/irq_64.c
total: 13 errors, 5 warnings, 266 lines checked
./arch/x86/kernel/ptrace.c
total: 13 errors, 4 warnings, 1546 lines checked
./arch/x86/kernel/module_64.c
total: 13 errors, 2 warnings, 185 lines checked
./arch/x86/kernel/cpu/mcheck/mce_amd_64.c
total: 13 errors, 1 warnings, 690 lines checked
./arch/x86/kernel/suspend_64.c
total: 12 errors, 7 warnings, 316 lines checked
./arch/x86/kernel/nmi_64.c
total: 12 errors, 4 warnings, 481 lines checked
./arch/x86/lib/bitstr_64.c
total: 12 errors, 1 warnings, 28 lines checked
./arch/x86/kernel/cpu/proc.c
total: 12 errors, 1 warnings, 196 lines checked
./arch/x86/boot/boot.h
total: 12 errors, 1 warnings, 296 lines checked
./arch/x86/kernel/x8664_ksyms_64.c
total: 11 errors, 31 warnings, 61 lines checked
./arch/x86/kernel/process_32.c
total: 11 errors, 28 warnings, 871 lines checked
./arch/x86/kernel/acpi/boot.c
total: 11 errors, 27 warnings, 1358 lines checked
./arch/x86/pci/mmconfig_64.c
total: 11 errors, 2 warnings, 157 lines checked
./arch/x86/mm/hugetlbpage.c
total: 11 errors, 0 warnings, 391 lines checked
./arch/x86/kernel/cpu/cpufreq/gx-suspmod.c
total: 10 errors, 33 warnings, 494 lines checked
./arch/x86/kernel/cpu/cpufreq/powernow-k6.c
total: 10 errors, 13 warnings, 255 lines checked
./arch/x86/kernel/cpu/mtrr/centaur.c
total: 10 errors, 4 warnings, 224 lines checked
./arch/x86/kernel/cpu/mcheck/p5.c
total: 10 errors, 4 warnings, 53 lines checked
./arch/x86/mm/pgtable_32.c
total: 10 errors, 3 warnings, 375 lines checked
./arch/x86/kernel/cpu/mcheck/mce_32.c
total: 10 errors, 3 warnings, 90 lines checked
./arch/x86/lib/io_64.c
total: 10 errors, 1 warnings, 23 lines checked
./arch/x86/pci/mmconfig_32.c
total: 10 errors, 0 warnings, 148 lines checked
./arch/x86/kernel/cpu/cpufreq/speedstep-smi.c
total: 9 errors, 34 warnings, 423 lines checked
./arch/x86/mach-es7000/es7000plat.c
total: 9 errors, 9 warnings, 307 lines checked
./arch/x86/kernel/i8259_32.c
total: 9 errors, 9 warnings, 422 lines checked
./arch/x86/pci/common.c
total: 9 errors, 8 warnings, 544 lines checked
./arch/x86/lib/bitops_64.c
total: 9 errors, 8 warnings, 175 lines checked
./arch/x86/mm/ioremap_64.c
total: 9 errors, 6 warnings, 194 lines checked