2020-05-06 12:59:33

by Dan Carpenter

Subject: Re: [PATCH -next] staging: kpc2000: fix error return code in kp2000_pcie_probe()

On Wed, May 06, 2020 at 12:52:55PM +0000, Wei Yongjun wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function. Also
> removed var 'rv' since we can use 'err' instead.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Also could you add a Fixes tag? This goes all the way back to the
original commit:

Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers")

regards,
dan carpenter

2020-05-06 13:12:13

by Wei Yongjun

Subject: Re: [PATCH -next] staging: kpc2000: fix error return code in kp2000_pcie_probe()

On 2020/5/6 20:57, Dan Carpenter wrote:
> On Wed, May 06, 2020 at 12:52:55PM +0000, Wei Yongjun wrote:
>> Fix to return a negative error code from the error handling
>> case instead of 0, as done elsewhere in this function. Also
>> removed var 'rv' since we can use 'err' instead.
>>
>> Signed-off-by: Wei Yongjun <[email protected]>
>
> Also could you add a Fixes tag? This goes all the way back to the
> original commit:
>
> Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers")
>

Will fix both of your comments in next version, thanks.

Regards,
Wei Yongjun