This is the start of the stable review cycle for the 4.19.272 release.
There are 80 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.19.272-rc1
Peter Chen <[email protected]>
usb: host: xhci-plat: add wakeup entry at sysfs
Eric Dumazet <[email protected]>
ipv6: ensure sane device mtu in tunnels
Kees Cook <[email protected]>
exit: Use READ_ONCE() for all oops/warn limit reads
Kees Cook <[email protected]>
docs: Fix path paste-o for /sys/kernel/warn_count
Kees Cook <[email protected]>
panic: Expose "warn_count" to sysfs
Kees Cook <[email protected]>
panic: Introduce warn_limit
Kees Cook <[email protected]>
panic: Consolidate open-coded panic_on_warn checks
Kees Cook <[email protected]>
exit: Allow oops_limit to be disabled
Kees Cook <[email protected]>
exit: Expose "oops_count" to sysfs
Jann Horn <[email protected]>
exit: Put an upper limit on how often we can oops
Randy Dunlap <[email protected]>
ia64: make IA64_MCA_RECOVERY bool instead of tristate
Nathan Chancellor <[email protected]>
h8300: Fix build errors from do_exit() to make_task_dead() transition
Nathan Chancellor <[email protected]>
hexagon: Fix function name in die()
Eric W. Biederman <[email protected]>
objtool: Add a missing comma to avoid string concatenation
Eric W. Biederman <[email protected]>
exit: Add and use make_task_dead.
Tiezhu Yang <[email protected]>
panic: unset panic_on_warn inside panic()
Xiaoming Ni <[email protected]>
sysctl: add a new register_sysctl_init() interface
Hui Wang <[email protected]>
dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init
Geert Uytterhoeven <[email protected]>
ARM: dts: imx: Fix pca9547 i2c-mux node name
Jan Beulich <[email protected]>
x86/entry/64: Add instruction suffix to SYSRET
Mikulas Patocka <[email protected]>
x86/asm: Fix an assembler warning with current binutils
Linus Torvalds <[email protected]>
drm/i915/display: fix compiler warning about array overrun
Thomas Gleixner <[email protected]>
x86/i8259: Mark legacy PIC interrupts with IRQ_LEVEL
Dmitry Torokhov <[email protected]>
Revert "Input: synaptics - switch touchpad on HP Laptop 15-da3001TU to RMI mode"
David Christensen <[email protected]>
net/tg3: resolve deadlock in tg3_reset_task() during EEH
Yoshihiro Shimoda <[email protected]>
net: ravb: Fix possible hang if RIS2_QFF1 happen
Marcelo Ricardo Leitner <[email protected]>
sctp: fail if no bound addresses can be used for a given scope
Kuniyuki Iwashima <[email protected]>
netrom: Fix use-after-free of a listening socket.
Sriram Yagnaraman <[email protected]>
netfilter: conntrack: fix vtag checks for ABORT/SHUTDOWN_COMPLETE
Eric Dumazet <[email protected]>
ipv4: prevent potential spectre v1 gadget in ip_metrics_convert()
Eric Dumazet <[email protected]>
netlink: annotate data races around sk_state
Eric Dumazet <[email protected]>
netlink: annotate data races around dst_portid and dst_group
Eric Dumazet <[email protected]>
netlink: annotate data races around nlk->portid
Li RongQing <[email protected]>
netlink: remove hash::nelems check in netlink_insert
Pablo Neira Ayuso <[email protected]>
netfilter: nft_set_rbtree: skip elements in transaction from garbage collection
Paolo Abeni <[email protected]>
net: fix UaF in netns ops registration error path
Manivannan Sadhasivam <[email protected]>
EDAC/device: Respect any driver-supplied workqueue polling value
Giulio Benetti <[email protected]>
ARM: 9280/1: mm: fix warning on phys_addr_t to void pointer assignment
David Howells <[email protected]>
cifs: Fix oops due to uncleared server->smbd_conn in reconnect
Long Li <[email protected]>
smbd: Make upper layer decide when to destroy the transport
Natalia Petrova <[email protected]>
trace_events_hist: add check for return value of 'create_hist_field'
Steven Rostedt (Google) <[email protected]>
tracing: Make sure trace_printk() can output as soon as it can be used
Petr Pavlu <[email protected]>
module: Don't wait for GOING modules
Alexey V. Vissarionov <[email protected]>
scsi: hpsa: Fix allocation size for scsi_host_alloc()
Archie Pusaka <[email protected]>
Bluetooth: hci_sync: cancel cmd_timer if hci_open failed
Dongliang Mu <[email protected]>
fs: reiserfs: remove useless new_opts in reiserfs_remount
Arnaldo Carvalho de Melo <[email protected]>
perf env: Do not return pointers to local variables
Christoph Hellwig <[email protected]>
block: fix and cleanup bio_check_ro
Florian Westphal <[email protected]>
netfilter: conntrack: do not renew entry stuck in tcp SYN_SENT state
Yang Yingliang <[email protected]>
w1: fix WARNING after calling w1_process()
Yang Yingliang <[email protected]>
w1: fix deadloop in __w1_remove_master_device()
Jason Xing <[email protected]>
tcp: avoid the lookup process failing to get sk in ehash table
Liu Shixin <[email protected]>
dmaengine: xilinx_dma: call of_node_put() when breaking out of for_each_child_of_node()
Swati Agarwal <[email protected]>
dmaengine: xilinx_dma: Fix devm_platform_ioremap_resource error handling
Radhey Shyam Pandey <[email protected]>
dmaengine: xilinx_dma: program hardware supported buffer length
Andrea Merello <[email protected]>
dmaengine: xilinx_dma: commonize DMA copy size calculation
Pietro Borrello <[email protected]>
HID: betop: check shape of output reports
Robert Hancock <[email protected]>
net: macb: fix PTP TX timestamp failure due to packet padding
Koba Ko <[email protected]>
dmaengine: Fix double increment of client_count in dma_chan_get()
Randy Dunlap <[email protected]>
net: mlx5: eliminate anonymous module_init & module_exit
Udipto Goswami <[email protected]>
usb: gadget: f_fs: Ensure ep0req is dequeued before free_request
Udipto Goswami <[email protected]>
usb: gadget: f_fs: Prevent race during ffs_ep0_queue_wait
Pietro Borrello <[email protected]>
HID: check empty report_list in hid_validate_values()
Heiner Kallweit <[email protected]>
net: mdio: validate parameter addr in mdiobus_get_phy()
Szymon Heidrich <[email protected]>
net: usb: sr9700: Handle negative len
Szymon Heidrich <[email protected]>
wifi: rndis_wlan: Prevent buffer overflow in rndis_query_oid
Jisoo Jang <[email protected]>
net: nfc: Fix use-after-free in local_cleanup()
Shang XiaoJing <[email protected]>
phy: rockchip-inno-usb2: Fix missing clk_disable_unprepare() in rockchip_usb2phy_power_on()
Luis Gerhorst <[email protected]>
bpf: Fix pointer-leak due to insufficient speculative store bypass mitigation
Raju Rangoju <[email protected]>
amd-xgbe: Delay AN timeout during KR training
Raju Rangoju <[email protected]>
amd-xgbe: TX Flow Ctrl Registers are h/w ver dependent
Alexander Potapenko <[email protected]>
affs: initialize fsdata in affs_truncate()
Dean Luick <[email protected]>
IB/hfi1: Fix expected receive setup error exit issues
Dean Luick <[email protected]>
IB/hfi1: Reserve user expected TIDs
Dean Luick <[email protected]>
IB/hfi1: Reject a zero-length user expected buffer
Masahiro Yamada <[email protected]>
tomoyo: fix broken dependency on *.conf.default
Miaoqian Lin <[email protected]>
EDAC/highbank: Fix memory leak in highbank_mc_probe()
Jiasheng Jiang <[email protected]>
HID: intel_ish-hid: Add check for ishtp_dma_tx_map
Fabio Estevam <[email protected]>
ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
Gaosheng Cui <[email protected]>
memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
-------------
Diffstat:
Documentation/ABI/testing/sysfs-kernel-oops_count | 6 ++
Documentation/ABI/testing/sysfs-kernel-warn_count | 6 ++
Documentation/sysctl/kernel.txt | 20 ++++
Makefile | 4 +-
arch/alpha/kernel/traps.c | 6 +-
arch/alpha/mm/fault.c | 2 +-
arch/arm/boot/dts/imx53-ppd.dts | 2 +-
arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
arch/arm/kernel/traps.c | 2 +-
arch/arm/mm/fault.c | 2 +-
arch/arm/mm/nommu.c | 2 +-
arch/arm64/kernel/traps.c | 2 +-
arch/arm64/mm/fault.c | 2 +-
arch/h8300/kernel/traps.c | 3 +-
arch/h8300/mm/fault.c | 2 +-
arch/hexagon/kernel/traps.c | 2 +-
arch/ia64/Kconfig | 2 +-
arch/ia64/kernel/mca_drv.c | 2 +-
arch/ia64/kernel/traps.c | 2 +-
arch/ia64/mm/fault.c | 2 +-
arch/m68k/kernel/traps.c | 2 +-
arch/m68k/mm/fault.c | 2 +-
arch/microblaze/kernel/exceptions.c | 4 +-
arch/mips/kernel/traps.c | 2 +-
arch/nds32/kernel/traps.c | 8 +-
arch/nios2/kernel/traps.c | 4 +-
arch/openrisc/kernel/traps.c | 2 +-
arch/parisc/kernel/traps.c | 2 +-
arch/powerpc/kernel/traps.c | 2 +-
arch/riscv/kernel/traps.c | 2 +-
arch/riscv/mm/fault.c | 2 +-
arch/s390/kernel/dumpstack.c | 2 +-
arch/s390/kernel/nmi.c | 2 +-
arch/sh/kernel/traps.c | 2 +-
arch/sparc/kernel/traps_32.c | 4 +-
arch/sparc/kernel/traps_64.c | 4 +-
arch/x86/entry/entry_32.S | 6 +-
arch/x86/entry/entry_64.S | 8 +-
arch/x86/kernel/dumpstack.c | 4 +-
arch/x86/kernel/i8259.c | 1 +
arch/x86/kernel/irqinit.c | 4 +-
arch/x86/lib/iomap_copy_64.S | 2 +-
arch/xtensa/kernel/traps.c | 2 +-
block/blk-core.c | 5 +-
drivers/dma/dmaengine.c | 7 +-
drivers/dma/imx-sdma.c | 4 +-
drivers/dma/xilinx/xilinx_dma.c | 78 +++++++++++----
drivers/edac/edac_device.c | 15 ++-
drivers/edac/highbank_mc_edac.c | 7 +-
drivers/gpu/drm/i915/intel_dp.c | 13 ++-
drivers/hid/hid-betopff.c | 17 ++--
drivers/hid/hid-core.c | 4 +-
drivers/hid/intel-ish-hid/ishtp/dma-if.c | 10 ++
drivers/infiniband/hw/hfi1/user_exp_rcv.c | 101 +++++++++++--------
drivers/input/mouse/synaptics.c | 1 -
drivers/memory/mvebu-devbus.c | 3 +-
drivers/net/ethernet/amd/xgbe/xgbe-dev.c | 23 +++--
drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 24 +++++
drivers/net/ethernet/amd/xgbe/xgbe.h | 2 +
drivers/net/ethernet/broadcom/tg3.c | 8 +-
drivers/net/ethernet/cadence/macb_main.c | 9 +-
drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 +-
drivers/net/ethernet/renesas/ravb_main.c | 4 +-
drivers/net/phy/mdio_bus.c | 7 +-
drivers/net/usb/sr9700.c | 2 +-
drivers/net/wireless/rndis_wlan.c | 19 ++--
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 +-
drivers/scsi/hpsa.c | 2 +-
drivers/usb/gadget/function/f_fs.c | 7 ++
drivers/usb/host/xhci-plat.c | 2 +-
drivers/w1/w1.c | 6 +-
drivers/w1/w1_int.c | 5 +-
fs/affs/file.c | 2 +-
fs/cifs/connect.c | 9 +-
fs/cifs/smbdirect.c | 115 ++++++++++++++++++----
fs/cifs/smbdirect.h | 5 +-
fs/proc/proc_sysctl.c | 33 +++++++
fs/reiserfs/super.c | 6 --
include/linux/kernel.h | 1 +
include/linux/sched/task.h | 1 +
include/linux/sysctl.h | 3 +
kernel/bpf/verifier.c | 4 +-
kernel/exit.c | 72 ++++++++++++++
kernel/module.c | 26 ++++-
kernel/panic.c | 75 ++++++++++++--
kernel/sched/core.c | 3 +-
kernel/trace/trace.c | 2 +
kernel/trace/trace.h | 1 +
kernel/trace/trace_events_hist.c | 2 +
kernel/trace/trace_output.c | 3 +-
mm/kasan/report.c | 3 +-
net/bluetooth/hci_core.c | 1 +
net/core/net_namespace.c | 2 +-
net/ipv4/inet_hashtables.c | 17 +++-
net/ipv4/inet_timewait_sock.c | 8 +-
net/ipv4/metrics.c | 2 +
net/ipv6/ip6_gre.c | 12 ++-
net/ipv6/ip6_tunnel.c | 10 +-
net/ipv6/sit.c | 8 +-
net/netfilter/nf_conntrack_proto_sctp.c | 25 +++--
net/netfilter/nf_conntrack_proto_tcp.c | 10 ++
net/netfilter/nft_set_rbtree.c | 16 ++-
net/netlink/af_netlink.c | 41 ++++----
net/netrom/nr_timer.c | 1 +
net/nfc/llcp_core.c | 1 +
net/sctp/bind_addr.c | 6 ++
security/tomoyo/Makefile | 2 +-
tools/objtool/check.c | 3 +-
tools/perf/util/env.c | 4 +-
109 files changed, 773 insertions(+), 304 deletions(-)
From: Mikulas Patocka <[email protected]>
commit 55d235361fccef573990dfa5724ab453866e7816 upstream.
Fix a warning: "found `movsd'; assuming `movsl' was meant"
Signed-off-by: Mikulas Patocka <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Cc: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
arch/x86/lib/iomap_copy_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/lib/iomap_copy_64.S
+++ b/arch/x86/lib/iomap_copy_64.S
@@ -22,6 +22,6 @@
*/
ENTRY(__iowrite32_copy)
movl %edx,%ecx
- rep movsd
+ rep movsl
ret
ENDPROC(__iowrite32_copy)
On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 4.19.272 release.
> There are 80 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Following patch caused build error on arm,
> Gaosheng Cui <[email protected]>
> memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe':
drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of
function 'devm_clk_get_enabled'
[-Werror=implicit-function-declaration]
297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
| ^~~~~~~~~~~~~~~~~~~~
drivers/memory/mvebu-devbus.c:297:6: warning: assignment to 'struct
clk *' from 'int' makes pointer from integer without a cast
[-Wint-conversion]
297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
| ^
cc1: some warnings being treated as errors
Reported-by: Linux Kernel Functional Testing <[email protected]>
Build link, https://storage.tuxsuite.com/public/linaro/lkft/builds/2LDxPVbsGpzKKtYLew33pC6wCSc/
--
Linaro LKFT
https://lkft.linaro.org
On 03/02/2023 12:04, Naresh Kamboju wrote:
> On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman
> <[email protected]> wrote:
>>
>> This is the start of the stable review cycle for the 4.19.272 release.
>> There are 80 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>>
>
> Following patch caused build error on arm,
>
>> Gaosheng Cui <[email protected]>
>> memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
>
> drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe':
> drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of
> function 'devm_clk_get_enabled'
> [-Werror=implicit-function-declaration]
> 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
> | ^~~~~~~~~~~~~~~~~~~~
Already reported:
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof
On 2/3/23 04:28, Krzysztof Kozlowski wrote:
> On 03/02/2023 12:04, Naresh Kamboju wrote:
>> On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman
>> <[email protected]> wrote:
>>>
>>> This is the start of the stable review cycle for the 4.19.272 release.
>>> There are 80 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
>>> or in the git tree and branch at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
>> Following patch caused build error on arm,
>>
>>> Gaosheng Cui <[email protected]>
>>> memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
>>
>> drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe':
>> drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of
>> function 'devm_clk_get_enabled'
>> [-Werror=implicit-function-declaration]
>> 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
>> | ^~~~~~~~~~~~~~~~~~~~
>
> Already reported:
> https://lore.kernel.org/all/[email protected]/
>
I don't usually check if release candidate reports have been reported already.
If I know about it, I may add a reference to the report, but typically I still
report it.
Personally I find it discouraging to get those "already reported" e-mails.
To me it sounds like "hey, you didn't do your job properly". It should not matter
if a problem was already reported or not, and I find it valuable if it is
reported multiple times because it gives an indication of the level of test
coverage. I would find it better if people would use something like "Also
reported:" instead. But then maybe I am just oversensitive, who knows.
Anyway, yes, I noticed this problem as well (and probably overlooked it
in my previous report to Greg - sorry for that).
Thanks,
Guenter
On Fri, Feb 03, 2023 at 01:28:59PM +0100, Krzysztof Kozlowski wrote:
> On 03/02/2023 12:04, Naresh Kamboju wrote:
> > On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman
> > <[email protected]> wrote:
> >>
> >> This is the start of the stable review cycle for the 4.19.272 release.
> >> There are 80 patches in this series, all will be posted as a response
> >> to this one. If anyone has any issues with these being applied, please
> >> let me know.
> >>
> >> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> >> Anything received after that time might be too late.
> >>
> >> The whole patch series can be found in one patch at:
> >> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
> >> or in the git tree and branch at:
> >> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> >> and the diffstat can be found below.
> >>
> >> thanks,
> >>
> >> greg k-h
> >>
> >
> > Following patch caused build error on arm,
> >
> >> Gaosheng Cui <[email protected]>
> >> memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
> >
> > drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe':
> > drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of
> > function 'devm_clk_get_enabled'
> > [-Werror=implicit-function-declaration]
> > 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
> > | ^~~~~~~~~~~~~~~~~~~~
>
> Already reported:
> https://lore.kernel.org/all/[email protected]/
I barely look at 0-day reports about the stable stuff as there is just
too much noise with it, and loads of false problems reported.
So this is a valid report, thanks!
greg k-h
On Fri, Feb 03, 2023 at 04:34:40PM +0530, Naresh Kamboju wrote:
> On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > This is the start of the stable review cycle for the 4.19.272 release.
> > There are 80 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
>
> Following patch caused build error on arm,
>
> > Gaosheng Cui <[email protected]>
> > memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
>
> drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe':
> drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of
> function 'devm_clk_get_enabled'
> [-Werror=implicit-function-declaration]
> 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/memory/mvebu-devbus.c:297:6: warning: assignment to 'struct
> clk *' from 'int' makes pointer from integer without a cast
> [-Wint-conversion]
> 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
> | ^
> cc1: some warnings being treated as errors
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> Build link, https://storage.tuxsuite.com/public/linaro/lkft/builds/2LDxPVbsGpzKKtYLew33pC6wCSc/
Ick, sorry about that, I'll go drop the offending patch now and push out
a -rc2.
thanks,
greg k-h
On 03/02/2023 16:51, Guenter Roeck wrote:
> On 2/3/23 04:28, Krzysztof Kozlowski wrote:
>> On 03/02/2023 12:04, Naresh Kamboju wrote:
>>> On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman
>>> <[email protected]> wrote:
>>>>
>>>> This is the start of the stable review cycle for the 4.19.272 release.
>>>> There are 80 patches in this series, all will be posted as a response
>>>> to this one. If anyone has any issues with these being applied, please
>>>> let me know.
>>>>
>>>> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
>>>> Anything received after that time might be too late.
>>>>
>>>> The whole patch series can be found in one patch at:
>>>> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
>>>> or in the git tree and branch at:
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>>>> and the diffstat can be found below.
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>>
>>>
>>> Following patch caused build error on arm,
>>>
>>>> Gaosheng Cui <[email protected]>
>>>> memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
>>>
>>> drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe':
>>> drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of
>>> function 'devm_clk_get_enabled'
>>> [-Werror=implicit-function-declaration]
>>> 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
>>> | ^~~~~~~~~~~~~~~~~~~~
>>
>> Already reported:
>> https://lore.kernel.org/all/[email protected]/
>>
>
> I don't usually check if release candidate reports have been reported already.
> If I know about it, I may add a reference to the report, but typically I still
> report it.
>
> Personally I find it discouraging to get those "already reported" e-mails.
> To me it sounds like "hey, you didn't do your job properly". It should not matter
> if a problem was already reported or not, and I find it valuable if it is
> reported multiple times because it gives an indication of the level of test
> coverage. I would find it better if people would use something like "Also
> reported:" instead. But then maybe I am just oversensitive, who knows.
>
> Anyway, yes, I noticed this problem as well (and probably overlooked it
> in my previous report to Greg - sorry for that).
>
Let me rephrase it then:
This topic is already discussed here:
https://lore.kernel.org/all/[email protected]/
I proposed to drop both broken backports - mvebu-devbus and
atmel-sdramc, because they require new features in common clock
framework API.
Best regards,
Krzysztof
On Fri, Feb 03, 2023 at 05:56:17PM +0100, Krzysztof Kozlowski wrote:
> On 03/02/2023 16:51, Guenter Roeck wrote:
> > On 2/3/23 04:28, Krzysztof Kozlowski wrote:
> >> On 03/02/2023 12:04, Naresh Kamboju wrote:
> >>> On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman
> >>> <[email protected]> wrote:
> >>>>
> >>>> This is the start of the stable review cycle for the 4.19.272 release.
> >>>> There are 80 patches in this series, all will be posted as a response
> >>>> to this one. If anyone has any issues with these being applied, please
> >>>> let me know.
> >>>>
> >>>> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> >>>> Anything received after that time might be too late.
> >>>>
> >>>> The whole patch series can be found in one patch at:
> >>>> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
> >>>> or in the git tree and branch at:
> >>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> >>>> and the diffstat can be found below.
> >>>>
> >>>> thanks,
> >>>>
> >>>> greg k-h
> >>>>
> >>>
> >>> Following patch caused build error on arm,
> >>>
> >>>> Gaosheng Cui <[email protected]>
> >>>> memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
> >>>
> >>> drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe':
> >>> drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of
> >>> function 'devm_clk_get_enabled'
> >>> [-Werror=implicit-function-declaration]
> >>> 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
> >>> | ^~~~~~~~~~~~~~~~~~~~
> >>
> >> Already reported:
> >> https://lore.kernel.org/all/[email protected]/
> >>
> >
> > I don't usually check if release candidate reports have been reported already.
> > If I know about it, I may add a reference to the report, but typically I still
> > report it.
> >
> > Personally I find it discouraging to get those "already reported" e-mails.
> > To me it sounds like "hey, you didn't do your job properly". It should not matter
> > if a problem was already reported or not, and I find it valuable if it is
> > reported multiple times because it gives an indication of the level of test
> > coverage. I would find it better if people would use something like "Also
> > reported:" instead. But then maybe I am just oversensitive, who knows.
> >
> > Anyway, yes, I noticed this problem as well (and probably overlooked it
> > in my previous report to Greg - sorry for that).
> >
>
> Let me rephrase it then:
>
> This topic is already discussed here:
> https://lore.kernel.org/all/[email protected]/
>
> I proposed to drop both broken backports - mvebu-devbus and
> atmel-sdramc, because they require new features in common clock
> framework API.
Ah, I totally missed that, again, seeing the good in the mess of the
0-day reports here is hard and not obvious at all. I ignored that and
hence the problem was here. I've dropped the offending commit now.
thanks,
greg k-h
On Fri, Feb 03, 2023 at 05:50:49PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Feb 03, 2023 at 04:34:40PM +0530, Naresh Kamboju wrote:
> > On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman
> > <[email protected]> wrote:
> > >
> > > This is the start of the stable review cycle for the 4.19.272 release.
> > > There are 80 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > Following patch caused build error on arm,
> >
> > > Gaosheng Cui <[email protected]>
> > > memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
> >
> > drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe':
> > drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of
> > function 'devm_clk_get_enabled'
> > [-Werror=implicit-function-declaration]
> > 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
> > | ^~~~~~~~~~~~~~~~~~~~
> > drivers/memory/mvebu-devbus.c:297:6: warning: assignment to 'struct
> > clk *' from 'int' makes pointer from integer without a cast
> > [-Wint-conversion]
> > 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL);
> > | ^
> > cc1: some warnings being treated as errors
> >
> > Reported-by: Linux Kernel Functional Testing <[email protected]>
> >
> > Build link, https://storage.tuxsuite.com/public/linaro/lkft/builds/2LDxPVbsGpzKKtYLew33pC6wCSc/
>
> Ick, sorry about that, I'll go drop the offending patch now and push out
> a -rc2.
Wait a minute, you have more issues to fix.
Guenter
On 2/3/23 03:11, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.272 release.
> There are 80 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan <[email protected]>
thanks,
-- Shuah