Hi,
On 11/22/2017 10:56 PM, Stephen Boyd wrote:
> On 11/21/2017 01:23 AM, Manu Gautam wrote:
>> New revision (v3) of QMP PHY uses different offsets
>> for almost all of the registers. Hence, move these
>> definitions to header file so that updated offsets
>> can be added for QMP v3.
>>
>> Signed-off-by: Manu Gautam <[email protected]>
>> ---
> Why? It would only be included into one C file so it's really not necessary.
Yes, it is not necessary but it keep QMP PHY driver clean. V3 PHY duplicates all the
#defines and this could continue for future revisions as well.
Please refer to this patch:
- [PATCH v3 11/16] phy: qcom-qmp: Add register offsets for QMP V3 PHY
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
From 1584788061551957265@xxx Wed Nov 22 17:27:51 +0000 2017
X-GM-THRID: 1584667162035868026
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread