Commit "538af6e5856b" which convert s5p-mfc bindings to
json-schema is already merged. Remove "s5p-mfc.txt" file.
Signed-off-by: Aakarsh Jain <[email protected]>
---
Documentation/devicetree/bindings/media/s5p-mfc.txt | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/s5p-mfc.txt
diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt
deleted file mode 100644
index e69de29bb2d1..000000000000
--
2.17.1
On 30/01/2024 13:57, Aakarsh Jain wrote:
> Commit "538af6e5856b" which convert s5p-mfc bindings to
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
> json-schema is already merged. Remove "s5p-mfc.txt" file.
>
> Signed-off-by: Aakarsh Jain <[email protected]>
> ---
> Documentation/devicetree/bindings/media/s5p-mfc.txt | 0
Why you did not remove it in the first place? Your diff from
538af6e5856b is so confusing.
Best regards,
Krzysztof
On 30/01/2024 15:25, Krzysztof Kozlowski wrote:
> On 30/01/2024 13:57, Aakarsh Jain wrote:
>> Commit "538af6e5856b" which convert s5p-mfc bindings to
>
> Please run scripts/checkpatch.pl and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.
>
>> json-schema is already merged. Remove "s5p-mfc.txt" file.
>>
>> Signed-off-by: Aakarsh Jain <[email protected]>
>> ---
>> Documentation/devicetree/bindings/media/s5p-mfc.txt | 0
>
> Why you did not remove it in the first place? Your diff from
> 538af6e5856b is so confusing.
Also, add fixes tag.
Best regards,
Krzysztof
> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: 30 January 2024 19:57
> To: Aakarsh Jain <[email protected]>; linux-arm-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH] dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt
> binding
>
> On 30/01/2024 15:25, Krzysztof Kozlowski wrote:
> > On 30/01/2024 13:57, Aakarsh Jain wrote:
> >> Commit "538af6e5856b" which convert s5p-mfc bindings to
> >
> > Please run scripts/checkpatch.pl and fix reported warnings. Some
> > warnings can be ignored, but the code here looks like it needs a fix.
> > Feel free to get in touch if the warning is not clear.
> >
I am getting below warning while running scripts/checkpatch.pl on this patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 lines checked
I think this can be ignored.
> >> json-schema is already merged. Remove "s5p-mfc.txt" file.
> >>
> >> Signed-off-by: Aakarsh Jain <[email protected]>
> >> ---
> >> Documentation/devicetree/bindings/media/s5p-mfc.txt | 0
> >
> > Why you did not remove it in the first place? Your diff from
> > 538af6e5856b is so confusing.
>
I missed it before. Will add Fixes tag.
> Also, add fixes tag.
>
Sure.
Thanks for review!
> Best regards,
> Krzysztof
On 31/01/2024 07:06, Aakarsh Jain wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <[email protected]>
>> Sent: 30 January 2024 19:57
>> To: Aakarsh Jain <[email protected]>; linux-arm-
>> [email protected]; [email protected]; linux-
>> [email protected]; [email protected]
>> Cc: [email protected]; [email protected];
>> [email protected]; [email protected];
>> [email protected]; [email protected];
>> [email protected]; [email protected];
>> [email protected]; [email protected]; [email protected];
>> [email protected]
>> Subject: Re: [PATCH] dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt
>> binding
>>
>> On 30/01/2024 15:25, Krzysztof Kozlowski wrote:
>>> On 30/01/2024 13:57, Aakarsh Jain wrote:
>>>> Commit "538af6e5856b" which convert s5p-mfc bindings to
>>>
>>> Please run scripts/checkpatch.pl and fix reported warnings. Some
>>> warnings can be ignored, but the code here looks like it needs a fix.
>>> Feel free to get in touch if the warning is not clear.
>>>
> I am getting below warning while running scripts/checkpatch.pl on this patch
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #18:
> deleted file mode 100644
>
> total: 0 errors, 1 warnings, 0 lines checked
This one can be ignored, but your commit syntax does not look right.
Best regards,
Krzysztof