On 3/2/2022 10:51 PM, Greg KH wrote:
> On Wed, Mar 02, 2022 at 08:07:59PM +0800, Nguyen Dinh Phi wrote:
>> Convert sprintf() to sysfs_emit() in order to check buffer overrun on sysfs
>> outputs.
>
> There are no such buffer overruns on these sysfs files.
>
I don't want to duplicate the title so I use the description of
sysfs_emit() as the patch message. I have just realized that the title
is also incorrect, sorry for my mistake.
>>
>> Signed-off-by: Nguyen Dinh Phi <[email protected]>
>> ---
>> samples/kobject/kobject-example.c | 4 ++--
>> samples/kobject/kset-example.c | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> Why is this a resend? What happened to the first version?
>
> thanks,
>
> greg k-h
There is no response for the first version. Actually, there is no
Maintainer is associated with these two files (in MAINTAINERS files),
hence, my first patch was only sent to the linux-kernel mailing list.
BR,
Phi.
On Thu, Mar 03, 2022 at 02:11:36AM +0800, Phi Nguyen wrote:
> On 3/2/2022 10:51 PM, Greg KH wrote:
> > On Wed, Mar 02, 2022 at 08:07:59PM +0800, Nguyen Dinh Phi wrote:
> > > Convert sprintf() to sysfs_emit() in order to check buffer overrun on sysfs
> > > outputs.
> >
> > There are no such buffer overruns on these sysfs files.
> >
> I don't want to duplicate the title so I use the description of sysfs_emit()
> as the patch message. I have just realized that the title is also incorrect,
> sorry for my mistake.
>
> > >
> > > Signed-off-by: Nguyen Dinh Phi <[email protected]>
> > > ---
> > > samples/kobject/kobject-example.c | 4 ++--
> > > samples/kobject/kset-example.c | 4 ++--
> > > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > Why is this a resend? What happened to the first version?
> >
> > thanks,
> >
> > greg k-h
>
> There is no response for the first version. Actually, there is no Maintainer
> is associated with these two files (in MAINTAINERS files), hence, my first
> patch was only sent to the linux-kernel mailing list.
You need to give reviewers a hint as to what is going on when you do
this, we can't read minds :)
thanks,
greg k-h
On 3/3/2022 4:22 AM, Greg KH wrote:
> On Thu, Mar 03, 2022 at 02:11:36AM +0800, Phi Nguyen wrote:
>> On 3/2/2022 10:51 PM, Greg KH wrote:
>>> On Wed, Mar 02, 2022 at 08:07:59PM +0800, Nguyen Dinh Phi wrote:
>>>> Convert sprintf() to sysfs_emit() in order to check buffer overrun on sysfs
>>>> outputs.
>>>
>>> There are no such buffer overruns on these sysfs files.
>>>
>> I don't want to duplicate the title so I use the description of sysfs_emit()
>> as the patch message. I have just realized that the title is also incorrect,
>> sorry for my mistake.
>>
>>>>
>>>> Signed-off-by: Nguyen Dinh Phi <[email protected]>
>>>> ---
>>>> samples/kobject/kobject-example.c | 4 ++--
>>>> samples/kobject/kset-example.c | 4 ++--
>>>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> Why is this a resend? What happened to the first version?
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> There is no response for the first version. Actually, there is no Maintainer
>> is associated with these two files (in MAINTAINERS files), hence, my first
>> patch was only sent to the linux-kernel mailing list.
>
> You need to give reviewers a hint as to what is going on when you do
> this, we can't read minds :)
>
> thanks,
>
> greg k-h
Hi Greg,
Am I right in thinking that you are the maintainer of these files? Can I
send a patch to add an entry to /linux/MAINTAINERS file?
BR,
Phi.
On Thu, Mar 03, 2022 at 04:45:07PM +0800, Phi Nguyen wrote:
> On 3/3/2022 4:22 AM, Greg KH wrote:
> Am I right in thinking that you are the maintainer of these files?
Yes, I think so.
> Can I send a patch to add an entry to /linux/MAINTAINERS file?
Please do.
thanks,
greg k-h