2023-03-30 08:55:50

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH 4/5] serial: 8250_tegra: Add explicit include for of.h


On 29/03/2023 22:20, Rob Herring wrote:
> With linux/acpi.h no longer implicitly including of.h, add an explicit
> include of of.h to fix the following error:
>
> drivers/tty/serial/8250/8250_tegra.c:68:15: error: implicit declaration of function 'of_alias_get_id' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> drivers/tty/serial/8250/8250_tegra.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/8250/8250_tegra.c b/drivers/tty/serial/8250/8250_tegra.c
> index e7cddeec9d8e..2509e7f74ccf 100644
> --- a/drivers/tty/serial/8250/8250_tegra.c
> +++ b/drivers/tty/serial/8250/8250_tegra.c
> @@ -11,6 +11,7 @@
> #include <linux/delay.h>
> #include <linux/io.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/reset.h>
> #include <linux/slab.h>
>
>


Reviewed-by: Jon Hunter <[email protected]>

Thanks!
Jon

--
nvpublic