2022-01-15 19:14:35

by Christophe JAILLET

Subject: [PATCH] dmaengine: altera-msgdma: Remove useless DMA-32 fallback configuration

As stated in [1], dma_set_mask() with a 64-bit mask never fails if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.

Simplify code and remove some dead code accordingly.

[1]: https://lore.kernel.org/linux-kernel/[email protected]/#t

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/dma/altera-msgdma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
index f5b885d69cd3..6f56dfd375e3 100644
--- a/drivers/dma/altera-msgdma.c
+++ b/drivers/dma/altera-msgdma.c
@@ -891,9 +891,7 @@ static int msgdma_probe(struct platform_device *pdev)
ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
if (ret) {
dev_warn(&pdev->dev, "unable to set coherent mask to 64");
- ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
- if (ret)
- goto fail;
+ goto fail;
}

msgdma_reset(mdev);
--
2.32.0

2022-01-17 14:31:10

by Stefan Roese

Subject: Re: [PATCH] dmaengine: altera-msgdma: Remove useless DMA-32 fallback configuration

On 1/15/22 08:40, Christophe JAILLET wrote:
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>
> Simplify code and remove some dead code accordingly.
>
> [1]: https://lore.kernel.org/linux-kernel/[email protected]/#t
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: Stefan Roese <[email protected]>

Thanks,
Stefan

> ---
> drivers/dma/altera-msgdma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
> index f5b885d69cd3..6f56dfd375e3 100644
> --- a/drivers/dma/altera-msgdma.c
> +++ b/drivers/dma/altera-msgdma.c
> @@ -891,9 +891,7 @@ static int msgdma_probe(struct platform_device *pdev)
> ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
> if (ret) {
> dev_warn(&pdev->dev, "unable to set coherent mask to 64");
> - ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> - if (ret)
> - goto fail;
> + goto fail;
> }
>
> msgdma_reset(mdev);
>

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]

2022-01-22 01:07:34

by Olivier Dautricourt

Subject: Re: [PATCH] dmaengine: altera-msgdma: Remove useless DMA-32 fallback configuration

The 01/15/2022 08:40, Christophe JAILLET wrote:
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>
> Simplify code and remove some dead code accordingly.
>
> [1]: https://lore.kernel.org/linux-kernel/[email protected]/#t
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Acked-by: Olivier Dautricourt <[email protected]>

> ---
> drivers/dma/altera-msgdma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
> index f5b885d69cd3..6f56dfd375e3 100644
> --- a/drivers/dma/altera-msgdma.c
> +++ b/drivers/dma/altera-msgdma.c
> @@ -891,9 +891,7 @@ static int msgdma_probe(struct platform_device *pdev)
> ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
> if (ret) {
> dev_warn(&pdev->dev, "unable to set coherent mask to 64");
> - ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> - if (ret)
> - goto fail;
> + goto fail;
> }
>
> msgdma_reset(mdev);
> --
> 2.32.0
>

2022-02-15 13:12:20

by Vinod Koul

Subject: Re: [PATCH] dmaengine: altera-msgdma: Remove useless DMA-32 fallback configuration

On 15-01-22, 08:40, Christophe JAILLET wrote:
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>
> Simplify code and remove some dead code accordingly.

Applied, thanks

--
~Vinod