2013-03-19 04:18:20

by Sachin Kamat

Subject: [PATCH 1/1] extcon: max77693: Staticize default_init_data

Commit 0ec83bd246 ("extcon: max77693: Initialize register of MUIC
device to bring up it without platform data") added this structure
but forgot to make it static. Without this patch we get the following
warning:
drivers/extcon/extcon-max77693.c:41:26: warning:
symbol 'default_init_data' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/extcon/extcon-max77693.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
index 8f3c947..7b2e93d 100644
--- a/drivers/extcon/extcon-max77693.c
+++ b/drivers/extcon/extcon-max77693.c
@@ -38,7 +38,7 @@
* extcon-max77693 driver use 'default_init_data' to bring up base operation
* of MAX77693 MUIC device.
*/
-struct max77693_reg_data default_init_data[] = {
+static struct max77693_reg_data default_init_data[] = {
{
/* STATUS2 - [3]ChgDetRun */
.addr = MAX77693_MUIC_REG_STATUS2,
--
1.7.4.1

2013-03-19 09:35:44

by Chanwoo Choi

Subject: Re: [PATCH 1/1] extcon: max77693: Staticize default_init_data

On 03/19/2013 01:07 PM, Sachin Kamat wrote:
> Commit 0ec83bd246 ("extcon: max77693: Initialize register of MUIC
> device to bring up it without platform data") added this structure
> but forgot to make it static. Without this patch we get the following
> warning:
> drivers/extcon/extcon-max77693.c:41:26: warning:
> symbol 'default_init_data' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/extcon/extcon-max77693.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
> index 8f3c947..7b2e93d 100644
> --- a/drivers/extcon/extcon-max77693.c
> +++ b/drivers/extcon/extcon-max77693.c
> @@ -38,7 +38,7 @@
> * extcon-max77693 driver use 'default_init_data' to bring up base operation
> * of MAX77693 MUIC device.
> */
> -struct max77693_reg_data default_init_data[] = {
> +static struct max77693_reg_data default_init_data[] = {
> {
> /* STATUS2 - [3]ChgDetRun */
> .addr = MAX77693_MUIC_REG_STATUS2,
Applied it. Thanks.

Chanwoo Choi