2013-05-21 02:44:24

by Libo Chen

Subject: [PATCH 18/19] drivers/net/ethernet/marvell: add missing platform_driver owne

set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece

Signed-off-by: Libo Chen <[email protected]>
---
drivers/net/ethernet/marvell/mvneta.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index c966785..be35a3e 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -2820,6 +2820,7 @@ static struct platform_driver mvneta_driver = {
.remove = mvneta_remove,
.driver = {
.name = MVNETA_DRIVER_NAME,
+ .owner = THIS_MODULE,
.of_match_table = mvneta_match,
},
};
--
1.7.1

2013-05-21 13:11:46

by Sergei Shtylyov

Subject: Re: [PATCH 18/19] drivers/net/ethernet/marvell: add missing platform_driver owne

Hello.

On 21-05-2013 6:42, Libo Chen wrote:

> set the owner of platform_driver, to ensure that the
> caller of driver holds a module refernece

> Signed-off-by: Libo Chen <[email protected]>
> ---
> drivers/net/ethernet/marvell/mvneta.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index c966785..be35a3e 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -2820,6 +2820,7 @@ static struct platform_driver mvneta_driver = {
> .remove = mvneta_remove,
> .driver = {
> .name = MVNETA_DRIVER_NAME,
> + .owner = THIS_MODULE,

Indent this = with space or indent all ='s with tabs.

> .of_match_table = mvneta_match,
> },
> };

WBR, Sergei

2013-05-22 01:07:48

by Libo Chen

Subject: Re: [PATCH 18/19] drivers/net/ethernet/marvell: add missing platform_driver owne

On 2013/5/21 21:11, Sergei Shtylyov wrote:
> Hello.
>
> On 21-05-2013 6:42, Libo Chen wrote:
>
>> set the owner of platform_driver, to ensure that the
>> caller of driver holds a module refernece
>
>> Signed-off-by: Libo Chen <[email protected]>
>> ---
>> drivers/net/ethernet/marvell/mvneta.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
>> index c966785..be35a3e 100644
>> --- a/drivers/net/ethernet/marvell/mvneta.c
>> +++ b/drivers/net/ethernet/marvell/mvneta.c
>> @@ -2820,6 +2820,7 @@ static struct platform_driver mvneta_driver = {
>> .remove = mvneta_remove,
>> .driver = {
>> .name = MVNETA_DRIVER_NAME,
>> + .owner = THIS_MODULE,
>
> Indent this = with space or indent all ='s with tabs.


thanks for your suggest.

Regards,

Libo
>
>> .of_match_table = mvneta_match,
>> },
>> };
>
> WBR, Sergei
>
>
>
>