2013-05-05 08:40:10

by Libo Chen

Subject: [PATCH] mtd: fix kfree bcm47xxsflash

From: Libo Chen <[email protected]>

mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.

Signed-off-by: Libo Chen <[email protected]>
---
drivers/mtd/devices/bcm47xxsflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
index 9526628..4aa9141 100644
--- a/drivers/mtd/devices/bcm47xxsflash.c
+++ b/drivers/mtd/devices/bcm47xxsflash.c
@@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
return 0;

err_dev_reg:
- kfree(&b47s->mtd);
+ kfree(b47s);
out:
return err;
}
--
1.8.1.2

2013-05-22 03:54:21

by Libo Chen

Subject: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.

Signed-off-by: Libo Chen <[email protected]>
Acked-by: Rafał Miłecki <[email protected]>
---
drivers/mtd/devices/bcm47xxsflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

* add Acked-by: Rafał Miłecki <[email protected]>
* change send list

diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
index 9526628..4aa9141 100644
--- a/drivers/mtd/devices/bcm47xxsflash.c
+++ b/drivers/mtd/devices/bcm47xxsflash.c
@@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
return 0;

err_dev_reg:
- kfree(&b47s->mtd);
+ kfree(b47s);
out:
return err;
}
--
1.8.1.2

2013-05-22 05:32:11

by Rafał Miłecki

Subject: Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013/5/22 Libo Chen <[email protected]>:
> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.

Thanks!

--
Rafał

2013-05-28 12:44:23

by Libo Chen

Subject: Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

ping...

On 2013/5/22 11:51, Libo Chen wrote:
>
> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.
>
> Signed-off-by: Libo Chen <[email protected]>
> Acked-by: Rafał Miłecki <[email protected]>
> ---
> drivers/mtd/devices/bcm47xxsflash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> * add Acked-by: Rafał Miłecki <[email protected]>
> * change send list
>
> diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
> index 9526628..4aa9141 100644
> --- a/drivers/mtd/devices/bcm47xxsflash.c
> +++ b/drivers/mtd/devices/bcm47xxsflash.c
> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
> return 0;
>
> err_dev_reg:
> - kfree(&b47s->mtd);
> + kfree(b47s);
> out:
> return err;
> }
>

2013-05-28 12:49:17

by Rafał Miłecki

Subject: Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013/5/28 Libo Chen <[email protected]>:
> ping...

It takes a lot of time for someone to pick up mtd patches, just be patient ;)

--
Rafał

2013-05-28 15:30:01

by Andy Shevchenko

Subject: Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

This is good fix, but I rather prefer not to see it in this shape.
See comments below.

On Wed, May 22, 2013 at 6:51 AM, Libo Chen <[email protected]> wrote:
>
> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.
>
> Signed-off-by: Libo Chen <[email protected]>
> Acked-by: Rafał Miłecki <[email protected]>
> ---
> drivers/mtd/devices/bcm47xxsflash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> * add Acked-by: Rafał Miłecki <[email protected]>
> * change send list
>
> diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
> index 9526628..4aa9141 100644
> --- a/drivers/mtd/devices/bcm47xxsflash.c
> +++ b/drivers/mtd/devices/bcm47xxsflash.c
> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
> return 0;
>
> err_dev_reg:
> - kfree(&b47s->mtd);
> + kfree(b47s);
> out:
> return err;
> }

What about to switch to devm_* and remove those labels and kfrees at all?

Additionally you can add another patch to use module_platform_driver()
macro instead of module_init/exit.

--
With Best Regards,
Andy Shevchenko

2013-05-29 02:42:49

by Libo Chen

Subject: Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

On 2013/5/28 23:29, Andy Shevchenko wrote:
> This is good fix, but I rather prefer not to see it in this shape.
> See comments below.
>
> On Wed, May 22, 2013 at 6:51 AM, Libo Chen <[email protected]> wrote:
>>
>> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.
>>
>> Signed-off-by: Libo Chen <[email protected]>
>> Acked-by: Rafał Miłecki <[email protected]>
>> ---
>> drivers/mtd/devices/bcm47xxsflash.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> * add Acked-by: Rafał Miłecki <[email protected]>
>> * change send list
>>
>> diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
>> index 9526628..4aa9141 100644
>> --- a/drivers/mtd/devices/bcm47xxsflash.c
>> +++ b/drivers/mtd/devices/bcm47xxsflash.c
>> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
>> return 0;
>>
>> err_dev_reg:
>> - kfree(&b47s->mtd);
>> + kfree(b47s);
>> out:
>> return err;
>> }
>
> What about to switch to devm_* and remove those labels and kfrees at all?
>
> Additionally you can add another patch to use module_platform_driver()
> macro instead of module_init/exit.
>

ok, I will update later.

thanks,

Libo


> --
> With Best Regards,
> Andy Shevchenko
>
> .
>