2013-06-28 06:45:34

by George Cherian

[permalink] [raw]
Subject: [PATCH] arm: dts: AM43x: Add usb_otg_hs node

Adds device node for HS USB Host module for AM437x

Signed-off-by: George Cherian <[email protected]>
---
This patch is on top of
git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git for_3.11/dts

arch/arm/boot/dts/am4372.dtsi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index ddc1df7..e4f5eb8 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -64,5 +64,24 @@
compatible = "ti,am4372-counter32k","ti,omap-counter32k";
reg = <0x44e86000 0x40>;
};
+
+ usb_otg_hs1: am4372_dwc3@48380000 {
+ compatible = "ti,am437x-dwc3";
+ reg = <0x48380000 0x1ff>;
+ interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ utmi-mode = <1>;
+ ranges;
+
+ dwc3@48390000 {
+ compatible = "synopsys,dwc3";
+ reg = <0x48390000 0xcfff>;
+ interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
+ tx-fifo-resize;
+ };
+
+ };
+
};
};
--
1.8.1.4


2013-07-07 08:36:45

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH] arm: dts: AM43x: Add usb_otg_hs node

Hi,

On Fri, Jun 28, 2013 at 12:14:47PM +0530, George Cherian wrote:
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index ddc1df7..e4f5eb8 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -64,5 +64,24 @@
> compatible = "ti,am4372-counter32k","ti,omap-counter32k";
> reg = <0x44e86000 0x40>;
> };
> +
> + usb_otg_hs1: am4372_dwc3@48380000 {
> + compatible = "ti,am437x-dwc3";
> + reg = <0x48380000 0x1ff>;
> + interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + utmi-mode = <1>;
> + ranges;
> +
> + dwc3@48390000 {
> + compatible = "synopsys,dwc3";

let's us snps,dwc3. I recently posted a patch converting synopsys to
snps like all other DesignWare drivers. Support for synopsys,dwc3 is
still there, but shouldn't be used.

> + reg = <0x48390000 0xcfff>;
> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
> + tx-fifo-resize;

is this flag *really* necessary, I asked you and didn't get an answer.

--
balbi


Attachments:
(No filename) (1.05 kB)
signature.asc (836.00 B)
Digital signature
Download all attachments

2013-07-08 05:21:10

by George Cherian

[permalink] [raw]
Subject: Re: [PATCH] arm: dts: AM43x: Add usb_otg_hs node

On 7/7/2013 2:05 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Jun 28, 2013 at 12:14:47PM +0530, George Cherian wrote:
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ddc1df7..e4f5eb8 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -64,5 +64,24 @@
>> compatible = "ti,am4372-counter32k","ti,omap-counter32k";
>> reg = <0x44e86000 0x40>;
>> };
>> +
>> + usb_otg_hs1: am4372_dwc3@48380000 {
>> + compatible = "ti,am437x-dwc3";
>> + reg = <0x48380000 0x1ff>;
>> + interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + utmi-mode = <1>;
>> + ranges;
>> +
>> + dwc3@48390000 {
>> + compatible = "synopsys,dwc3";
> let's us snps,dwc3. I recently posted a patch converting synopsys to
> snps like all other DesignWare drivers. Support for synopsys,dwc3 is
> still there, but shouldn't be used.
okay
>
>> + reg = <0x48390000 0xcfff>;
>> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
>> + tx-fifo-resize;
> is this flag *really* necessary, I asked you and didn't get an answer.
We will not be needing this flag , since each EP has 3K tx fifo size.
Also given the fact that we will be operating only
in 2.0 mode the default values are only sufficient.
I will re-send the patch with above changes.

Regards,
-George