From: Mrinmay Sarkar <[email protected]>
Add global interrupt support in dt-bindings for SA8775p RC platform.
Signed-off-by: Mrinmay Sarkar <[email protected]>
---
.../devicetree/bindings/pci/qcom,pcie.yaml | 26 +++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index a93ab3b54066..d86fb63a2d2c 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -63,7 +63,7 @@ properties:
interrupt-names:
minItems: 1
- maxItems: 8
+ maxItems: 9
iommu-map:
minItems: 1
@@ -873,8 +873,30 @@ allOf:
compatible:
contains:
enum:
- - qcom,pcie-msm8996
- qcom,pcie-sa8775p
+ then:
+ oneOf:
+ - properties:
+ interrupts:
+ minItems: 9
+ interrupt-names:
+ items:
+ - const: msi0
+ - const: msi1
+ - const: msi2
+ - const: msi3
+ - const: msi4
+ - const: msi5
+ - const: msi6
+ - const: msi7
+ - const: global
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,pcie-msm8996
- qcom,pcie-sc7280
- qcom,pcie-sc8180x
- qcom,pcie-sdm845
--
2.40.1
On 21/02/2024 15:04, root wrote:
> From: Mrinmay Sarkar <[email protected]>
>
> Add global interrupt support in dt-bindings for SA8775p RC platform.
What is this global interrupt? Why wasn't it there before?
>
> Signed-off-by: Mrinmay Sarkar <[email protected]>
> ---
> .../devicetree/bindings/pci/qcom,pcie.yaml | 26 +++++++++++++++++--
> 1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index a93ab3b54066..d86fb63a2d2c 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -63,7 +63,7 @@ properties:
>
> interrupt-names:
> minItems: 1
> - maxItems: 8
> + maxItems: 9
>
> iommu-map:
> minItems: 1
> @@ -873,8 +873,30 @@ allOf:
> compatible:
> contains:
> enum:
> - - qcom,pcie-msm8996
> - qcom,pcie-sa8775p
> + then:
> + oneOf:
No need, drop.
Best regards,
Krzysztof
On 21.02.2024 15:28, Krzysztof Kozlowski wrote:
> On 21/02/2024 15:04, root wrote:
>> From: Mrinmay Sarkar <[email protected]>
>>
>> Add global interrupt support in dt-bindings for SA8775p RC platform.
>
> What is this global interrupt? Why wasn't it there before?
>
>>
>> Signed-off-by: Mrinmay Sarkar <[email protected]>
>> ---
>> .../devicetree/bindings/pci/qcom,pcie.yaml | 26 +++++++++++++++++--
>> 1 file changed, 24 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> index a93ab3b54066..d86fb63a2d2c 100644
>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> @@ -63,7 +63,7 @@ properties:
>>
>> interrupt-names:
>> minItems: 1
>> - maxItems: 8
>> + maxItems: 9
>>
>> iommu-map:
>> minItems: 1
>> @@ -873,8 +873,30 @@ allOf:
>> compatible:
>> contains:
>> enum:
>> - - qcom,pcie-msm8996
>> - qcom,pcie-sa8775p
>> + then:
>> + oneOf:
>
> No need, drop.
Moreover, I think this global irq should be present on all qc platforms
Konrad
On 21/02/2024 15:31, Konrad Dybcio wrote:
> On 21.02.2024 15:28, Krzysztof Kozlowski wrote:
>> On 21/02/2024 15:04, root wrote:
>>> From: Mrinmay Sarkar <[email protected]>
>>>
>>> Add global interrupt support in dt-bindings for SA8775p RC platform.
>>
>> What is this global interrupt? Why wasn't it there before?
>>
>>>
>>> Signed-off-by: Mrinmay Sarkar <[email protected]>
>>> ---
>>> .../devicetree/bindings/pci/qcom,pcie.yaml | 26 +++++++++++++++++--
>>> 1 file changed, 24 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> index a93ab3b54066..d86fb63a2d2c 100644
>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> @@ -63,7 +63,7 @@ properties:
>>>
>>> interrupt-names:
>>> minItems: 1
>>> - maxItems: 8
>>> + maxItems: 9
>>>
>>> iommu-map:
>>> minItems: 1
>>> @@ -873,8 +873,30 @@ allOf:
>>> compatible:
>>> contains:
>>> enum:
>>> - - qcom,pcie-msm8996
>>> - qcom,pcie-sa8775p
>>> + then:
>>> + oneOf:
>>
>> No need, drop.
>
> Moreover, I think this global irq should be present on all qc platforms
Heh, this will anyway conflict with my series:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/20240205-dt-bindings-pci-qcom-split-continued-v1-0-c333cab5eeea@linaro.org/
Best regards,
Krzysztof
On 2/21/2024 8:03 PM, Krzysztof Kozlowski wrote:
> On 21/02/2024 15:31, Konrad Dybcio wrote:
>> On 21.02.2024 15:28, Krzysztof Kozlowski wrote:
>>> On 21/02/2024 15:04, root wrote:
>>>> From: Mrinmay Sarkar <[email protected]>
>>>>
>>>> Add global interrupt support in dt-bindings for SA8775p RC platform.
>>> What is this global interrupt? Why wasn't it there before?
>>>
>>>> Signed-off-by: Mrinmay Sarkar <[email protected]>
>>>> ---
>>>> .../devicetree/bindings/pci/qcom,pcie.yaml | 26 +++++++++++++++++--
>>>> 1 file changed, 24 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>> index a93ab3b54066..d86fb63a2d2c 100644
>>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>> @@ -63,7 +63,7 @@ properties:
>>>>
>>>> interrupt-names:
>>>> minItems: 1
>>>> - maxItems: 8
>>>> + maxItems: 9
>>>>
>>>> iommu-map:
>>>> minItems: 1
>>>> @@ -873,8 +873,30 @@ allOf:
>>>> compatible:
>>>> contains:
>>>> enum:
>>>> - - qcom,pcie-msm8996
>>>> - qcom,pcie-sa8775p
>>>> + then:
>>>> + oneOf:
>>> No need, drop.
>> Moreover, I think this global irq should be present on all qc platforms
> Heh, this will anyway conflict with my series:
> https://lore.kernel.org/all/[email protected]/
>
> https://lore.kernel.org/all/20240205-dt-bindings-pci-qcom-split-continued-v1-0-c333cab5eeea@linaro.org/
Thanks for sharing the series. will make change top of your series on v2.
Thanks,
Mrinmay
> Best regards,
> Krzysztof
>
On 22/02/2024 14:46, Mrinmay Sarkar wrote:
>
> On 2/21/2024 8:03 PM, Krzysztof Kozlowski wrote:
>> On 21/02/2024 15:31, Konrad Dybcio wrote:
>>> On 21.02.2024 15:28, Krzysztof Kozlowski wrote:
>>>> On 21/02/2024 15:04, root wrote:
>>>>> From: Mrinmay Sarkar <[email protected]>
>>>>>
>>>>> Add global interrupt support in dt-bindings for SA8775p RC platform.
>>>> What is this global interrupt? Why wasn't it there before?
>>>>
>>>>> Signed-off-by: Mrinmay Sarkar <[email protected]>
>>>>> ---
>>>>> .../devicetree/bindings/pci/qcom,pcie.yaml | 26 +++++++++++++++++--
>>>>> 1 file changed, 24 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>>> index a93ab3b54066..d86fb63a2d2c 100644
>>>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>>> @@ -63,7 +63,7 @@ properties:
>>>>>
>>>>> interrupt-names:
>>>>> minItems: 1
>>>>> - maxItems: 8
>>>>> + maxItems: 9
>>>>>
>>>>> iommu-map:
>>>>> minItems: 1
>>>>> @@ -873,8 +873,30 @@ allOf:
>>>>> compatible:
>>>>> contains:
>>>>> enum:
>>>>> - - qcom,pcie-msm8996
>>>>> - qcom,pcie-sa8775p
>>>>> + then:
>>>>> + oneOf:
>>>> No need, drop.
>>> Moreover, I think this global irq should be present on all qc platforms
>> Heh, this will anyway conflict with my series:
>> https://lore.kernel.org/all/[email protected]/
>>
>> https://lore.kernel.org/all/20240205-dt-bindings-pci-qcom-split-continued-v1-0-c333cab5eeea@linaro.org/
>
> Thanks for sharing the series. will make change top of your series on v2.
In general: no need, whoever gets applied first, is lucky :)
Anyway they could be applied today.
Best regards,
Krzysztof