2013-08-31 06:45:49

by Libo Chen

Subject: [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put

decrease node device_node refcount after task completion

Signed-off-by: Libo Chen <[email protected]>
---
drivers/input/misc/twl4030-vibra.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
index 68a5f33..b8d1526 100644
--- a/drivers/input/misc/twl4030-vibra.c
+++ b/drivers/input/misc/twl4030-vibra.c
@@ -185,8 +185,10 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
if (pdata && pdata->coexist)
return true;

- if (of_find_node_by_name(node, "codec"))
+ if (of_find_node_by_name(node, "codec")) {
+ of_node_put(node);
return true;
+ }

return false;
}
--
1.7.1

2013-09-01 17:01:31

by Peter Ujfalusi

Subject: Re: [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put

On 08/31/2013 09:45 AM, Libo Chen wrote:
>
> decrease node device_node refcount after task completion
>
> Signed-off-by: Libo Chen <[email protected]>

Acked-by: Peter Ujfalusi <[email protected]>

> ---
> drivers/input/misc/twl4030-vibra.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
> index 68a5f33..b8d1526 100644
> --- a/drivers/input/misc/twl4030-vibra.c
> +++ b/drivers/input/misc/twl4030-vibra.c
> @@ -185,8 +185,10 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
> if (pdata && pdata->coexist)
> return true;
>
> - if (of_find_node_by_name(node, "codec"))
> + if (of_find_node_by_name(node, "codec")) {
> + of_node_put(node);
> return true;
> + }
>
> return false;
> }
>


--
P?ter