2018-09-27 01:42:33

by Leonardo Brás

[permalink] [raw]
Subject: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command

Creates new Makefile to avoid building driver if
'make drivers/oprofile/' is called directly.

This driver is usually built from arch/$ARCH and seems to have
no meaning building alone.

Signed-off-by: Leonardo Brás <[email protected]>
---
drivers/oprofile/Makefile | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 drivers/oprofile/Makefile

diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
new file mode 100644
index 000000000000..acaed2ad6eee
--- /dev/null
+++ b/drivers/oprofile/Makefile
@@ -0,0 +1,2 @@
+#Does nothing, since the source is called from arch/$ARCH/ tree.
+
--
2.19.0



2018-09-27 06:37:14

by Rolf Eike Beer

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command

Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo Br?s:
> Creates new Makefile to avoid building driver if
> 'make drivers/oprofile/' is called directly.
>
> This driver is usually built from arch/$ARCH and seems to have
> no meaning building alone.
>
> Signed-off-by: Leonardo Br?s <[email protected]>
> ---
> drivers/oprofile/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
> create mode 100644 drivers/oprofile/Makefile
>
> diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
> new file mode 100644
> index 000000000000..acaed2ad6eee
> --- /dev/null
> +++ b/drivers/oprofile/Makefile
> @@ -0,0 +1,2 @@
> +#Does nothing, since the source is called from arch/$ARCH/ tree.
> +

Now there is a blank line where it does not need to be.

Eike


Attachments:
signature.asc (201.00 B)
This is a digitally signed message part.

2018-09-27 11:23:46

by Leonardo Brás

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command

Hello Rolf,

On Thu, Sep 27, 2018 at 3:34 AM, Rolf Eike Beer <[email protected]> wrote:
> Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo Brás:
>> Creates new Makefile to avoid building driver if
>> 'make drivers/oprofile/' is called directly.
>>
>> This driver is usually built from arch/$ARCH and seems to have
>> no meaning building alone.
>>
>> Signed-off-by: Leonardo Brás <[email protected]>
>> ---
>> drivers/oprofile/Makefile | 2 ++
>> 1 file changed, 2 insertions(+)
>> create mode 100644 drivers/oprofile/Makefile
>>
>> diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
>> new file mode 100644
>> index 000000000000..acaed2ad6eee
>> --- /dev/null
>> +++ b/drivers/oprofile/Makefile
>> @@ -0,0 +1,2 @@
>> +#Does nothing, since the source is called from arch/$ARCH/ tree.
>> +
>
> Now there is a blank line where it does not need to be.
>
> Eike

Oh, it's a Makefile, and as all text files, it have to end with newline.
If I am wrong, please let me know.

Thanks for your feedback,

Leonardo Bras,

2018-09-27 13:16:50

by Rolf Eike Beer

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command

Am 2018-09-27 13:23, schrieb Leonardo Bras:
> Hello Rolf,
>
> On Thu, Sep 27, 2018 at 3:34 AM, Rolf Eike Beer <[email protected]>
> wrote:
>> Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo
>> Brás:
>>> Creates new Makefile to avoid building driver if
>>> 'make drivers/oprofile/' is called directly.
>>>
>>> This driver is usually built from arch/$ARCH and seems to have
>>> no meaning building alone.
>>>
>>> Signed-off-by: Leonardo Brás <[email protected]>
>>> ---
>>> drivers/oprofile/Makefile | 2 ++
>>> 1 file changed, 2 insertions(+)
>>> create mode 100644 drivers/oprofile/Makefile
>>>
>>> diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
>>> new file mode 100644
>>> index 000000000000..acaed2ad6eee
>>> --- /dev/null
>>> +++ b/drivers/oprofile/Makefile
>>> @@ -0,0 +1,2 @@
>>> +#Does nothing, since the source is called from arch/$ARCH/ tree.
>>> +
>>
>> Now there is a blank line where it does not need to be.
>>
>> Eike
>
> Oh, it's a Makefile, and as all text files, it have to end with
> newline.
> If I am wrong, please let me know.

No, that's fine. But it means it has to have one LF after "tree.". It
had none, now it hat 2.

Eike

2018-09-28 01:32:31

by Leonardo Brás

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command

Hello Eike,

> No, that's fine. But it means it has to have one LF after "tree.". It had
> none, now it hat 2.
>
> Eike

Oh, i haven't noticed. Sorry for the trouble.

Thanks for the feedback!

Leonardo Brás

2018-09-28 01:56:05

by Leonardo Brás

[permalink] [raw]
Subject: Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command

Hello Eike,

> > Oh, it's a Makefile, and as all text files, it have to end with newline.
> > If I am wrong, please let me know.
>
> No, that's fine. But it means it has to have one LF after "tree.". It had
> none, now it hat 2.
>
> Eike

Oh, i haven't noticed. Sorry for the trouble.

Thanks for the feedback!

Leonardo Bras