On 12/18/2023 3:26 PM, Stefan Wahren wrote:
> Most of the users doesn't know the expected signature of the QCA700x.
> So provide it within the error message. Btw use lowercase for hex as
> in the rest of the driver.
>
> Signed-off-by: Stefan Wahren <[email protected]>
> ---
> drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
> index 6d2859aad921..c5d240fe4146 100644
> --- a/drivers/net/ethernet/qualcomm/qca_spi.c
> +++ b/drivers/net/ethernet/qualcomm/qca_spi.c
> @@ -1005,8 +1005,8 @@ qca_spi_probe(struct spi_device *spi)
> qcaspi_read_register(qca, SPI_REG_SIGNATURE, &signature);
>
> if (signature != QCASPI_GOOD_SIGNATURE) {
> - dev_err(&spi->dev, "Invalid signature (0x%04X)\n",
> - signature);
> + dev_err(&spi->dev, "Invalid signature (expected 0x%04x, read 0x%04x)\n",
> + QCASPI_GOOD_SIGNATURE, signature);
Makes sense. Helpful to see whats expected vs whats there.
Reviewed-by: Jacob Keller <[email protected]>