2014-06-02 18:37:55

by Eric Ernst

Subject: Re: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

On 14-05-30 01:48 AM, Mika Westerberg wrote:
> On Tue, May 27, 2014 at 12:26:44PM -0700, [email protected] wrote:
>> From: Eric Ernst <[email protected]>
>>
>> For Baytrail, you should never set a GPIO set to direct_irq
>> to output mode. When direct_irq_en is set for a GPIO, it is
>> tied directly to an APIC internally, and making the pad output
>> does not make any sense. Assert a WARN() in the event this happens.
> Can't we just clear that flag when the GPIO is requested? Or is this
> something which can't be done at this point?
The IRQ setting for that register (the IRQ wiring via direct_irq_en)
should be set statically on boot, and should not be changed, let alone
allowing for multiple changes during runtime.

Eric

2014-06-02 19:13:27

by Mika Westerberg

Subject: Re: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

On Mon, Jun 02, 2014 at 11:35:16AM -0700, eric ernst wrote:
> On 14-05-30 01:48 AM, Mika Westerberg wrote:
> >On Tue, May 27, 2014 at 12:26:44PM -0700, [email protected] wrote:
> >>From: Eric Ernst <[email protected]>
> >>
> >>For Baytrail, you should never set a GPIO set to direct_irq
> >>to output mode. When direct_irq_en is set for a GPIO, it is
> >>tied directly to an APIC internally, and making the pad output
> >>does not make any sense. Assert a WARN() in the event this happens.
> >Can't we just clear that flag when the GPIO is requested? Or is this
> >something which can't be done at this point?
> The IRQ setting for that register (the IRQ wiring via direct_irq_en) should
> be set statically on boot, and should not be changed, let alone allowing for
> multiple changes during runtime.

OK.

Please then follow the coding conventions documented in
Documentation/SubmittingPatches and also check that
scripts/checkpatch.pl doesn't complain too much.

2014-06-02 19:14:32

by Mika Westerberg

Subject: Re: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

On Mon, Jun 02, 2014 at 10:13:22PM +0300, Mika Westerberg wrote:
> On Mon, Jun 02, 2014 at 11:35:16AM -0700, eric ernst wrote:
> > On 14-05-30 01:48 AM, Mika Westerberg wrote:
> > >On Tue, May 27, 2014 at 12:26:44PM -0700, [email protected] wrote:
> > >>From: Eric Ernst <[email protected]>
> > >>
> > >>For Baytrail, you should never set a GPIO set to direct_irq
> > >>to output mode. When direct_irq_en is set for a GPIO, it is
> > >>tied directly to an APIC internally, and making the pad output
> > >>does not make any sense. Assert a WARN() in the event this happens.
> > >Can't we just clear that flag when the GPIO is requested? Or is this
> > >something which can't be done at this point?
> > The IRQ setting for that register (the IRQ wiring via direct_irq_en) should
> > be set statically on boot, and should not be changed, let alone allowing for
> > multiple changes during runtime.
>
> OK.
>
> Please then follow the coding conventions documented in
> Documentation/SubmittingPatches and also check that

Documentation/CodingStyle, that is.

> scripts/checkpatch.pl doesn't complain too much.