2014-06-09 21:01:20

by Stratos Karafotis

Subject: [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local

Since we never remove sysfs entry, we can make the intel_pstate_kobject
local.

Signed-off-by: Stratos Karafotis <[email protected]>
---
drivers/cpufreq/intel_pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index fa44f0f..9533fff 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -387,10 +387,10 @@ static struct attribute *intel_pstate_attributes[] = {
static struct attribute_group intel_pstate_attr_group = {
.attrs = intel_pstate_attributes,
};
-static struct kobject *intel_pstate_kobject;

static void intel_pstate_sysfs_expose_params(void)
{
+ struct kobject *intel_pstate_kobject;
int rc;

intel_pstate_kobject = kobject_create_and_add("intel_pstate",
--
1.9.3

2014-06-09 21:07:28

by David Rientjes

Subject: Re: [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local

On Tue, 10 Jun 2014, Stratos Karafotis wrote:

> Since we never remove sysfs entry, we can make the intel_pstate_kobject
> local.
>

For even more savings, this function and
intel_pstate_debug_expose_params() can be annotated with __init and freed
after bootstrap.

> Signed-off-by: Stratos Karafotis <[email protected]>
> ---
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index fa44f0f..9533fff 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -387,10 +387,10 @@ static struct attribute *intel_pstate_attributes[] = {
> static struct attribute_group intel_pstate_attr_group = {
> .attrs = intel_pstate_attributes,
> };
> -static struct kobject *intel_pstate_kobject;
>
> static void intel_pstate_sysfs_expose_params(void)
> {
> + struct kobject *intel_pstate_kobject;
> int rc;
>
> intel_pstate_kobject = kobject_create_and_add("intel_pstate",

2014-06-09 21:24:34

by Stratos Karafotis

Subject: Re: [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local

On 10/06/2014 12:07 πμ, David Rientjes wrote:
> On Tue, 10 Jun 2014, Stratos Karafotis wrote:
>
>> Since we never remove sysfs entry, we can make the intel_pstate_kobject
>> local.
>>
>
> For even more savings, this function and
> intel_pstate_debug_expose_params() can be annotated with __init and freed
> after bootstrap.

Thanks for your comment, David!
I will do this in v2.


Stratos

2014-06-10 17:19:25

by Dirk Brandewie

Subject: Re: [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local

On 06/09/2014 02:01 PM, Stratos Karafotis wrote:
> Since we never remove sysfs entry, we can make the intel_pstate_kobject
> local.
>
> Signed-off-by: Stratos Karafotis <[email protected]>
Acked-by: Dirk Brandewie <[email protected]>

> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index fa44f0f..9533fff 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -387,10 +387,10 @@ static struct attribute *intel_pstate_attributes[] = {
> static struct attribute_group intel_pstate_attr_group = {
> .attrs = intel_pstate_attributes,
> };
> -static struct kobject *intel_pstate_kobject;
>
> static void intel_pstate_sysfs_expose_params(void)
> {
> + struct kobject *intel_pstate_kobject;
> int rc;
>
> intel_pstate_kobject = kobject_create_and_add("intel_pstate",
>