2021-03-12 13:04:27

by Geert Uytterhoeven

Subject: [PATCH 2/3] regulator: bd9571mwv: Fix regulator name printed on registration failure

If a regulator fails to register, the driver prints an error message
like:

bd9571mwv-regulator bd9571mwv-regulator.6.auto: failed to register bd9571mwv-regulator regulator

However, the platform device's name is already printed as part of
dev_err(), and does not allow the user to distinguish among the various
regulators that are part of the PMIC.

Fix this by printing regulator_desc.name instead, to change the message
like:

bd9571mwv-regulator bd9571mwv-regulator.6.auto: failed to register DVFS regulator

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/regulator/bd9571mwv-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c
index 13393cdc6be1497e..a4d406022587d59d 100644
--- a/drivers/regulator/bd9571mwv-regulator.c
+++ b/drivers/regulator/bd9571mwv-regulator.c
@@ -301,7 +301,7 @@ static int bd9571mwv_regulator_probe(struct platform_device *pdev)
&config);
if (IS_ERR(rdev)) {
dev_err(&pdev->dev, "failed to register %s regulator\n",
- pdev->name);
+ regulators[i].name);
return PTR_ERR(rdev);
}
}
--
2.25.1

2021-03-15 05:52:25

by Matti Vaittinen

Subject: Re: [PATCH 2/3] regulator: bd9571mwv: Fix regulator name printed on registration failure

On Fri, 2021-03-12 at 14:02 +0100, Geert Uytterhoeven wrote:
> If a regulator fails to register, the driver prints an error message
> like:
>
> bd9571mwv-regulator bd9571mwv-regulator.6.auto: failed to
> register bd9571mwv-regulator regulator
>
> However, the platform device's name is already printed as part of
> dev_err(), and does not allow the user to distinguish among the
> various
> regulators that are part of the PMIC.
>
> Fix this by printing regulator_desc.name instead, to change the
> message
> like:
>
> bd9571mwv-regulator bd9571mwv-regulator.6.auto: failed to
> register DVFS regulator
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Matti Vaittinen <[email protected]>