2015-02-05 17:47:24

by Romain Perier

Subject: [PATCH] usb: dwc2: Register interrupt handler only once gadget is correctly initialized

Don't register interrupt handler becore usb gadget is correctly initialized.
For some embedded platforms which don't have a usb-phy it crashes the driver
because an interrupt is emitted with non-initiliazed hardware.
According to devm_request_irq documentation, an interrupt can be emitted
at any time once the interrupt is registered, so we have to care about driver
and hardware initialization.

Signed-off-by: Romain Perier <[email protected]>
---
drivers/usb/dwc2/platform.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index ae095f0..b26cf8c 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -196,14 +196,6 @@ static int dwc2_driver_probe(struct platform_device *dev)
return irq;
}

- dev_dbg(hsotg->dev, "registering common handler for irq%d\n",
- irq);
- retval = devm_request_irq(hsotg->dev, irq,
- dwc2_handle_common_intr, IRQF_SHARED,
- dev_name(hsotg->dev), hsotg);
- if (retval)
- return retval;
-
res = platform_get_resource(dev, IORESOURCE_MEM, 0);
hsotg->regs = devm_ioremap_resource(&dev->dev, res);
if (IS_ERR(hsotg->regs))
@@ -237,6 +229,15 @@ static int dwc2_driver_probe(struct platform_device *dev)
retval = dwc2_gadget_init(hsotg, irq);
if (retval)
return retval;
+
+ dev_dbg(hsotg->dev, "registering common handler for irq%d\n",
+ irq);
+ retval = devm_request_irq(hsotg->dev, irq,
+ dwc2_handle_common_intr, IRQF_SHARED,
+ dev_name(hsotg->dev), hsotg);
+ if (retval)
+ return retval;
+
retval = dwc2_hcd_init(hsotg, irq, params);
if (retval)
return retval;
--
1.9.1

2015-02-05 18:04:48

by Sergei Shtylyov

Subject: Re: [PATCH] usb: dwc2: Register interrupt handler only once gadget is correctly initialized

Hello.

On 02/05/2015 08:47 PM, Romain Perier wrote:

> Don't register interrupt handler becore usb gadget is correctly initialized.

s/becore/before/?

> For some embedded platforms which don't have a usb-phy it crashes the driver
> because an interrupt is emitted with non-initiliazed hardware.

s/non-initiliazed/non-initialized/.

> According to devm_request_irq documentation, an interrupt can be emitted
> at any time once the interrupt is registered, so we have to care about driver
> and hardware initialization.

> Signed-off-by: Romain Perier <[email protected]>

[...]

WBR, Sergei