2015-02-14 17:21:12

by Paul Bolle

[permalink] [raw]
Subject: MIPS: CONFIG_MIPS_R6?

Your commits 430857eae56c ("MIPS: mm: Add MIPS R6 instruction
encodings") and 90163242784b ("MIPS: kernel: unaligned: Add support for
the MIPS R6") are included in yesterday's linux-next (ie,
next-20150213). I noticed because a script I use to check linux-next
spotted a problem with it.

These commits added three references to CONFIG_MIPS_R6, were probably
CONFIG_CPU_MIPSR6 was intended. One reference is in a comment, which
should be trivial to get fixed. The other two references are in
(negative) preprocessor checks. It's not certain, at least not to me,
how these should be fixed.


Paul Bolle


2015-02-15 01:23:00

by Leonid Yegoshin

[permalink] [raw]
Subject: Re: MIPS: CONFIG_MIPS_R6?

On 02/14/2015 09:21 AM, Paul Bolle wrote:
> Your commits 430857eae56c ("MIPS: mm: Add MIPS R6 instruction
> encodings") and 90163242784b ("MIPS: kernel: unaligned: Add support for
> the MIPS R6") are included in yesterday's linux-next (ie,
> next-20150213). I noticed because a script I use to check linux-next
> spotted a problem with it.
>
> These commits added three references to CONFIG_MIPS_R6, were probably
> CONFIG_CPU_MIPSR6 was intended. One reference is in a comment, which
> should be trivial to get fixed. The other two references are in
> (negative) preprocessor checks. It's not certain, at least not to me,
> how these should be fixed.
>
>
> Paul Bolle

Yes, please.

- Leonid.

2015-02-16 08:39:35

by Paul Bolle

[permalink] [raw]
Subject: Re: MIPS: CONFIG_MIPS_R6?

Leonid,

On Sat, 2015-02-14 at 17:22 -0800, Leonid Yegoshin wrote:
> On 02/14/2015 09:21 AM, Paul Bolle wrote:
> > Your commits 430857eae56c ("MIPS: mm: Add MIPS R6 instruction
> > encodings") and 90163242784b ("MIPS: kernel: unaligned: Add support for
> > the MIPS R6") are included in yesterday's linux-next (ie,
> > next-20150213). I noticed because a script I use to check linux-next
> > spotted a problem with it.
> >
> > These commits added three references to CONFIG_MIPS_R6, were probably
> > CONFIG_CPU_MIPSR6 was intended. One reference is in a comment, which
> > should be trivial to get fixed. The other two references are in
> > (negative) preprocessor checks. It's not certain, at least not to me,
> > how these should be fixed.
> >
> >
> > Paul Bolle
>
> Yes, please.

The obvious fix (ie, three times s/CONFIG_MIPS_R6/CONFIG_CPU_MIPSR6/)
isn't trivial and requires run time testing, which I have no idea how to
do, sorry.


Paul Bolle