2015-04-01 07:10:47

by Yunlong Song

[permalink] [raw]
Subject: Re: [PATCH 2/9] perf sched replay: Increase the MAX_PID value to fix assertion failure problem

On 2015/3/31 22:25, David Ahern wrote:
> On 3/31/15 7:46 AM, Yunlong Song wrote:
>> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
>> index a1893e8..c466104 100644
>> --- a/tools/perf/builtin-sched.c
>> +++ b/tools/perf/builtin-sched.c
>> @@ -28,7 +28,7 @@
>> #define MAX_CPUS 4096
>> #define COMM_LEN 20
>> #define SYM_LEN 129
>> -#define MAX_PID 65536
>> +#define MAX_PID 1024000
>>
>> struct sched_atom;
>
> # cat /proc/sys/kernel/pid_max
> 1048576
>
> so your proposed change is still not high enough for what I need.
>
> It would be best to make it dynamic, not static, with run time reallocations as needed.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
Yes, please see my 3rd and 4th patch in the patch sets, which dynamic allocate the memory
in run time.

--
Thanks,
Yunlong Song