2015-04-03 08:44:15

by Nicolas Ferre

[permalink] [raw]
Subject: Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1

Le 31/03/2015 10:56, Nicolas Ferre a ?crit :
> After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
> the macb1 interface refuses to work properly because it tries
> to cling to address 0 which isn't able to communicate in broadcast with
> the mac anymore. The micrel phy on the board is actually configured
> to show up at address 1.
> Adding the phy node and its real address fixes the issue.
>
> Signed-off-by: Nicolas Ferre <[email protected]>
> Cc: Johan Hovold <[email protected]>
> Cc: <[email protected]> #3.19
> ---

Arnd, Olof, Kevin,

It seems late but, is it possible to queue this patch as a 4.0 fixes?

Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
by u-boot previously.

Bye,

> arch/arm/boot/dts/at91-sama5d3_xplained.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> index fec1fca2ad66..6c4bc53cbf4e 100644
> --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> @@ -167,7 +167,13 @@
>
> macb1: ethernet@f802c000 {
> phy-mode = "rmii";
> + #address-cells = <1>;
> + #size-cells = <0>;
> status = "okay";
> +
> + ethernet-phy@1 {
> + reg = <0x1>;
> + };
> };
>
> dbgu: serial@ffffee00 {
>


--
Nicolas Ferre


2015-04-03 20:55:13

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1

On Fri, Apr 03, 2015 at 10:43:40AM +0200, Nicolas Ferre wrote:
> Le 31/03/2015 10:56, Nicolas Ferre a ?crit :
> > After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
> > the macb1 interface refuses to work properly because it tries
> > to cling to address 0 which isn't able to communicate in broadcast with
> > the mac anymore. The micrel phy on the board is actually configured
> > to show up at address 1.
> > Adding the phy node and its real address fixes the issue.
> >
> > Signed-off-by: Nicolas Ferre <[email protected]>
> > Cc: Johan Hovold <[email protected]>
> > Cc: <[email protected]> #3.19
> > ---
>
> Arnd, Olof, Kevin,
>
> It seems late but, is it possible to queue this patch as a 4.0 fixes?
>
> Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
> by u-boot previously.

Sure, resend it to [email protected].


-Olof

2015-04-03 21:56:12

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1

On Fri, Apr 03, 2015 at 01:55:07PM -0700, Olof Johansson wrote:
> On Fri, Apr 03, 2015 at 10:43:40AM +0200, Nicolas Ferre wrote:
> > Le 31/03/2015 10:56, Nicolas Ferre a ?crit :
> > > After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
> > > the macb1 interface refuses to work properly because it tries
> > > to cling to address 0 which isn't able to communicate in broadcast with
> > > the mac anymore. The micrel phy on the board is actually configured
> > > to show up at address 1.
> > > Adding the phy node and its real address fixes the issue.
> > >
> > > Signed-off-by: Nicolas Ferre <[email protected]>
> > > Cc: Johan Hovold <[email protected]>
> > > Cc: <[email protected]> #3.19
> > > ---
> >
> > Arnd, Olof, Kevin,
> >
> > It seems late but, is it possible to queue this patch as a 4.0 fixes?
> >
> > Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
> > by u-boot previously.
>
> Sure, resend it to [email protected].

Nevermind, I ended up picking it up from the list. Applied.


-Olof

2015-04-04 12:47:51

by Nicolas Ferre

[permalink] [raw]
Subject: Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1

Le 03/04/2015 23:56, Olof Johansson a ?crit :
> On Fri, Apr 03, 2015 at 01:55:07PM -0700, Olof Johansson wrote:
>> On Fri, Apr 03, 2015 at 10:43:40AM +0200, Nicolas Ferre wrote:
>>> Le 31/03/2015 10:56, Nicolas Ferre a ?crit :
>>>> After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
>>>> the macb1 interface refuses to work properly because it tries
>>>> to cling to address 0 which isn't able to communicate in broadcast with
>>>> the mac anymore. The micrel phy on the board is actually configured
>>>> to show up at address 1.
>>>> Adding the phy node and its real address fixes the issue.
>>>>
>>>> Signed-off-by: Nicolas Ferre <[email protected]>
>>>> Cc: Johan Hovold <[email protected]>
>>>> Cc: <[email protected]> #3.19
>>>> ---
>>>
>>> Arnd, Olof, Kevin,
>>>
>>> It seems late but, is it possible to queue this patch as a 4.0 fixes?
>>>
>>> Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
>>> by u-boot previously.
>>
>> Sure, resend it to [email protected].
>
> Nevermind, I ended up picking it up from the list. Applied.

Cool: thanks Olof!

Bye,

--
Nicolas Ferre