2015-04-09 14:46:54

by Tim Bird

[permalink] [raw]
Subject: Re: [PATCH 1/3] kernel: Add a new config option to remove command line parsing



On 04/01/2015 07:34 AM, Iulia Manda wrote:
> This patch introduces CONFIG_CMDLINE_PARSE option which conditionally compiles
> the support for parsing kernel command line arguments. The corresponding
> functions that actually do the parsing will be compiled out.
>
> This is used when no parameters will be specified neither at compile time nor at
> boot time.
>
> Bloat-o-meter output (compared to the preivous version in which builtin cmdline
> was also set to 'Y'):
>
> add/remove: 0/8 grow/shrink: 0/6 up/down: 0/-3669 (-3669)

I think this is great stuff. (Of course, having research something like this
previously, I'm a bit biased.)

It's very nice to have the Bloat-o-meter output for these kernel size shrinking
patches.

The patch itself looks very straightforward, and I don't see any problems
in a visual inspection.

You can add a Reviewed-by: Tim Bird <[email protected]> to this patch.

I'd like to be able to point people to this on the mailing list. In the future
can you make sure to CC: <[email protected]>, so there's a reference
on lkml.org I can point people to?

Thanks for this great work!
-- Tim