2015-06-26 20:58:49

by Florian Fainelli

Subject: Re: [PATCH] ARM: BCM: Enable NAND support for iProc SoCs

On 28/05/15 18:09, Ray Jui wrote:
> Select CONFIG_MTD_NAND_BRCMNAND for all iProc SoCs

In fact, this patch creates an unmet dependency problem, we also need to
select MTD and MTD_NAND otherwise we run into a linking error while
building the brcmnand driver:

LD init/built-in.o
drivers/built-in.o: In function `brcmnand_remove':
/home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:2234:
undefined reference to `nand_release'
drivers/built-in.o: In function `brcmnand_init_cs':
/home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:1933:
undefined reference to `nand_scan_ident'
/home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:1958:
undefined reference to `nand_scan_tail'
Makefile:931: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1

I will take care of that and send a fix for 4.2.

>
> Signed-off-by: Ray Jui <[email protected]>
> ---
> arch/arm/mach-bcm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index 8b11f44..1268e35 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -19,6 +19,7 @@ config ARCH_BCM_IPROC
> select ARCH_REQUIRE_GPIOLIB
> select ARM_AMBA
> select PINCTRL
> + select MTD_NAND_BRCMNAND
> help
> This enables support for systems based on Broadcom IPROC architected SoCs.
> The IPROC complex contains one or more ARM CPUs along with common
>


--
Florian

2015-06-29 16:38:14

by Ray Jui

Subject: Re: [PATCH] ARM: BCM: Enable NAND support for iProc SoCs

Hi Florian,

On 6/26/2015 1:55 PM, Florian Fainelli wrote:
> On 28/05/15 18:09, Ray Jui wrote:
>> Select CONFIG_MTD_NAND_BRCMNAND for all iProc SoCs
>
> In fact, this patch creates an unmet dependency problem, we also need to
> select MTD and MTD_NAND otherwise we run into a linking error while
> building the brcmnand driver:
>
> LD init/built-in.o
> drivers/built-in.o: In function `brcmnand_remove':
> /home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:2234:
> undefined reference to `nand_release'
> drivers/built-in.o: In function `brcmnand_init_cs':
> /home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:1933:
> undefined reference to `nand_scan_ident'
> /home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:1958:
> undefined reference to `nand_scan_tail'
> Makefile:931: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
>
> I will take care of that and send a fix for 4.2.
>

When I tested this, I tested against multi_v7_defconfig where MTD and
MTD_NAND were enabled in the defconfig, so I did not see this problem.

Thanks a lot for helping to fix this.

Ray