2015-08-15 04:42:14

by Chase Metzger

Subject: [PATCH] usb: core: hub: Removed some warnings generated by checkpatch.pl

Removed some checkpatch.pl warnings saying there was an unwanted space between
function names and their arguments.

Signed-off-by: Chase Metzger <[email protected]>
---
drivers/usb/core/hub.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 38cb6d3..b9cab51 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -4218,7 +4218,7 @@ static int hub_enable_device(struct usb_device *udev)
* but it is still necessary to lock the port.
*/
static int
-hub_port_init (struct usb_hub *hub, struct usb_device *udev, int port1,
+hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1,
int retry_counter)
{
struct usb_device *hdev = hub->hdev;
@@ -4522,7 +4522,7 @@ fail:
}

static void
-check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1)
+check_highspeed(struct usb_hub *hub, struct usb_device *udev, int port1)
{
struct usb_qualifier_descriptor *qual;
int status;
@@ -4530,11 +4530,11 @@ check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1)
if (udev->quirks & USB_QUIRK_DEVICE_QUALIFIER)
return;

- qual = kmalloc (sizeof *qual, GFP_KERNEL);
+ qual = kmalloc(sizeof *qual, GFP_KERNEL);
if (qual == NULL)
return;

- status = usb_get_descriptor (udev, USB_DT_DEVICE_QUALIFIER, 0,
+ status = usb_get_descriptor udev, USB_DT_DEVICE_QUALIFIER, 0,
qual, sizeof *qual);
if (status == sizeof *qual) {
dev_info(&udev->dev, "not running at top speed; "
@@ -4550,7 +4550,7 @@ check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1)
}

static unsigned
-hub_power_remaining (struct usb_hub *hub)
+hub_power_remaining(struct usb_hub *hub)
{
struct usb_device *hdev = hub->hdev;
int remaining;
@@ -4737,7 +4737,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus,
if (le16_to_cpu(udev->descriptor.bcdUSB) >= 0x0200
&& udev->speed == USB_SPEED_FULL
&& highspeed_hubs != 0)
- check_highspeed (hub, udev, port1);
+ check_highspeed(hub, udev, port1);

/* Store the parent's children[] pointer. At this point
* udev becomes globally accessible, although presumably
@@ -5111,7 +5111,7 @@ static const struct usb_device_id hub_id_table[] = {
{ } /* Terminating entry */
};

-MODULE_DEVICE_TABLE (usb, hub_id_table);
+MODULE_DEVICE_TABLE(usb, hub_id_table);

static struct usb_driver hub_driver = {
.name = "hub",
@@ -5223,7 +5223,7 @@ static int descriptors_changed(struct usb_device *udev,
changed = 1;
break;
}
- if (memcmp (buf, udev->rawdescriptors[index], old_length)
+ if (memcmp(buf, udev->rawdescriptors[index], old_length)
!= 0) {
dev_dbg(&udev->dev, "config index %d changed (#%d)\n",
index,
--
2.1.4

2015-08-15 05:10:27

by Lars Melin

Subject: Re: [PATCH] usb: core: hub: Removed some warnings generated by checkpatch.pl

On 2015-08-15 11:41, Chase Metzger wrote:
> Removed some checkpatch.pl warnings saying there was an unwanted space between
> function names and their arguments.
>
> Signed-off-by: Chase Metzger <[email protected]>
> ---
> drivers/usb/core/hub.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 38cb6d3..b9cab51 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -4218,7 +4218,7 @@ static int hub_enable_device(struct usb_device *udev)
> * but it is still necessary to lock the port.
> */
> static int
> -hub_port_init (struct usb_hub *hub, struct usb_device *udev, int port1,
> +hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1,
> int retry_counter)
> {
> struct usb_device *hdev = hub->hdev;
> @@ -4522,7 +4522,7 @@ fail:
> }
>
> static void
> -check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1)
> +check_highspeed(struct usb_hub *hub, struct usb_device *udev, int port1)
> {
> struct usb_qualifier_descriptor *qual;
> int status;
> @@ -4530,11 +4530,11 @@ check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1)
> if (udev->quirks & USB_QUIRK_DEVICE_QUALIFIER)
> return;
>
> - qual = kmalloc (sizeof *qual, GFP_KERNEL);
> + qual = kmalloc(sizeof *qual, GFP_KERNEL);
> if (qual == NULL)
> return;
>
> - status = usb_get_descriptor (udev, USB_DT_DEVICE_QUALIFIER, 0,
> + status = usb_get_descriptor udev, USB_DT_DEVICE_QUALIFIER, 0,
> qual, sizeof *qual);

If you had test compiled you would have got an unbalanced parenthesis
error here. So you didn't test your patch..