2024-03-28 22:26:58

by Tahera Fahimi

Subject: [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis

Mute the following checkpatch error:
CHECK: Alignment should match open parenthesis

Signed-off-by: Tahera Fahimi <[email protected]>
---
drivers/staging/gdm724x/gdm_tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 15c246d3b1a3..bd80cd48fb44 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -272,8 +272,8 @@ int register_lte_tty_driver(void)
int ret;

for (i = 0; i < TTY_MAX_COUNT; i++) {
- tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
- TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
+ tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
+ TTY_DRIVER_DYNAMIC_DEV);
if (IS_ERR(tty_driver))
return PTR_ERR(tty_driver);

--
2.34.1

2024-03-28 22:52:40

by Alison Schofield

Subject: Re: [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis

On Thu, Mar 28, 2024 at 04:26:47PM -0600, TaheraFahimi wrote:
> Mute the following checkpatch error:
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Tahera Fahimi <[email protected]>

Tahera,

I'm seeing this from checkpatch:

WARNING: From:/Signed-off-by: email name mismatch: 'From: TaheraFahimi <[email protected]>' != 'Signed-off-by: Tahera Fahimi <[email protected]>'

Folks sometimes miss checkpatch reports if they only run checkpatch
on their head commit. Please run it on the formatted patch before
sending it.

Please refer to checkpatch documentation, but if it's useful, here's
what I do:

While developing a patch do this:
$ git show HEAD | scripts/checkpatch.pl --strict --codespell

Confirm with this before sending a patch to a mailing list:
$ scripts/checkpatch.pl --no-tree --strict --codespell $1
($1 is the formatted patch and that location is usually out of tree
in my development environment.)

--Alison

> ---
> drivers/staging/gdm724x/gdm_tty.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 15c246d3b1a3..bd80cd48fb44 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -272,8 +272,8 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);
> if (IS_ERR(tty_driver))
> return PTR_ERR(tty_driver);
>
> --
> 2.34.1
>
>

2024-04-02 06:50:23

by Dan Carpenter

Subject: Re: [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis

On Thu, Mar 28, 2024 at 04:26:47PM -0600, TaheraFahimi wrote:
> Mute the following checkpatch error:
> CHECK: Alignment should match open parenthesis

It's not aligned either before or after. It should have been:

[tab][tab][tab][tab][tab][space][space][space][space][space][space]TTY_DRIVER_...

>
> Signed-off-by: Tahera Fahimi <[email protected]>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 15c246d3b1a3..bd80cd48fb44 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -272,8 +272,8 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);

"TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV" goes together. Don't
split that up over two lines. Checkpatch is a tool which is supposed to
help readability. It's not a ruler which must be obeyed. If checkpatch
tells you to do something which makes the code less readable then just
ignore it.

regards,
dan carpenter