2024-04-05 16:25:39

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 1/1] gpio: wcove: Use -ENOTSUPP consistently

The GPIO library expects the drivers to return -ENOTSUPP in some
cases and not using analogue POSIX code. Make the driver to follow
this.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/gpio/gpio-wcove.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c
index c18b6b47384f..94ca9d03c094 100644
--- a/drivers/gpio/gpio-wcove.c
+++ b/drivers/gpio/gpio-wcove.c
@@ -104,7 +104,7 @@ static inline int to_reg(int gpio, enum ctrl_register type)
unsigned int reg = type == CTRL_IN ? GPIO_IN_CTRL_BASE : GPIO_OUT_CTRL_BASE;

if (gpio >= WCOVE_GPIO_NUM)
- return -EOPNOTSUPP;
+ return -ENOTSUPP;

return reg + gpio;
}
--
2.43.0.rc1.1.gbec44491f096



Subject: Re: [PATCH v1 1/1] gpio: wcove: Use -ENOTSUPP consistently


On 4/5/24 9:25 AM, Andy Shevchenko wrote:
> The GPIO library expects the drivers to return -ENOTSUPP in some
> cases and not using analogue POSIX code. Make the driver to follow
> this.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---

Looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <[email protected]>

> drivers/gpio/gpio-wcove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c
> index c18b6b47384f..94ca9d03c094 100644
> --- a/drivers/gpio/gpio-wcove.c
> +++ b/drivers/gpio/gpio-wcove.c
> @@ -104,7 +104,7 @@ static inline int to_reg(int gpio, enum ctrl_register type)
> unsigned int reg = type == CTRL_IN ? GPIO_IN_CTRL_BASE : GPIO_OUT_CTRL_BASE;
>
> if (gpio >= WCOVE_GPIO_NUM)
> - return -EOPNOTSUPP;
> + return -ENOTSUPP;
>
> return reg + gpio;
> }

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer


2024-04-05 20:17:29

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] gpio: wcove: Use -ENOTSUPP consistently

On Fri, Apr 05, 2024 at 09:46:40AM -0700, Kuppuswamy Sathyanarayanan wrote:
>
> On 4/5/24 9:25 AM, Andy Shevchenko wrote:
> > The GPIO library expects the drivers to return -ENOTSUPP in some
> > cases and not using analogue POSIX code. Make the driver to follow
> > this.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
> > ---
>
> Looks good to me.
>
> Reviewed-by: Kuppuswamy Sathyanarayanan <[email protected]>

Pushed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko