2015-11-22 11:32:50

by Wenwei Tao

Subject: [PATCH] lightnvm: do device max sectors boundary check first

do device max_phys_sect boundary check first, otherwise
we will allocate dma_pools for devices whose max sectors
are beyond lightnvm support and register them.

Signed-off-by: Wenwei Tao <[email protected]>
---
drivers/lightnvm/core.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index f659e60..7ecf848 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -312,6 +312,11 @@ int nvm_register(struct request_queue *q, char *disk_name,
list_add(&dev->devices, &nvm_devices);
up_write(&nvm_lock);

+ if (dev->ops->max_phys_sect > 256) {
+ pr_info("nvm: max sectors supported is 256.\n");
+ return -EINVAL;
+ }
+
if (dev->ops->max_phys_sect > 1) {
dev->ppalist_pool = dev->ops->create_dma_pool(dev->q,
"ppalist");
@@ -319,9 +324,6 @@ int nvm_register(struct request_queue *q, char *disk_name,
pr_err("nvm: could not create ppa pool\n");
return -ENOMEM;
}
- } else if (dev->ops->max_phys_sect > 256) {
- pr_info("nvm: max sectors supported is 256.\n");
- return -EINVAL;
}

return 0;
--
1.9.1

2015-11-22 18:28:38

by Matias Bjørling

Subject: Re: [PATCH] lightnvm: do device max sectors boundary check first

On 11/22/2015 12:30 PM, Wenwei Tao wrote:
> do device max_phys_sect boundary check first, otherwise
> we will allocate dma_pools for devices whose max sectors
> are beyond lightnvm support and register them.
>
> Signed-off-by: Wenwei Tao <[email protected]>
> ---
> drivers/lightnvm/core.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index f659e60..7ecf848 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -312,6 +312,11 @@ int nvm_register(struct request_queue *q, char *disk_name,
> list_add(&dev->devices, &nvm_devices);
> up_write(&nvm_lock);
>
> + if (dev->ops->max_phys_sect > 256) {
> + pr_info("nvm: max sectors supported is 256.\n");
> + return -EINVAL;
> + }
> +
> if (dev->ops->max_phys_sect > 1) {
> dev->ppalist_pool = dev->ops->create_dma_pool(dev->q,
> "ppalist");
> @@ -319,9 +324,6 @@ int nvm_register(struct request_queue *q, char *disk_name,
> pr_err("nvm: could not create ppa pool\n");
> return -ENOMEM;
> }
> - } else if (dev->ops->max_phys_sect > 256) {
> - pr_info("nvm: max sectors supported is 256.\n");
> - return -EINVAL;
> }
>
> return 0;
>
Thanks, applied.

ps. also send it to [email protected] in the future. Then we
can get a couple more eyes on it. Thanks.