2016-03-11 03:11:17

by Wei Ni

[permalink] [raw]
Subject: [PATCH V7 08/12] of: add notes of critical trips for soctherm

The "critical" type trip in thermal zone can be
set to SOC_THERM hardware, it can trigger shut down
or reset event from hardware.

Signed-off-by: Wei Ni <[email protected]>
Acked-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
index 6b68cd150405..351a7376baa8 100644
--- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
+++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
@@ -26,6 +26,10 @@ Required properties :
of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a
list of valid values when referring to thermal sensors.

+Note:
+- the "critical" type trip points will be set to SOC_THERM hardware as the
+shut down temperature. Once the temperature of this thermal zone is higher
+than it, the system will be shutdown or reset by hardware.

Example :

@@ -51,5 +55,13 @@ Example: referring to thermal sensors :

thermal-sensors =
<&soctherm TEGRA124_SOCTHERM_SENSOR_CPU>;
+
+ trips {
+ cpu_shutdown_trip: shutdown-trip {
+ temperature = <102500>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
};
};
--
1.9.1


2016-03-14 21:00:34

by Eduardo Valentin

[permalink] [raw]
Subject: Re: [PATCH V7 08/12] of: add notes of critical trips for soctherm

On Fri, Mar 11, 2016 at 11:11:00AM +0800, Wei Ni wrote:
> The "critical" type trip in thermal zone can be
> set to SOC_THERM hardware, it can trigger shut down
> or reset event from hardware.
>
> Signed-off-by: Wei Ni <[email protected]>
> Acked-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)

I did not see in your patch set an update on the compatible string for
the new chip. Did I miss something?


Attachments:
(No filename) (510.00 B)
signature.asc (473.00 B)
Digital signature
Download all attachments

2016-03-15 07:49:44

by Wei Ni

[permalink] [raw]
Subject: Re: [PATCH V7 08/12] of: add notes of critical trips for soctherm



On 2016年03月15日 05:00, Eduardo Valentin wrote:
> * PGP Signed by an unknown key
>
> On Fri, Mar 11, 2016 at 11:11:00AM +0800, Wei Ni wrote:
>> The "critical" type trip in thermal zone can be
>> set to SOC_THERM hardware, it can trigger shut down
>> or reset event from hardware.
>>
>> Signed-off-by: Wei Ni <[email protected]>
>> Acked-by: Rob Herring <[email protected]>
>> ---
>> Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>
> I did not see in your patch set an update on the compatible string for
> the new chip. Did I miss something?

As I said in the previous [00/12], the "commit 193c9d23a0f0" already added the
compatible string. At that time, it just used current tegra_soctherm.c driver to
support Tegra210, it can work, but can't show temperatures correctly.

>
> * Unknown Key
> * 0x7DA4E256
>

2016-03-15 08:14:10

by Wei Ni

[permalink] [raw]
Subject: Re: [PATCH V7 08/12] of: add notes of critical trips for soctherm



On 2016年03月15日 15:49, Wei Ni wrote:
>
>
> On 2016年03月15日 05:00, Eduardo Valentin wrote:
>> * PGP Signed by an unknown key
>>
>> On Fri, Mar 11, 2016 at 11:11:00AM +0800, Wei Ni wrote:
>>> The "critical" type trip in thermal zone can be
>>> set to SOC_THERM hardware, it can trigger shut down
>>> or reset event from hardware.
>>>
>>> Signed-off-by: Wei Ni <[email protected]>
>>> Acked-by: Rob Herring <[email protected]>
>>> ---
>>> Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>
>> I did not see in your patch set an update on the compatible string for
>> the new chip. Did I miss something?
>
> As I said in the previous [00/12], the "commit 193c9d23a0f0" already added the
> compatible string. At that time, it just used current tegra_soctherm.c driver to
> support Tegra210, it can work, but can't show temperatures correctly.

Oh, sorry, I made a mistake, this "commit 193c9d23a0f0" just added the
compatible string, did not use current tegra_soctherm driver to support Tegra210.

Wei.

>
>>
>> * Unknown Key
>> * 0x7DA4E256
>>

2016-03-15 19:52:08

by Eduardo Valentin

[permalink] [raw]
Subject: Re: [PATCH V7 08/12] of: add notes of critical trips for soctherm

On Tue, Mar 15, 2016 at 04:14:15PM +0800, Wei Ni wrote:
>
>
> On 2016年03月15日 15:49, Wei Ni wrote:
> >
> >
> > On 2016年03月15日 05:00, Eduardo Valentin wrote:
> >> * PGP Signed by an unknown key
> >>
> >> On Fri, Mar 11, 2016 at 11:11:00AM +0800, Wei Ni wrote:
> >>> The "critical" type trip in thermal zone can be
> >>> set to SOC_THERM hardware, it can trigger shut down
> >>> or reset event from hardware.
> >>>
> >>> Signed-off-by: Wei Ni <[email protected]>
> >>> Acked-by: Rob Herring <[email protected]>
> >>> ---
> >>> Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++
> >>> 1 file changed, 12 insertions(+)
> >>
> >> I did not see in your patch set an update on the compatible string for
> >> the new chip. Did I miss something?
> >
> > As I said in the previous [00/12], the "commit 193c9d23a0f0" already added the
> > compatible string. At that time, it just used current tegra_soctherm.c driver to
> > support Tegra210, it can work, but can't show temperatures correctly.
>
> Oh, sorry, I made a mistake, this "commit 193c9d23a0f0" just added the
> compatible string, did not use current tegra_soctherm driver to support Tegra210.

Ok. got it. The binding is done, but the driver is being re factored only
now to add the support for this chip version.

>
> Wei.
>
> >
> >>
> >> * Unknown Key
> >> * 0x7DA4E256
> >>


Attachments:
(No filename) (1.34 kB)
signature.asc (473.00 B)
Digital signature
Download all attachments