2016-03-16 07:42:39

by Dan Carpenter

Subject: [patch] ALSA: mixart: silence an uninitialized variable warning

We could print the uninitialized value of "stat" in the error message.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index bc81b9f..25c0ddd 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
}

if(start) {
- u32 stat;
+ u32 stat = 0;

group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */

2016-03-16 08:23:11

by walter harms

Subject: Re: [patch] ALSA: mixart: silence an uninitialized variable warning

Am 16.03.2016 08:42, schrieb Dan Carpenter:
> We could print the uninitialized value of "stat" in the error message.
>
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
> index bc81b9f..25c0ddd 100644
> --- a/sound/pci/mixart/mixart.c
> +++ b/sound/pci/mixart/mixart.c
> @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
> }
>
> if(start) {
> - u32 stat;
> + u32 stat = 0;
>
> group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
>

@maintainer:
can someone please fix/remove the comment here ? it read like if (pipe_count==0) pipe_count = 0.

just my 2 cents,

re,
wh

> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

2016-03-16 15:35:37

by Takashi Iwai

Subject: Re: [alsa-devel] [patch] ALSA: mixart: silence an uninitialized variable warning

On Wed, 16 Mar 2016 08:42:13 +0100,
Dan Carpenter wrote:
>
> We could print the uninitialized value of "stat" in the error message.
>
> Signed-off-by: Dan Carpenter <[email protected]>

Applied, thanks.


Takashi

>
> diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
> index bc81b9f..25c0ddd 100644
> --- a/sound/pci/mixart/mixart.c
> +++ b/sound/pci/mixart/mixart.c
> @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
> }
>
> if(start) {
> - u32 stat;
> + u32 stat = 0;
>
> group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
>
> _______________________________________________
> Alsa-devel mailing list
> [email protected]
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>