2023-09-13 18:36:23

by Bagas Sanjaya

Subject: Re: [REBASE PATCH v5 01/17] docs: qcom: Add qualcomm minidump guide

On Mon, Sep 11, 2023 at 04:23:43PM +0530, Mukesh Ojha wrote:
> +Qualcomm APSS Minidump kernel driver concept
> +--------------------------------------------
> +::
> +
> <snipped>...
> +Dump collection
> +---------------
> +
> + +-----------+
> + | |
> + | | +------+
> + | | | |
> + | | +--+---+ Product(Qualcomm SoC)
> + +-----------+ |
> + |+++++++++++|<------------+
> + |+++++++++++| usb cable
> + +-----------+
> + x86_64 PC
> +

Sphinx reports htmldocs warnings:

/home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:100: WARNING: Literal block expected; none found.
/home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:243: WARNING: Unexpected indentation.
/home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:234: WARNING: Malformed table.

+-----------+
| |
| | +------+
| | | |
| | +--+---+ Product(Qualcomm SoC)
+-----------+ |
|+++++++++++|<------------+
|+++++++++++| usb cable
+-----------+
/home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:243: WARNING: Blank line required after table.

I have to apply the fixup:

---- >8 ----
diff --git a/Documentation/admin-guide/qcom_minidump.rst b/Documentation/admin-guide/qcom_minidump.rst
index 20202da8ca40b9..5709a3853ae7ea 100644
--- a/Documentation/admin-guide/qcom_minidump.rst
+++ b/Documentation/admin-guide/qcom_minidump.rst
@@ -95,7 +95,6 @@ could be anywhere scattered in the DDR.

Qualcomm APSS Minidump kernel driver concept
--------------------------------------------
-::

Qualcomm APSS minidump kernel driver adds the capability to add Linux
region to be dumped as part of RAM dump collection. At the moment,
@@ -231,6 +230,8 @@ respective dump as per set download mode.
Dump collection
---------------

+::
+
+-----------+
| |
| | +------+

Thanks.

--
An old man doll... just what I always wanted! - Clara

2023-09-14 01:25:56

by Mukesh Ojha

Subject: Re: [REBASE PATCH v5 01/17] docs: qcom: Add qualcomm minidump guide

On 9/13/2023 2:55 PM, Bagas Sanjaya wrote:
> On Mon, Sep 11, 2023 at 04:23:43PM +0530, Mukesh Ojha wrote:
>> +Qualcomm APSS Minidump kernel driver concept
>> +--------------------------------------------
>> +::
>> +
>> <snipped>...
>> +Dump collection
>> +---------------
>> +
>> + +-----------+
>> + | |
>> + | | +------+
>> + | | | |
>> + | | +--+---+ Product(Qualcomm SoC)
>> + +-----------+ |
>> + |+++++++++++|<------------+
>> + |+++++++++++| usb cable
>> + +-----------+
>> + x86_64 PC
>> +
>
> Sphinx reports htmldocs warnings:
>
> /home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:100: WARNING: Literal block expected; none found.
> /home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:243: WARNING: Unexpected indentation.
> /home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:234: WARNING: Malformed table.
>
> +-----------+
> | |
> | | +------+
> | | | |
> | | +--+---+ Product(Qualcomm SoC)
> +-----------+ |
> |+++++++++++|<------------+
> |+++++++++++| usb cable
> +-----------+
> /home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:243: WARNING: Blank line required after table.
>
> I have to apply the fixup:
>
> ---- >8 ----
> diff --git a/Documentation/admin-guide/qcom_minidump.rst b/Documentation/admin-guide/qcom_minidump.rst
> index 20202da8ca40b9..5709a3853ae7ea 100644
> --- a/Documentation/admin-guide/qcom_minidump.rst
> +++ b/Documentation/admin-guide/qcom_minidump.rst
> @@ -95,7 +95,6 @@ could be anywhere scattered in the DDR.
>
> Qualcomm APSS Minidump kernel driver concept
> --------------------------------------------
> -::
>
> Qualcomm APSS minidump kernel driver adds the capability to add Linux
> region to be dumped as part of RAM dump collection. At the moment,
> @@ -231,6 +230,8 @@ respective dump as per set download mode.
> Dump collection
> ---------------
>
> +::
> +
> +-----------+
> | |
> | | +------+
>

Thanks, will take care.


> Thanks.
>